rtmutex-tester: set correct permissions on sysfs files
PATCH 1/1 rtmutex-tester: set correct permissions on sysfs files
sysfs started complaining about cases where permissions don't match what's in the sysfs ops structure (such as allowing read without a "show" callback).
Signed-off-by Sasha Levin <[email protected]>
--- kernel/rtmutex-tester.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/rtmutex-tester.c +3 -2
@@ -14,6 +14,7 @@#include <linux/spinlock.h> #include <linux/timer.h> #include <linux/freezer.h> +#include <linux/stat.h> #include "rtmutex.h"
@@ -366,8 +367,8 @@ static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *atreturn curr - buf; } -static DEVICE_ATTR(status, 0600, sysfs_test_status, NULL); -static DEVICE_ATTR(command, 0600, NULL, sysfs_test_command); +static DEVICE_ATTR(status, S_IRUSR, sysfs_test_status, NULL); +static DEVICE_ATTR(command, S_IWUSR, NULL, sysfs_test_command);static struct bus_type rttest_subsys = { .name ="rttest" ,
Signature · 1 line
1.8.1.5
Ping?
Quoted 33 lines · Sasha Levin
sysfs started complaining about cases where permissions don't match what's in the sysfs ops structure (such as allowing read without a "show" callback).
Signed-off-by Sasha Levin <[email protected]>--- kernel/rtmutex-tester.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)kernel/rtmutex-tester.c +3
-2@@ -14,6 +14,7 @@#include <linux/spinlock.h> #include <linux/timer.h> #include <linux/freezer.h> +#include <linux/stat.h> #include "rtmutex.h" @@ -366,8 +367,8 @@ static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *atreturn curr - buf; } -static DEVICE_ATTR(status, 0600, sysfs_test_status, NULL); -static DEVICE_ATTR(command, 0600, NULL, sysfs_test_command); +static DEVICE_ATTR(status, S_IRUSR, sysfs_test_status, NULL); +static DEVICE_ATTR(command, S_IWUSR, NULL, sysfs_test_command);static struct bus_type rttest_subsys = { .name ="rttest" ,
tip-bot for Sasha Levin
merge bot[tip:core/locking] locking/rtmutex/tester: Set correct permissions on sysfs files
In reply to Sasha Levinlocking/rtmutex/tester: Set correct permissions on sysfs files
Commit-ID: 8184004ed7a0bc9538f5e825615c29fc52466bab Gitweb: http://git.kernel.org/tip/8184004ed7a0bc9538f5e825615c29fc52466bab Author: Sasha Levin <[email protected]> AuthorDate: Wed, 20 Mar 2013 11:58:25 -0400 Committer: Ingo Molnar <[email protected]> CommitDate: Wed, 10 Apr 2013 14:48:37 +0200
locking/rtmutex/tester: Set correct permissions on sysfs files
sysfs started complaining about cases where permissions don't match what's in the sysfs ops structure (such as allowing read without a "show" callback).
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- kernel/rtmutex-tester.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/rtmutex-tester.c +3 -2
@@ -14,6 +14,7 @@#include <linux/spinlock.h> #include <linux/timer.h> #include <linux/freezer.h> +#include <linux/stat.h> #include "rtmutex.h"
@@ -366,8 +367,8 @@ static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *atreturn curr - buf; } -static DEVICE_ATTR(status, 0600, sysfs_test_status, NULL); -static DEVICE_ATTR(command, 0600, NULL, sysfs_test_command); +static DEVICE_ATTR(status, S_IRUSR, sysfs_test_status, NULL); +static DEVICE_ATTR(command, S_IWUSR, NULL, sysfs_test_command);static struct bus_type rttest_subsys = { .name ="rttest" ,