Add TPM driver and ACPI support to SeaBIOS
cover Add TPM driver and ACPI support to SeaBIOS
The following set of patches is being resubmitted to add TPM support to SeaBIOS. This series only includes a subset of the total seabios TPM support that is planned. The patches included in this series provide initial foundational support that make sense to include at this point now that a passthrough vTPM is available in QEMU.
In particular, these patches add:
- a TPM driver for QEMU's TPM TIS emulation
- ACPI support for the TPM device (SSDT table)
- ACPI support for measurement logging (TCPA table)
Corey Bryant (2):
Add an implementation of a TPM TIS driver
Provide ACPI SSDT table for TPM device
Makefile | 9 ++- src/acpi-tpm-ssdt.dsl | 24 +++++ src/acpi-tpm-ssdt.hex | 27 +++++ src/acpi.c | 41 ++++++++ src/acpi.h | 20 ++++ src/config.h | 2 +- src/tcgbios.c | 70 +++++++++++++ src/tcgbios.h | 57 +++++++++++ src/tpm_drivers.c | 258 +++++++++++++++++++++++++++++++++++++++++++++++++ src/tpm_drivers.h | 90 +++++++++++++++++ 10 files changed, 596 insertions(+), 2 deletions(-) create mode 100644 src/acpi-tpm-ssdt.dsl create mode 100644 src/acpi-tpm-ssdt.hex create mode 100644 src/tcgbios.c create mode 100644 src/tcgbios.h create mode 100644 src/tpm_drivers.c create mode 100644 src/tpm_drivers.h
PATCH 1/2 Add an implementation of a TPM TIS driver
This patch adds an implementation of a TPM TIS driver for the TPM TIS emulation supported by QEMU (patches for passthrough vTPM are upstream in QEMU). Usage of the driver is broken up into several functions. The driver is cleanly separated from the rest of the code through an interface holding pointers to the driver's functions. A client using this driver first probes whether the TPM TIS interface is available (probe function) and then invokes the interface functions to initialize the interface and send requests and receive responses.
Possible future extensions *could* include a virtio interface for the TPM with a corresponding driver here.
---
Version history from prior patch submission:
v7:
- moving declaration of tpm_drivers[] into tpm_drivers.h
v6:
- reworked timeouts; not hardcoded anymore
v5:
- introducing a configurable threashold as part of the driver interface structure below which the TPM is used for calculating the sha1
v2:
- adapted tpm_drivers.c to be under LGPLv3
--- src/tpm_drivers.c | 258 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/tpm_drivers.h | 90 +++++++++++++++++++ 2 files changed, 348 insertions(+), 0 deletions(-) create mode 100644 src/tpm_drivers.c create mode 100644 src/tpm_drivers.h
src/tpm_drivers.c new file +258 -0
@@ -0,0 +1,258 @@ +// Implementation of a TPM driver for the TPM TIS interface +// +// Copyright (C) 2006-2013 IBM Corporation +// +// Authors: +// Stefan Berger <[email protected]> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +#include "config.h" +#include "util.h" +#include "tpm_drivers.h" +#include "tcgbios.h" + +static u32 tis_default_timeouts[4 ] = { +TIS_DEFAULT_TIMEOUT_A , +TIS_DEFAULT_TIMEOUT_B , +TIS_DEFAULT_TIMEOUT_C , +TIS_DEFAULT_TIMEOUT_D , +}; + +static u32 tpm_default_durations[3 ] = { +TPM_DEFAULT_DURATION_SHORT , +TPM_DEFAULT_DURATION_MEDIUM , +TPM_DEFAULT_DURATION_LONG , +}; + + +/* if device is not there, return '0', '1' otherwise */ +static u32 tis_probe (void ) +{ +u32 rc =0 ; +u32 didvid =readl (TIS_REG (0 ,TIS_REG_DID_VID )); + +if ((didvid !=0 ) && (didvid !=0xffffffff )) + rc =1 ; + +return rc; +} + +static u32 tis_init (void ) +{ +writeb (TIS_REG (0 ,TIS_REG_INT_ENABLE ),0 ); + +if (tpm_drivers[TIS_DRIVER_IDX ].durations ==NULL ) { +u32 *durations =malloc_low (sizeof (tpm_default_durations)); +if (durations) +memcpy (durations, tpm_default_durations, +sizeof (tpm_default_durations)); +else + durations = tpm_default_durations; + tpm_drivers[TIS_DRIVER_IDX ].durations = durations; + } + +if (tpm_drivers[TIS_DRIVER_IDX ].timeouts ==NULL ) { +u32 *timeouts =malloc_low (sizeof (tis_default_timeouts)); +if (timeouts) +memcpy (timeouts, tis_default_timeouts, +sizeof (tis_default_timeouts)); +else + timeouts = tis_default_timeouts; + tpm_drivers[TIS_DRIVER_IDX ].timeouts = timeouts; + } + +return 1 ; +} + + +static void set_timeouts (u32 timeouts[4 ],u32 durations[3 ]) +{ +u32 *tos = tpm_drivers[TIS_DRIVER_IDX ].timeouts; +u32 *dus = tpm_drivers[TIS_DRIVER_IDX ].durations; + +if (tos && tos != tis_default_timeouts && timeouts) +memcpy (tos, timeouts,4 *sizeof (u32)); +if (dus && dus != tpm_default_durations && durations) +memcpy (dus, durations,3 *sizeof (u32)); +} + + +static u32 tis_wait_sts (u8 locty,u32 time,u8 mask,u8 expect) +{ +u32 rc =1 ; + +while (time >0 ) { +u8 sts =readb (TIS_REG (locty,TIS_REG_STS )); +if ((sts & mask) == expect) { + rc =0 ; +break ; + } +msleep (1 ); + time--; + } +return rc; +} + +static u32 tis_activate (u8 locty) +{ +u32 rc =0 ; +u8 acc; +int l; +u32 timeout_a = tpm_drivers[TIS_DRIVER_IDX ].timeouts[TIS_TIMEOUT_TYPE_A ]; + +if (!(readb (TIS_REG (locty,TIS_REG_ACCESS )) & +TIS_ACCESS_ACTIVE_LOCALITY )) { +/* release locality in use top-downwards */ +for (l =4 ; l >=0 ; l--) +writeb (TIS_REG (l,TIS_REG_ACCESS ), +TIS_ACCESS_ACTIVE_LOCALITY ); + } + +/* request access to locality */ +writeb (TIS_REG (locty,TIS_REG_ACCESS ),TIS_ACCESS_REQUEST_USE ); + + acc =readb (TIS_REG (locty,TIS_REG_ACCESS )); +if ((acc &TIS_ACCESS_ACTIVE_LOCALITY )) { +writeb (TIS_REG (locty,TIS_REG_STS ),TIS_STS_COMMAND_READY ); + rc =tis_wait_sts (locty, timeout_a, +TIS_STS_COMMAND_READY ,TIS_STS_COMMAND_READY ); + } + +return rc; +} + +static u32 tis_find_active_locality (void ) +{ +u8 locty; + +for (locty =0 ; locty <=4 ; locty++) { +if ((readb (TIS_REG (locty,TIS_REG_ACCESS )) & +TIS_ACCESS_ACTIVE_LOCALITY )) +return locty; + } + +tis_activate (0 ); + +return 0 ; +} + +static u32 tis_ready (void ) +{ +u32 rc =0 ; +u8 locty =tis_find_active_locality (); +u32 timeout_b = tpm_drivers[TIS_DRIVER_IDX ].timeouts[TIS_TIMEOUT_TYPE_B ]; + +writeb (TIS_REG (locty,TIS_REG_STS ),TIS_STS_COMMAND_READY ); + rc =tis_wait_sts (locty, timeout_b, +TIS_STS_COMMAND_READY ,TIS_STS_COMMAND_READY ); + +return rc; +} + +static u32 tis_senddata (const u8 *const data,u32 len) +{ +u32 rc =0 ; +u32 offset =0 ; +u32 end =0 ; +u16 burst =0 ; +u32 ctr =0 ; +u8 locty =tis_find_active_locality (); +u32 timeout_d = tpm_drivers[TIS_DRIVER_IDX ].timeouts[TIS_TIMEOUT_TYPE_D ]; + +do { +while (burst ==0 && ctr < timeout_d) { + burst =readl (TIS_REG (locty,TIS_REG_STS )) >>8 ; +if (burst ==0 ) { +msleep (1 ); + ctr++; + } + } + +if (burst ==0 ) { + rc =TCG_RESPONSE_TIMEOUT ; +break ; + } + +while (1 ) { +writeb (TIS_REG (locty,TIS_REG_DATA_FIFO ), data[offset++]); + burst--; + +if (burst ==0 || offset == len) +break ; + } + +if (offset == len) + end =1 ; + }while (end ==0 ); + +return rc; +} + +static u32 tis_readresp (u8 *buffer,u32 *len) +{ +u32 rc =0 ; +u32 offset =0 ; +u32 sts; +u8 locty =tis_find_active_locality (); + +while (offset < *len) { + buffer[offset] =readb (TIS_REG (locty,TIS_REG_DATA_FIFO )); + offset++; + sts =readb (TIS_REG (locty,TIS_REG_STS )); +/* data left ? */ +if ((sts &TIS_STS_DATA_AVAILABLE ) ==0 ) +break ; + } + + *len = offset; + +return rc; +} + + +static u32 tis_waitdatavalid (void ) +{ +u32 rc =0 ; +u8 locty =tis_find_active_locality (); +u32 timeout_c = tpm_drivers[TIS_DRIVER_IDX ].timeouts[TIS_TIMEOUT_TYPE_C ]; + +if (tis_wait_sts (locty, timeout_c,TIS_STS_VALID ,TIS_STS_VALID ) !=0 ) + rc =TCG_NO_RESPONSE ; + +return rc; +} + +static u32 tis_waitrespready (enum tpmDurationType to_t) +{ +u32 rc =0 ; +u8 locty =tis_find_active_locality (); +u32 timeout = tpm_drivers[TIS_DRIVER_IDX ].durations[to_t]; + +writeb (TIS_REG (locty ,TIS_REG_STS ),TIS_STS_TPM_GO ); + +if (tis_wait_sts (locty, timeout, +TIS_STS_DATA_AVAILABLE ,TIS_STS_DATA_AVAILABLE ) !=0 ) + rc =TCG_NO_RESPONSE ; + +return rc; +} + + +struct tpm_driver tpm_drivers[TPM_NUM_DRIVERS ] = { + [TIS_DRIVER_IDX ] = + { + .timeouts =NULL , + .durations =NULL , + .set_timeouts = set_timeouts, + .probe = tis_probe, + .init = tis_init, + .activate = tis_activate, + .ready = tis_ready, + .senddata = tis_senddata, + .readresp = tis_readresp, + .waitdatavalid = tis_waitdatavalid, + .waitrespready = tis_waitrespready, + .sha1threshold =100 *1024 , + }, +};
src/tpm_drivers.h new file +90 -0
90 lines not on this page · raw message
Signature · 1 line
1.7.1
PATCH 2/2 Provide ACPI SSDT table for TPM device
In reply to Corey BryantThis patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT.
Since the logging area in the TCPA table requires 64kb, the memory reserved for ACPI tables (config.h) is increased to 96kb.
The IRQ description in the TPM's SSDT is commented since it will be 'safer' to run the TPM in polling mode - the Linux TPM TIS driver for example has too many issues when run in interrupt mode.
The description of the TCPA (client) table can be found here:
The compiled SSDT description is also part of this patch.
---
Version history from prior patch submission:
v6:
- following Andreas Niederl's suggestion: enclosing Device(TPM) in Scope(\_SB) { ... } to have Linux 2.6.33 recognize the device properly; seems to work fine with 3.0.0
v2:
- Increasing the CONFIG_MAX_HIGHTABLE to 96kb
- Adding cut-down tcgbios.c|h to keep SeaBIOS compiling
- Build tpm_drivers.c and tcgbios.c
-> TPM's SSDT and TCPA tables are now visible in Linux --- Makefile | 9 +++++- src/acpi-tpm-ssdt.dsl | 24 +++++++++++++++++ src/acpi-tpm-ssdt.hex | 27 +++++++++++++++++++ src/acpi.c | 41 ++++++++++++++++++++++++++++ src/acpi.h | 20 ++++++++++++++ src/config.h | 2 +- src/tcgbios.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++ src/tcgbios.h | 57 +++++++++++++++++++++++++++++++++++++++ 8 files changed, 248 insertions(+), 2 deletions(-) create mode 100644 src/acpi-tpm-ssdt.dsl create mode 100644 src/acpi-tpm-ssdt.hex create mode 100644 src/tcgbios.c create mode 100644 src/tcgbios.h
Makefile +8 -1
@@ -18,7 +18,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c pmm.c coreboot.c boot.c \ acpi.c smm.c mptable.c pirtable.c smbios.c pciinit.c optionroms.c mtrr.c \ lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \ - biostables.c xen.c bmp.c romfile.c csm.c + biostables.c xen.c bmp.c romfile.c csm.c tcgbios.c tpm_drivers.c SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c # Default compiler flags
@@ -215,6 +215,13 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \ ; then echo "$(2)"; else echo "$(3)"; fi ;) +src/acpi-tpm-ssdt.hex: src/acpi-tpm-ssdt.dsl + @echo "Compiling TPM SSDT" + $(Q)cpp -P $< > $(OUT)$*.dsl.i + $(Q)iasl -tc -p $(OUT)$* $(OUT)$*.dsl.i + $(Q)cp $(OUT)$*.hex $@ + $(Q)sed -i 's/AmlCode/AmlCode_TPM/' $@ + $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py @echo " Compiling IASL $@" $(Q)$(CPP) $(CPPFLAGS) $< -o $(OUT)$*.dsl.i.orig
src/acpi-tpm-ssdt.dsl new file +24 -0
@@ -0,0 +1,24 @@ +DefinitionBlock ( + "acpi-tpm-ssdt.aml",// Output Filename + "SSDT", // Signature + 0x01, // SSDT Compliance Revision + "BXPC", // OEMID + "BXSSDT", // TABLE ID + 0x1 // OEM Revision + ) +{ + Scope(\_SB) { + /* TPM with emulated TPM TIS interface */ + Device (TPM) { + Name (_HID, EisaID ("PNP0C31")) + Name (_CRS, ResourceTemplate () + { + Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000) + //IRQNoFlags () {5} + }) + Method (_STA, 0, NotSerialized) { + Return (0x0F) + } + } + } +}
src/acpi-tpm-ssdt.hex new file +27 -0
@@ -0,0 +1,27 @@ +/* + * + * Intel ACPI Component Architecture + * ASL Optimizing Compiler version 20101013-64 [Nov 21 2010] + * Copyright (c) 2000 - 2010 Intel Corporation + * + * Compilation of "out/.dsl.i" - Mon Jan 30 16:03:18 2012 + * + * C source code output + * AML code block contains 0x5D bytes + * + */ +unsigned char AmlCode_TPM[] = +{ + 0x53,0x53,0x44,0x54,0x5D,0x00,0x00,0x00, /* 00000000 "SSDT]..." */ + 0x01,0x15,0x42,0x58,0x50,0x43,0x00,0x00, /* 00000008 "..BXPC.." */ + 0x42,0x58,0x53,0x53,0x44,0x54,0x00,0x00, /* 00000010 "BXSSDT.." */ + 0x01,0x00,0x00,0x00,0x49,0x4E,0x54,0x4C, /* 00000018 "....INTL" */ + 0x13,0x10,0x10,0x20,0x10,0x38,0x5C,0x5F, /* 00000020 "... .8\_" */ + 0x53,0x42,0x5F,0x5B,0x82,0x30,0x54,0x50, /* 00000028 "SB_[.0TP" */ + 0x4D,0x5F,0x08,0x5F,0x48,0x49,0x44,0x0C, /* 00000030 "M_._HID." */ + 0x41,0xD0,0x0C,0x31,0x08,0x5F,0x43,0x52, /* 00000038 "A..1._CR" */ + 0x53,0x11,0x11,0x0A,0x0E,0x86,0x09,0x00, /* 00000040 "S......." */ + 0x01,0x00,0x00,0xD4,0xFE,0x00,0x50,0x00, /* 00000048 "......P." */ + 0x00,0x79,0x00,0x14,0x09,0x5F,0x53,0x54, /* 00000050 ".y..._ST" */ + 0x41,0x00,0xA4,0x0A,0x0F /* 00000058 "A...." */ +};
src/acpi.c +41 -0
59 lines not on this page · raw message
src/acpi.h +20 -0
@@ -130,4 +130,24 @@ struct acpi_table_mcfg {struct acpi_mcfg_allocation allocation[0 ]; } PACKED; + +struct rsdt_descriptor { +ACPI_TABLE_HEADER_DEF + u32 entry[1]; +}PACKED ; + +#define TCPA_SIGNATURE 0x41504354 +struct tcpa_descriptor_rev2 +{ +ACPI_TABLE_HEADER_DEF + u16 platform_class; +u32 laml; +u64 lasa; +}PACKED ; + +/* TCPA ACPI definitions */ +#define TCPA_ACPI_CLASS_CLIENT 0 +#define TCPA_ACPI_CLASS_SERVER 1 + +#endif // acpi.h
src/config.h +1 -1
@@ -17,7 +17,7 @@// Maximum number of map entries in the e820 map #define BUILD_MAX_E820 32// Space to reserve in high-memory for tables -#define BUILD_MAX_HIGHTABLE (64*1024) +#define BUILD_MAX_HIGHTABLE (96*1024)// Largest supported externaly facing drive id #define BUILD_MAX_EXTDRIVE 16// Number of bytes the smbios may be and still live in the f-segment
src/tcgbios.c new file +70 -0
70 lines not on this page · raw message
src/tcgbios.h new file +57 -0
57 lines not on this page · raw message
Signature · 1 line
1.7.1
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Il 26/03/2013 15:14, Corey Bryant ha scritto:
Quoted 11 lines
This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT.
Since the logging area in the TCPA table requires 64kb, the memory reserved for ACPI tables (
config.h) is increased to 96kb.The IRQ description in the TPM's SSDT is commented since it will be 'safer' to run the TPM in polling mode - the Linux TPM TIS driver for example has too many issues when run in interrupt mode.
Quoted 5 lines
The description of the TCPA (client) table can be found here:
The compiled SSDT description is also part of this patch.
There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.
Paolo
Quoted 368 lines
Signed-off-by Stefan Berger <[email protected]>Signed-off-by Corey Bryant <[email protected]>---
Version history from prior patch submission:v6:
- following Andreas Niederl's suggestion: enclosing Device(TPM) inScope(\_SB){ ... } to have Linux 2.6.33 recognize the device properly; seems to work fine with 3.0.0v2:
- Increasing theCONFIG_MAX_HIGHTABLEto 96kb
- Adding cut-down tcgbios.c|h to keep SeaBIOS compiling
- Buildtpm_drivers.candtcgbios.c-> TPM's SSDT and TCPA tables are now visible in Linux --- Makefile | 9 +++++- src/acpi-tpm-ssdt.dsl | 24 +++++++++++++++++ src/acpi-tpm-ssdt.hex | 27 +++++++++++++++++++ src/acpi.c | 41 ++++++++++++++++++++++++++++ src/acpi.h | 20 ++++++++++++++ src/config.h | 2 +- src/tcgbios.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++ src/tcgbios.h | 57 +++++++++++++++++++++++++++++++++++++++ 8 files changed, 248 insertions(+), 2 deletions(-) create mode 100644 src/acpi-tpm-ssdt.dsl create mode 100644 src/acpi-tpm-ssdt.hex create mode 100644 src/tcgbios.c create mode 100644 src/tcgbios.hMakefile +8
-1@@ -18,7 +18,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c pmm.c coreboot.c boot.c \ acpi.c smm.c mptable.c pirtable.c smbios.c pciinit.c optionroms.c mtrr.c \ lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \ - biostables.c xen.c bmp.c romfile.c csm.c + biostables.c xen.c bmp.c romfile.c csm.c tcgbios.c tpm_drivers.c SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c # Default compiler flags@@ -215,6 +215,13 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \ ; then echo "$(2)"; else echo "$(3)"; fi ;) +src/acpi-tpm-ssdt.hex: src/acpi-tpm-ssdt.dsl + @echo "Compiling TPM SSDT" + $(Q)cpp -P $< > $(OUT)$*.dsl.i + $(Q)iasl -tc -p $(OUT)$* $(OUT)$*.dsl.i + $(Q)cp $(OUT)$*.hex $@ + $(Q)sed -i 's/AmlCode/AmlCode_TPM/' $@ + $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py @echo " Compiling IASL $@" $(Q)$(CPP) $(CPPFLAGS) $< -o $(OUT)$*.dsl.i.origsrc/acpi-tpm-ssdt.dsl new file +24
-0@@ -0,0 +1,24 @@ +DefinitionBlock ( + "acpi-tpm-ssdt.aml",// Output Filename + "SSDT", // Signature + 0x01, // SSDT Compliance Revision + "BXPC", // OEMID + "BXSSDT", // TABLE ID + 0x1 // OEM Revision + ) +{ + Scope(\_SB) { + /* TPM with emulated TPM TIS interface */ + Device (TPM) { + Name (_HID, EisaID ("PNP0C31")) + Name (_CRS, ResourceTemplate () + { + Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000) + //IRQNoFlags () {5} + }) + Method (_STA, 0, NotSerialized) { + Return (0x0F) + } + } + } +}src/acpi-tpm-ssdt.hex new file +27
-0@@ -0,0 +1,27 @@ +/* + * + * Intel ACPI Component Architecture + * ASL Optimizing Compiler version 20101013-64 [Nov 21 2010] + * Copyright (c) 2000 - 2010 Intel Corporation + * + * Compilation of "out/.dsl.i" - Mon Jan 30 16:03:18 2012 + * + * C source code output + * AML code block contains 0x5D bytes + * + */ +unsigned char AmlCode_TPM[] = +{ + 0x53,0x53,0x44,0x54,0x5D,0x00,0x00,0x00, /* 00000000 "SSDT]..." */ + 0x01,0x15,0x42,0x58,0x50,0x43,0x00,0x00, /* 00000008 "..BXPC.." */ + 0x42,0x58,0x53,0x53,0x44,0x54,0x00,0x00, /* 00000010 "BXSSDT.." */ + 0x01,0x00,0x00,0x00,0x49,0x4E,0x54,0x4C, /* 00000018 "....INTL" */ + 0x13,0x10,0x10,0x20,0x10,0x38,0x5C,0x5F, /* 00000020 "... .8\_" */ + 0x53,0x42,0x5F,0x5B,0x82,0x30,0x54,0x50, /* 00000028 "SB_[.0TP" */ + 0x4D,0x5F,0x08,0x5F,0x48,0x49,0x44,0x0C, /* 00000030 "M_._HID." */ + 0x41,0xD0,0x0C,0x31,0x08,0x5F,0x43,0x52, /* 00000038 "A..1._CR" */ + 0x53,0x11,0x11,0x0A,0x0E,0x86,0x09,0x00, /* 00000040 "S......." */ + 0x01,0x00,0x00,0xD4,0xFE,0x00,0x50,0x00, /* 00000048 "......P." */ + 0x00,0x79,0x00,0x14,0x09,0x5F,0x53,0x54, /* 00000050 ".y..._ST" */ + 0x41,0x00,0xA4,0x0A,0x0F /* 00000058 "A...." */ +};src/acpi.c +41
-0@@ -15,6 +15,8 @@#include "config.h" // CONFIG_* #include "paravirt.h" // RamSize #include "dev-q35.h" +#include "acpi-tpm-ssdt.hex" +#include "tcgbios.h" // has_working_tpm /****************************************************/ /* ACPI tables init */ @@ -762,6 +764,39 @@ static const struct pci_device_id acpi_find_tbl[] = { PCI_DEVICE_END, }; + +static u32 add_tpm_device (void **tpm_addr,void **tcpa_addr) +{ +struct tcpa_descriptor_rev2 *tcpa; + + *tpm_addr =NULL ; + *tcpa_addr =NULL ; + +if (has_working_tpm ()) { +u32 laml =64 *1024 ; + *tpm_addr =malloc_high (sizeof (AmlCode_TPM)); + + tcpa =malloc_high (sizeof (*tcpa) + laml); +if (!tcpa || !*tpm_addr) { +warn_noalloc (); +return 1 ; + } + +if (*tpm_addr) +memcpy (*tpm_addr, AmlCode_TPM,sizeof (AmlCode_TPM)); + +memset (tcpa,0x0 ,sizeof (*tcpa) + laml); +u64 lasa = (u32 )tcpa +sizeof (*tcpa); + + tcpa->laml = laml; + tcpa->lasa = lasa; +build_header ((void *)tcpa,TCPA_SIGNATURE ,sizeof (*tcpa),2 ); + + *tcpa_addr = tcpa; + } +return 0 ; +} +struct rsdp_descriptor *RsdpAddr;#define MAX_ACPI_TABLES 20@@ -835,6 +870,12 @@ acpi_setup(void)fill_dsdt (fadt, dsdt); } +void *tcpa, *tpm; +if (add_tpm_device (&tpm, &tcpa)) +return ; +ACPI_INIT_TABLE (tpm); +ACPI_INIT_TABLE (tcpa); +// Build final rsdt table struct rsdt_descriptor_rev1 *rsdt;size_t rsdt_len =sizeof (*rsdt) +sizeof (u32) * tbl_idx;src/acpi.h +20
-0@@ -130,4 +130,24 @@ struct acpi_table_mcfg {struct acpi_mcfg_allocation allocation[0 ]; } PACKED; + +struct rsdt_descriptor { +ACPI_TABLE_HEADER_DEF + u32 entry[1]; +}PACKED ; + +#define TCPA_SIGNATURE 0x41504354 +struct tcpa_descriptor_rev2 +{ +ACPI_TABLE_HEADER_DEF + u16 platform_class; +u32 laml; +u64 lasa; +}PACKED ; + +/* TCPA ACPI definitions */ +#define TCPA_ACPI_CLASS_CLIENT 0 +#define TCPA_ACPI_CLASS_SERVER 1 + +#endif // acpi.h src/config.h +1
-1@@ -17,7 +17,7 @@// Maximum number of map entries in the e820 map #define BUILD_MAX_E820 32// Space to reserve in high-memory for tables -#define BUILD_MAX_HIGHTABLE (64*1024) +#define BUILD_MAX_HIGHTABLE (96*1024)// Largest supported externaly facing drive id #define BUILD_MAX_EXTDRIVE 16// Number of bytes the smbios may be and still live in the f-segment src/tcgbios.c new file +70
-0@@ -0,0 +1,70 @@ +// Implementation of the TCG BIOS extension according to the specification +// described in +// https://www.trustedcomputinggroup.org/specs/PCClient/TCG_PCClientImplementationforBIOS_1-20_1-00.pdf +// +// Copyright (C) 2006-2013 IBM Corporation +// +// Authors: +// Stefan Berger <[email protected]> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + + +#include "config.h" + +#include "types.h" +#include "tpm_drivers.h" // tpm_drivers[] + + +typedef struct { +u8 tpm_probed:1 ; +u8 tpm_found:1 ; +u8 tpm_working:1 ; +u8 if_shutdown:1 ; +u8 tpm_driver_to_use:4 ; +}tcpa_state_t ; + + +static tcpa_state_t tcpa_state = { + .tpm_driver_to_use =TPM_INVALID_DRIVER , +}; + + +/******************************************************** +Extensions for TCG-enabled BIOS +*******************************************************/ + + +static u32 +is_tpm_present (void ) +{ +u32 rc =0 ; +unsigned int i; + +for (i =0 ; i <TPM_NUM_DRIVERS ; i++) { +struct tpm_driver *td = &tpm_drivers[i]; +if (td->probe () !=0 ) { + td->init (); + tcpa_state.tpm_driver_to_use = i; + rc =1 ; +break ; + } + } + +return rc; +} + + +int +has_working_tpm (void ) +{ +if (!tcpa_state.tpm_probed) { + tcpa_state.tpm_probed =1 ; + tcpa_state.tpm_found = (is_tpm_present () !=0 ); + tcpa_state.tpm_working =1 ; + } +if (!tcpa_state.tpm_working) +return 0 ; + +return tcpa_state.tpm_found; +}src/tcgbios.h new file +57
-0@@ -0,0 +1,57 @@ +#ifndef TCGBIOS_H +#define TCGBIOS_H + + +#define TPM_OK 0x0 +#define TPM_RET_BASE 0x1 +#define TCG_GENERAL_ERROR (TPM_RET_BASE + 0x0) +#define TCG_TPM_IS_LOCKED (TPM_RET_BASE + 0x1) +#define TCG_NO_RESPONSE (TPM_RET_BASE + 0x2) +#define TCG_INVALID_RESPONSE (TPM_RET_BASE + 0x3) +#define TCG_INVALID_ACCESS_REQUEST (TPM_RET_BASE + 0x4) +#define TCG_FIRMWARE_ERROR (TPM_RET_BASE + 0x5) +#define TCG_INTEGRITY_CHECK_FAILED (TPM_RET_BASE + 0x6) +#define TCG_INVALID_DEVICE_ID (TPM_RET_BASE + 0x7) +#define TCG_INVALID_VENDOR_ID (TPM_RET_BASE + 0x8) +#define TCG_UNABLE_TO_OPEN (TPM_RET_BASE + 0x9) +#define TCG_UNABLE_TO_CLOSE (TPM_RET_BASE + 0xa) +#define TCG_RESPONSE_TIMEOUT (TPM_RET_BASE + 0xb) +#define TCG_INVALID_COM_REQUEST (TPM_RET_BASE + 0xc) +#define TCG_INVALID_ADR_REQUEST (TPM_RET_BASE + 0xd) +#define TCG_WRITE_BYTE_ERROR (TPM_RET_BASE + 0xe) +#define TCG_READ_BYTE_ERROR (TPM_RET_BASE + 0xf) +#define TCG_BLOCK_WRITE_TIMEOUT (TPM_RET_BASE + 0x10) +#define TCG_CHAR_WRITE_TIMEOUT (TPM_RET_BASE + 0x11) +#define TCG_CHAR_READ_TIMEOUT (TPM_RET_BASE + 0x12) +#define TCG_BLOCK_READ_TIMEOUT (TPM_RET_BASE + 0x13) +#define TCG_TRANSFER_ABORT (TPM_RET_BASE + 0x14) +#define TCG_INVALID_DRV_FUNCTION (TPM_RET_BASE + 0x15) +#define TCG_OUTPUT_BUFFER_TOO_SHORT (TPM_RET_BASE + 0x16) +#define TCG_FATAL_COM_ERROR (TPM_RET_BASE + 0x17) +#define TCG_INVALID_INPUT_PARA (TPM_RET_BASE + 0x18) +#define TCG_TCG_COMMAND_ERROR (TPM_RET_BASE + 0x19) +#define TCG_INTERFACE_SHUTDOWN (TPM_RET_BASE + 0x20) +//define TCG_PC_UNSUPPORTED (TPM_RET_BASE + 0x21) +#define TCG_PC_TPM_NOT_PRESENT (TPM_RET_BASE + 0x22) +#define TCG_PC_TPM_DEACTIVATED (TPM_RET_BASE + 0x23) + + +#define TPM_INVALID_ADR_REQUEST TCG_INVALID_ADR_REQUEST +#define TPM_IS_LOCKED TCG_TPM_IS_LOCKED +#define TPM_INVALID_DEVICE_ID TCG_INVALID_DEVICE_ID +#define TPM_INVALID_VENDOR_ID TCG_INVALID_VENDOR_ID +//define TPM_RESERVED_REG_INVALID +#define TPM_FIRMWARE_ERROR TCG_FIRMWARE_ERROR +#define TPM_UNABLE_TO_OPEN TCG_UNABLE_TO_OPEN +#define TPM_UNABLE_TO_CLOSE TCG_UNABLE_TO_CLOSE +#define TPM_INVALID_RESPONSE TCG_INVALID_RESPONSE +#define TPM_RESPONSE_TIMEOUT TCG_RESPONSE_TIMEOUT +#define TPM_INVALID_ACCESS_REQUEST TCG_INVALID_ACCESS_REQUEST +#define TPM_TRANSFER_ABORT TCG_TRANSFER_ABORT +#define TPM_GENERAL_ERROR TCG_GENERAL_ERROR + + +int has_working_tpm (void ); + + +#endif /* TCGBIOS_H */
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Quoted 16 lines · Paolo Bonzini
Il 26/03/2013 15:14, Corey Bryant ha scritto:
Quoted 15 lines
This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT.
Since the logging area in the TCPA table requires 64kb, the memory reserved for ACPI tables (
config.h) is increased to 96kb.The IRQ description in the TPM's SSDT is commented since it will be 'safer' to run the TPM in polling mode - the Linux TPM TIS driver for example has too many issues when run in interrupt mode.
The description of the TCPA (client) table can be found here:
Quoted 8 lines
Quoted 1 line
The compiled SSDT description is also part of this patch.
There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.
Paolo
Kevin, Do you have a preference whether we add these ACPI tables to SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in SeaBIOS and this adds probably 200 bytes of code and data. Basically it creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
Signature · 2 lines
Regards, Corey Bryant
Quoted 369 lines
Quoted 368 lines
Signed-off-by Stefan Berger <[email protected]>Signed-off-by Corey Bryant <[email protected]>---
Version history from prior patch submission:v6:
- following Andreas Niederl's suggestion: enclosing Device(TPM) inScope(\_SB){ ... } to have Linux 2.6.33 recognize the device properly; seems to work fine with 3.0.0v2:
- Increasing theCONFIG_MAX_HIGHTABLEto 96kb
- Adding cut-down tcgbios.c|h to keep SeaBIOS compiling
- Buildtpm_drivers.candtcgbios.c-> TPM's SSDT and TCPA tables are now visible in Linux --- Makefile | 9 +++++- src/acpi-tpm-ssdt.dsl | 24 +++++++++++++++++ src/acpi-tpm-ssdt.hex | 27 +++++++++++++++++++ src/acpi.c | 41 ++++++++++++++++++++++++++++ src/acpi.h | 20 ++++++++++++++ src/config.h | 2 +- src/tcgbios.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++ src/tcgbios.h | 57 +++++++++++++++++++++++++++++++++++++++ 8 files changed, 248 insertions(+), 2 deletions(-)create mode 100644 src/acpi-tpm-ssdt.dsl
create mode 100644 src/acpi-tpm-ssdt.hex
create mode 100644src/tcgbios.c
create mode 100644src/tcgbios.hMakefile +8
-1@@ -18,7 +18,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c pmm.c coreboot.c boot.c \ acpi.c smm.c mptable.c pirtable.c smbios.c pciinit.c optionroms.c mtrr.c \ lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \ - biostables.c xen.c bmp.c romfile.c csm.c + biostables.c xen.c bmp.c romfile.c csm.c tcgbios.c tpm_drivers.c SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c # Default compiler flags@@ -215,6 +215,13 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \ ; then echo "$(2)"; else echo "$(3)"; fi ;) +src/acpi-tpm-ssdt.hex: src/acpi-tpm-ssdt.dsl + @echo "Compiling TPM SSDT" + $(Q)cpp -P $< > $(OUT)$*.dsl.i + $(Q)iasl -tc -p $(OUT)$* $(OUT)$*.dsl.i + $(Q)cp $(OUT)$*.hex $@ + $(Q)sed -i 's/AmlCode/AmlCode_TPM/' $@ + $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py @echo " Compiling IASL $@" $(Q)$(CPP) $(CPPFLAGS) $< -o $(OUT)$*.dsl.i.origsrc/acpi-tpm-ssdt.dsl new file +24
-0@@ -0,0 +1,24 @@ +DefinitionBlock ( + "acpi-tpm-ssdt.aml",// Output Filename + "SSDT", // Signature + 0x01, // SSDT Compliance Revision + "BXPC", // OEMID + "BXSSDT", // TABLE ID + 0x1 // OEM Revision + ) +{ + Scope(\_SB) { + /* TPM with emulated TPM TIS interface */ + Device (TPM) { + Name (_HID, EisaID ("PNP0C31")) + Name (_CRS, ResourceTemplate () + { + Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000) + //IRQNoFlags () {5} + }) + Method (_STA, 0, NotSerialized) { + Return (0x0F) + } + } + } +}src/acpi-tpm-ssdt.hex new file +27
-0@@ -0,0 +1,27 @@ +/* + * + * Intel ACPI Component Architecture + * ASL Optimizing Compiler version 20101013-64 [Nov 21 2010] + * Copyright (c) 2000 - 2010 Intel Corporation + * + * Compilation of "out/.dsl.i" - Mon Jan 30 16:03:18 2012 + * + * C source code output + * AML code block contains 0x5D bytes + * + */ +unsigned char AmlCode_TPM[] = +{ + 0x53,0x53,0x44,0x54,0x5D,0x00,0x00,0x00, /* 00000000 "SSDT]..." */ + 0x01,0x15,0x42,0x58,0x50,0x43,0x00,0x00, /* 00000008 "..BXPC.." */ + 0x42,0x58,0x53,0x53,0x44,0x54,0x00,0x00, /* 00000010 "BXSSDT.." */ + 0x01,0x00,0x00,0x00,0x49,0x4E,0x54,0x4C, /* 00000018 "....INTL" */ + 0x13,0x10,0x10,0x20,0x10,0x38,0x5C,0x5F, /* 00000020 "... .8\_" */ + 0x53,0x42,0x5F,0x5B,0x82,0x30,0x54,0x50, /* 00000028 "SB_[.0TP" */ + 0x4D,0x5F,0x08,0x5F,0x48,0x49,0x44,0x0C, /* 00000030 "M_._HID." */ + 0x41,0xD0,0x0C,0x31,0x08,0x5F,0x43,0x52, /* 00000038 "A..1._CR" */ + 0x53,0x11,0x11,0x0A,0x0E,0x86,0x09,0x00, /* 00000040 "S......." */ + 0x01,0x00,0x00,0xD4,0xFE,0x00,0x50,0x00, /* 00000048 "......P." */ + 0x00,0x79,0x00,0x14,0x09,0x5F,0x53,0x54, /* 00000050 ".y..._ST" */ + 0x41,0x00,0xA4,0x0A,0x0F /* 00000058 "A...." */ +};src/acpi.c +41
-0@@ -15,6 +15,8 @@#include "config.h" // CONFIG_* #include "paravirt.h" // RamSize #include "dev-q35.h" +#include "acpi-tpm-ssdt.hex" +#include "tcgbios.h" // has_working_tpm /****************************************************/ /* ACPI tables init */ @@ -762,6 +764,39 @@ static const struct pci_device_id acpi_find_tbl[] = { PCI_DEVICE_END, }; + +static u32 add_tpm_device (void **tpm_addr,void **tcpa_addr) +{ +struct tcpa_descriptor_rev2 *tcpa; + + *tpm_addr =NULL ; + *tcpa_addr =NULL ; + +if (has_working_tpm ()) { +u32 laml =64 *1024 ; + *tpm_addr =malloc_high (sizeof (AmlCode_TPM)); + + tcpa =malloc_high (sizeof (*tcpa) + laml); +if (!tcpa || !*tpm_addr) { +warn_noalloc (); +return 1 ; + } + +if (*tpm_addr) +memcpy (*tpm_addr, AmlCode_TPM,sizeof (AmlCode_TPM)); + +memset (tcpa,0x0 ,sizeof (*tcpa) + laml); +u64 lasa = (u32 )tcpa +sizeof (*tcpa); + + tcpa->laml = laml; + tcpa->lasa = lasa; +build_header ((void *)tcpa,TCPA_SIGNATURE ,sizeof (*tcpa),2 ); + + *tcpa_addr = tcpa; + } +return 0 ; +} +struct rsdp_descriptor *RsdpAddr;#define MAX_ACPI_TABLES 20@@ -835,6 +870,12 @@ acpi_setup(void)fill_dsdt (fadt, dsdt); } +void *tcpa, *tpm; +if (add_tpm_device (&tpm, &tcpa)) +return ; +ACPI_INIT_TABLE (tpm); +ACPI_INIT_TABLE (tcpa); +// Build final rsdt table struct rsdt_descriptor_rev1 *rsdt;size_t rsdt_len =sizeof (*rsdt) +sizeof (u32) * tbl_idx;src/acpi.h +20
-0@@ -130,4 +130,24 @@ struct acpi_table_mcfg {struct acpi_mcfg_allocation allocation[0 ]; } PACKED; + +struct rsdt_descriptor { +ACPI_TABLE_HEADER_DEF + u32 entry[1]; +}PACKED ; + +#define TCPA_SIGNATURE 0x41504354 +struct tcpa_descriptor_rev2 +{ +ACPI_TABLE_HEADER_DEF + u16 platform_class; +u32 laml; +u64 lasa; +}PACKED ; + +/* TCPA ACPI definitions */ +#define TCPA_ACPI_CLASS_CLIENT 0 +#define TCPA_ACPI_CLASS_SERVER 1 + +#endif // acpi.h src/config.h +1
-1@@ -17,7 +17,7 @@// Maximum number of map entries in the e820 map #define BUILD_MAX_E820 32// Space to reserve in high-memory for tables -#define BUILD_MAX_HIGHTABLE (64*1024) +#define BUILD_MAX_HIGHTABLE (96*1024)// Largest supported externaly facing drive id #define BUILD_MAX_EXTDRIVE 16// Number of bytes the smbios may be and still live in the f-segment src/tcgbios.c new file +70
-0@@ -0,0 +1,70 @@ +// Implementation of the TCG BIOS extension according to the specification +// described in +// https://www.trustedcomputinggroup.org/specs/PCClient/TCG_PCClientImplementationforBIOS_1-20_1-00.pdf +// +// Copyright (C) 2006-2013 IBM Corporation +// +// Authors: +// Stefan Berger <[email protected]> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + + +#include "config.h" + +#include "types.h" +#include "tpm_drivers.h" // tpm_drivers[] + + +typedef struct { +u8 tpm_probed:1 ; +u8 tpm_found:1 ; +u8 tpm_working:1 ; +u8 if_shutdown:1 ; +u8 tpm_driver_to_use:4 ; +}tcpa_state_t ; + + +static tcpa_state_t tcpa_state = { + .tpm_driver_to_use =TPM_INVALID_DRIVER , +}; + + +/******************************************************** +Extensions for TCG-enabled BIOS +*******************************************************/ + + +static u32 +is_tpm_present (void ) +{ +u32 rc =0 ; +unsigned int i; + +for (i =0 ; i <TPM_NUM_DRIVERS ; i++) { +struct tpm_driver *td = &tpm_drivers[i]; +if (td->probe () !=0 ) { + td->init (); + tcpa_state.tpm_driver_to_use = i; + rc =1 ; +break ; + } + } + +return rc; +} + + +int +has_working_tpm (void ) +{ +if (!tcpa_state.tpm_probed) { + tcpa_state.tpm_probed =1 ; + tcpa_state.tpm_found = (is_tpm_present () !=0 ); + tcpa_state.tpm_working =1 ; + } +if (!tcpa_state.tpm_working) +return 0 ; + +return tcpa_state.tpm_found; +}src/tcgbios.h new file +57
-0@@ -0,0 +1,57 @@ +#ifndef TCGBIOS_H +#define TCGBIOS_H + + +#define TPM_OK 0x0 +#define TPM_RET_BASE 0x1 +#define TCG_GENERAL_ERROR (TPM_RET_BASE + 0x0) +#define TCG_TPM_IS_LOCKED (TPM_RET_BASE + 0x1) +#define TCG_NO_RESPONSE (TPM_RET_BASE + 0x2) +#define TCG_INVALID_RESPONSE (TPM_RET_BASE + 0x3) +#define TCG_INVALID_ACCESS_REQUEST (TPM_RET_BASE + 0x4) +#define TCG_FIRMWARE_ERROR (TPM_RET_BASE + 0x5) +#define TCG_INTEGRITY_CHECK_FAILED (TPM_RET_BASE + 0x6) +#define TCG_INVALID_DEVICE_ID (TPM_RET_BASE + 0x7) +#define TCG_INVALID_VENDOR_ID (TPM_RET_BASE + 0x8) +#define TCG_UNABLE_TO_OPEN (TPM_RET_BASE + 0x9) +#define TCG_UNABLE_TO_CLOSE (TPM_RET_BASE + 0xa) +#define TCG_RESPONSE_TIMEOUT (TPM_RET_BASE + 0xb) +#define TCG_INVALID_COM_REQUEST (TPM_RET_BASE + 0xc) +#define TCG_INVALID_ADR_REQUEST (TPM_RET_BASE + 0xd) +#define TCG_WRITE_BYTE_ERROR (TPM_RET_BASE + 0xe) +#define TCG_READ_BYTE_ERROR (TPM_RET_BASE + 0xf) +#define TCG_BLOCK_WRITE_TIMEOUT (TPM_RET_BASE + 0x10) +#define TCG_CHAR_WRITE_TIMEOUT (TPM_RET_BASE + 0x11) +#define TCG_CHAR_READ_TIMEOUT (TPM_RET_BASE + 0x12) +#define TCG_BLOCK_READ_TIMEOUT (TPM_RET_BASE + 0x13) +#define TCG_TRANSFER_ABORT (TPM_RET_BASE + 0x14) +#define TCG_INVALID_DRV_FUNCTION (TPM_RET_BASE + 0x15) +#define TCG_OUTPUT_BUFFER_TOO_SHORT (TPM_RET_BASE + 0x16) +#define TCG_FATAL_COM_ERROR (TPM_RET_BASE + 0x17) +#define TCG_INVALID_INPUT_PARA (TPM_RET_BASE + 0x18) +#define TCG_TCG_COMMAND_ERROR (TPM_RET_BASE + 0x19) +#define TCG_INTERFACE_SHUTDOWN (TPM_RET_BASE + 0x20) +//define TCG_PC_UNSUPPORTED (TPM_RET_BASE + 0x21) +#define TCG_PC_TPM_NOT_PRESENT (TPM_RET_BASE + 0x22) +#define TCG_PC_TPM_DEACTIVATED (TPM_RET_BASE + 0x23) + + +#define TPM_INVALID_ADR_REQUEST TCG_INVALID_ADR_REQUEST +#define TPM_IS_LOCKED TCG_TPM_IS_LOCKED +#define TPM_INVALID_DEVICE_ID TCG_INVALID_DEVICE_ID +#define TPM_INVALID_VENDOR_ID TCG_INVALID_VENDOR_ID +//define TPM_RESERVED_REG_INVALID +#define TPM_FIRMWARE_ERROR TCG_FIRMWARE_ERROR +#define TPM_UNABLE_TO_OPEN TCG_UNABLE_TO_OPEN +#define TPM_UNABLE_TO_CLOSE TCG_UNABLE_TO_CLOSE +#define TPM_INVALID_RESPONSE TCG_INVALID_RESPONSE +#define TPM_RESPONSE_TIMEOUT TCG_RESPONSE_TIMEOUT +#define TPM_INVALID_ACCESS_REQUEST TCG_INVALID_ACCESS_REQUEST +#define TPM_TRANSFER_ABORT TCG_TRANSFER_ABORT +#define TPM_GENERAL_ERROR TCG_GENERAL_ERROR + + +int has_working_tpm (void ); + + +#endif /* TCGBIOS_H */
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Quoted 10 lines · Corey Bryant
Quoted 3 lines · Paolo Bonzini
There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.
Kevin, Do you have a preference whether we add these ACPI tables to SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in SeaBIOS and this adds probably 200 bytes of code and data. Basically it creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So - yes - my preference would be to add these to QEMU once the transition is complete.
-Kevin
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Quoted 12 lines · Kevin O'Connor
Quoted 10 lines · Corey Bryant
Quoted 3 lines · Paolo Bonzini
There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.
Kevin, Do you have a preference whether we add these ACPI tables to SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in SeaBIOS and this adds probably 200 bytes of code and data. Basically it creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
Quoted 6 lines
The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So - yes - my preference would be to add these to QEMU once the transition is complete.
-Kevin
Ok I'll hold off until the transition is complete. Thanks.
Signature · 2 lines
Regards, Corey Bryant
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Quoted 16 lines · Corey Bryant
Quoted 13 lines · Kevin O'Connor
Quoted 11 lines · Corey Bryant
Quoted 4 lines · Paolo Bonzini
There is work on moving ACPI tables to QEMU. Please work with the other
developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.Kevin, Do you have a preference whether we add these ACPI tables to SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in SeaBIOS and this adds probably 200 bytes of code and data. Basically it creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
Quoted 8 lines
Quoted 6 lines
The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So - yes - my preference would be to add these to QEMU once the transition is complete.
-Kevin
Ok I'll hold off until the transition is complete. Thanks.
If that translates to "until Laszlo submits patches that are accepted", then don't wait. I have no idea when I'll manage that and I'd hate to block your work.
Laszlo
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Quoted 24 lines · Laszlo Ersek
Quoted 23 lines · Corey Bryant
Quoted 19 lines · Kevin O'Connor
Quoted 11 lines · Corey Bryant
Quoted 4 lines · Paolo Bonzini
There is work on moving ACPI tables to QEMU. Please work with the other
developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.Kevin, Do you have a preference whether we add these ACPI tables to SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in SeaBIOS and this adds probably 200 bytes of code and data. Basically it creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So - yes - my preference would be to add these to QEMU once the transition is complete.
-Kevin
Quoted 7 lines
Quoted 1 line
Ok I'll hold off until the transition is complete. Thanks.
If that translates to "until Laszlo submits patches that are accepted", then don't wait. I have no idea when I'll manage that and I'd hate to block your work.
Laszlo
I'm working on that too btw :) Hard to promise a schedule but it's high on my agenda.
Signature · 1 line
MST
Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
Quoted 27 lines · Michael S. Tsirkin
Quoted 26 lines · Laszlo Ersek
Quoted 24 lines · Corey Bryant
Quoted 13 lines · Kevin O'Connor
Quoted 11 lines · Corey Bryant
Quoted 4 lines · Paolo Bonzini
There is work on moving ACPI tables to QEMU. Please work with the other
developers (Kevin of course, and Michael and Laszlo who I have CCed) on this.Kevin, Do you have a preference whether we add these ACPI tables to SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in SeaBIOS and this adds probably 200 bytes of code and data. Basically it creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
Quoted 6 lines
The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So - yes - my preference would be to add these to QEMU once the transition is complete.
-Kevin
Ok I'll hold off until the transition is complete. Thanks.
Quoted 9 lines
Quoted 5 lines
If that translates to "until Laszlo submits patches that are accepted", then don't wait. I have no idea when I'll manage that and I'd hate to block your work.
Laszlo
I'm working on that too btw :) Hard to promise a schedule but it's high on my agenda.
Great, thanks. I'll watch for patches. I'd prefer to follow your lead on this.
Signature · 2 lines
Regards, Corey Bryant