RX-51: Fix probe order of SPI devices

PATCH In review Pali Rohár 2 participants 6 messages Mar 31, 2013 – Apr 24, 2013 1 message not in the archive

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

Pali Rohár

author

2013-03-31 10:09 UTC #0 lore raw

PATCH 1/1 RX-51: Fix probe order of SPI devices

From: Joni Lapilainen <[email protected]>

Without this patch LCD panel on Nokia RX-51 is still black

Signed-off-by Joni Lapilainen <[email protected]>

Signed-off-by Pali Rohár <[email protected]>

---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/mach-omap2/board-rx51-peripherals.c +1 -1

index b09b5da..03290b9 100644
@@ -91,8 +91,8 @@
 /* list all spi devices here */
 enum {
 	RX51_SPI_WL1251,
-	RX51_SPI_MIPID,		/* LCD panel */
 	RX51_SPI_TSC2005,	/* Touch Controller */
+	RX51_SPI_MIPID,		/* LCD panel */
 };
 
 static struct wl12xx_platform_data wl1251_pdata;

Signature · 1 line

1.7.10.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

Pali Rohár

author

2013-03-31 11:18 UTC #2 lore raw

Quoted 10 lines · On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:

Quoted 6 lines · Pali Rohár
From: Joni Lapilainen <[email protected]>
Without this patch LCD panel on Nokia RX-51 is still black
Signed-off-by Joni Lapilainen <[email protected]>
Signed-off-by Pali Rohár <[email protected]>
Tested-by Sebastian Reichel <[email protected]>

Quoted 7 lines

Please note, that this patch has actually been proposed by Aaro Koskinen <[email protected]> quite some time ago [0].
[0]
http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729
-- Sebastian

CCing Aaro.

Signature · 2 lines

Pali Rohár
[email protected]

Tony Lindgren

maintainer

2013-04-02 16:31 UTC #3 lore raw

Quoted 14 lines · Pali Rohár

Quoted 13 lines · On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
Quoted 6 lines · Pali Rohár
From: Joni Lapilainen <[email protected]>
Without this patch LCD panel on Nokia RX-51 is still black
Signed-off-by Joni Lapilainen <[email protected]>
Signed-off-by Pali Rohár <[email protected]>
Tested-by Sebastian Reichel <[email protected]>
Please note, that this patch has actually been proposed by Aaro Koskinen <[email protected]> quite some time ago [0].

Quoted 6 lines

Quoted 4 lines
[0]
http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729
-- Sebastian
CCing Aaro.

Any ideas why this is happening?

Is the touch screen controller somehow pulling one of the SPI lines before it's reset? I don't think there's any other connection between the LCD and touch controller besides the SPI lines?

In any case there should be something in the description why this is needed..

Regards,

Tony

Pali Rohár

author

2013-04-10 14:15 UTC #4 lore raw

Quoted 33 lines · On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote:

Quoted 17 lines · Pali Rohár
Quoted 16 lines · On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
Quoted 8 lines · Pali Rohár
From: Joni Lapilainen <[email protected]>
Without this patch LCD panel on Nokia RX-51 is still black
Signed-off-by: Joni Lapilainen <[email protected]> Signed-off-by: Pali Rohár <[email protected]>
Tested-by Sebastian Reichel <[email protected]>
Please note, that this patch has actually been proposed by Aaro Koskinen <[email protected]> quite some time ago [0].
Quoted 7 lines
Quoted 5 lines
[0]
http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172
9
-- Sebastian
CCing Aaro.
Any ideas why this is happening?
Is the touch screen controller somehow pulling one of the SPI lines before it's reset? I don't think there's any other connection between the LCD and touch controller besides the SPI lines?

Quoted 6 lines

In any case there should be something in the description why this is needed..
Regards,
Tony

Hi Tony, look at this Aaro's email:
http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729

Signature · 2 lines

Pali Rohár
[email protected]

Tony Lindgren

maintainer

2013-04-10 17:00 UTC #5 lore raw

Quoted 37 lines · Pali Rohár

Quoted 36 lines · On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote:
Quoted 17 lines · Pali Rohár
Quoted 16 lines · On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
Quoted 8 lines · Pali Rohár
From: Joni Lapilainen <[email protected]>
Without this patch LCD panel on Nokia RX-51 is still black
Signed-off-by: Joni Lapilainen <[email protected]> Signed-off-by: Pali Rohár <[email protected]>
Tested-by Sebastian Reichel <[email protected]>
Please note, that this patch has actually been proposed by Aaro Koskinen <[email protected]> quite some time ago [0].
Quoted 7 lines
Quoted 5 lines
[0]
http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172
9
-- Sebastian
CCing Aaro.
Any ideas why this is happening?
Is the touch screen controller somehow pulling one of the SPI lines before it's reset? I don't think there's any other connection between the LCD and touch controller besides the SPI lines?
In any case there should be something in the description why this is needed..

Quoted 6 lines

Quoted 3 lines
Regards,
Tony
Hi Tony, look at this Aaro's email:
http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729

OK can we have that summarized in the patch description please?

Regards,

Tony

Pali Rohár

author

2013-04-24 12:23 UTC #6 lore raw

Quoted 5 lines · On Wednesday 10 April 2013 19:00:05 Tony Lindgren wrote:

Quoted 4 lines · Pali Rohár
Quoted 3 lines · On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote:
Quoted 2 lines · Pali Rohár
Quoted 1 line · On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár

Quoted 40 lines · wrote:

Quoted 33 lines
Quoted 33 lines
Quoted 15 lines
Quoted 15 lines
Quoted 8 lines
From: Joni Lapilainen <[email protected]>
Without this patch LCD panel on Nokia RX-51 is still black
Signed-off-by: Joni Lapilainen
<[email protected]> Signed-off-by: Pali
Rohár <[email protected]>
Tested-by Sebastian Reichel <[email protected]>
Please note, that this patch has actually been
proposed by Aaro Koskinen <[email protected]>
quite some time ago [0].
Quoted 7 lines
Quoted 5 lines
[0]
http://permalink.gmane.org/gmane.linux.ports.arm.omap/
8172 9
-- Sebastian
CCing Aaro.
Any ideas why this is happening?
Is the touch screen controller somehow pulling one of the SPI lines before it's reset? I don't think there's any other connection between the LCD and touch controller besides the SPI lines?
In any case there should be something in the description why this is needed..
Quoted 6 lines
Quoted 3 lines
Regards,
Tony
Hi Tony, look at this Aaro's email:
http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729

Quoted 6 lines

OK can we have that summarized in the patch description please?
Regards,
Tony

Aaro, this patch is yours, can you resend it with description?

Signature · 2 lines

Pali Rohár
[email protected]