Skip to contentSkip to conversation

Fix link: move -lrt at the end of the link line

PATCH Mathieu Desnoyers 2 participants 3 messages Apr 10, 2013 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 2 lines · * Simon Marchi ([email protected]) wrote:

It has to be after libconsumer.la.

why, what issue does it fix ?

Quoted 31 lines
---
 src/bin/lttng-consumerd/Makefile.am |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
src/bin/lttng-consumerd/Makefile.am +3 -2
index a418eb4..d340c68 100644
@@ -4,10 +4,11 @@ lttnglibexec_PROGRAMS = lttng-consumerd
 
 lttng_consumerd_SOURCES = lttng-consumerd.c lttng-consumerd.h
 
-lttng_consumerd_LDADD = -lrt \
+lttng_consumerd_LDADD = \
 	   $(top_builddir)/src/common/libconsumer.la \
 	   $(top_builddir)/src/common/sessiond-comm/libsessiond-comm.la \
-	   $(top_builddir)/src/common/libcommon.la
+	   $(top_builddir)/src/common/libcommon.la \
+	   -lrt
 
 if HAVE_LIBLTTNG_UST_CTL
 lttng_consumerd_LDADD += -llttng-ust-ctl
Signature · 7 lines
1.7.10.4


_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

A message that is not in the archive (sent off-list or not yet received): 20130410142223.GA5448@Krystal

#3 lore raw

The problem was mentionned on the mailing list a few days ago [1].

"Recent" Ubuntus pass --as-needed to the linker [2], which makes it sensitive to the ordering of libraries on the command line. Libraries that resolve undefined symbols of other libs or objects must be specified after those other libs or objects (much like the behavior of old linkers, if I understand correctly). timer_settime is used in one of the LTTng libs and is defined in librt, so librt must be put after it. Me trying to compile lttng-tools on Ubuntu without the patch [3].

[1] http://lists.lttng.org/pipermail/lttng-dev/2013-March/019929.html
[2] https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition
[3] http://pastebin.com/G2pSkseF

Quoted 42 lines · Mathieu Desnoyers
Quoted 2 lines · * Simon Marchi ([email protected]) wrote:

It has to be after libconsumer.la.

why, what issue does it fix ?

Quoted 27 lines
---
 src/bin/lttng-consumerd/Makefile.am |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
src/bin/lttng-consumerd/Makefile.am +3 -3
index a418eb4..d340c68 100644
@@ -4,10 +4,11 @@ lttnglibexec_PROGRAMS = lttng-consumerd
 
 lttng_consumerd_SOURCES = lttng-consumerd.c lttng-consumerd.h
 
-lttng_consumerd_LDADD = -lrt \
+lttng_consumerd_LDADD = \
         $(top_builddir)/src/common/libconsumer.la \
         $(top_builddir)/src/common/sessiond-comm/libsessiond-comm.la \
-        $(top_builddir)/src/common/libcommon.la
+        $(top_builddir)/src/common/libcommon.la \
+        -lrt
 
 if HAVE_LIBLTTNG_UST_CTL
 lttng_consumerd_LDADD += -llttng-ust-ctl
--

1.7.10.4

Quoted 4 lines

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

A message that is not in the archive (sent off-list or not yet received): CAFXXi0=sstDTxVts6kuHjyzVC5FSP490zHC7vY=GvPQQsr0HPw@mail.gmail.com

#5 lore raw
Quoted 10 lines · * Simon Marchi ([email protected]) wrote:

The problem was mentionned on the mailing list a few days ago [1].

"Recent" Ubuntus pass --as-needed to the linker [2], which makes it sensitive to the ordering of libraries on the command line. Libraries that resolve undefined symbols of other libs or objects must be specified after those other libs or objects (much like the behavior of old linkers, if I understand correctly). timer_settime is used in one of the LTTng libs and is defined in librt, so librt must be put after it. Me trying to compile lttng-tools on Ubuntu without the patch [3].

Quoted 3 lines

[1] http://lists.lttng.org/pipermail/lttng-dev/2013-March/019929.html
[2] https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition
[3] http://pastebin.com/G2pSkseF

OK, this should be added to the patch changelog.

Thanks,

Mathieu

Quoted 45 lines
Quoted 42 lines · Mathieu Desnoyers
Quoted 2 lines · * Simon Marchi ([email protected]) wrote:

It has to be after libconsumer.la.

why, what issue does it fix ?

Quoted 27 lines
---
 src/bin/lttng-consumerd/Makefile.am |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
src/bin/lttng-consumerd/Makefile.am +3 -3
index a418eb4..d340c68 100644
@@ -4,10 +4,11 @@ lttnglibexec_PROGRAMS = lttng-consumerd
 
 lttng_consumerd_SOURCES = lttng-consumerd.c lttng-consumerd.h
 
-lttng_consumerd_LDADD = -lrt \
+lttng_consumerd_LDADD = \
         $(top_builddir)/src/common/libconsumer.la \
         $(top_builddir)/src/common/sessiond-comm/libsessiond-comm.la \
-        $(top_builddir)/src/common/libcommon.la
+        $(top_builddir)/src/common/libcommon.la \
+        -lrt
 
 if HAVE_LIBLTTNG_UST_CTL
 lttng_consumerd_LDADD += -llttng-ust-ctl
--

1.7.10.4

Quoted 4 lines

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com