pwm: pxa: Remove PWM_ID_BASE macro
PATCH 1/1 pwm: pxa: Remove PWM_ID_BASE macro
PWM_ID_BASE() is not used after convert to PWM framework, remove it. Also update driver_data field of struct platform_device_id accordingly.
---
This is v2 of [PATCH] pwm: pxa: Use driver_data field to store pwm_nr. I change the subject line to meet the change in v2.
drivers/pwm/pwm-pxa.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/pwm/pwm-pxa.c +3 -4
@@ -23,14 +23,13 @@#include <asm/div64.h> #define HAS_SECONDARY_PWM 0x10 -#define PWM_ID_BASE (d) ((d) & 0xf)static const struct platform_device_id pwm_id_table[] = {/* PWM has_secondary_pwm? */ {"pxa25x-pwm" ,0 }, - {"pxa27x-pwm" ,0 |HAS_SECONDARY_PWM }, - {"pxa168-pwm" ,1 }, - {"pxa910-pwm" ,1 }, + {"pxa27x-pwm" ,HAS_SECONDARY_PWM }, + {"pxa168-pwm" ,0 }, + {"pxa910-pwm" ,0 }, { }, };MODULE_DEVICE_TABLE (platform, pwm_id_table);
Signature · 1 line
1.7.10.4
Quoted 23 lines · Axel Lin
PWM_ID_BASE()is not used after convert to PWM framework, remove it. Also updatedriver_datafield of structplatform_device_idaccordingly.Signed-off-by Axel Lin <[email protected]>---
This is v2 of [PATCH] pwm: pxa: Usedriver_datafield to storepwm_nr. I change the subject line to meet the change in v2.drivers/pwm/pwm-pxa.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/pwm/pwm-pxa.c +0
-1@@ -23,14 +23,13 @@#include <asm/div64.h> #define HAS_SECONDARY_PWM 0x10 -#define PWM_ID_BASE (d) ((d) & 0xf)static const struct platform_device_id pwm_id_table[] = {/* PWM has_secondary_pwm? */
drivers/pwm/pwm-pxa.c line 35
Quoted 10 lines
drivers/pwm/pwm-pxa.c +3
-3{ "pxa25x-pwm", 0 }, - { "pxa27x-pwm", 0 | HAS_SECONDARY_PWM }, - { "pxa168-pwm", 1 }, - { "pxa910-pwm", 1 }, + { "pxa27x-pwm", HAS_SECONDARY_PWM }, + { "pxa168-pwm", 0 }, + { "pxa910-pwm", 0 }, { }, };MODULE_DEVICE_TABLE (platform, pwm_id_table);
Looks good to me, Acked-by: Eric Miao <[email protected]>
Thierry Reding
AppliedQuoted 7 lines · Axel Lin
PWM_ID_BASE()is not used after convert to PWM framework, remove it. Also updatedriver_datafield of structplatform_device_idaccordingly.Signed-off-by Axel Lin <[email protected]>---
This is v2 of [PATCH] pwm: pxa: Usedriver_datafield to storepwm_nr. I change the subject line to meet the change in v2.
Applied, thanks.
Thierry