Skip to contentSkip to conversation

regulator: ab8500: Fix list_voltage for fixed voltage regulators

PATCH New Axel Lin 1 participant 2 messages Apr 2, 2013 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 regulator: ab8500: Fix list_voltage for fixed voltage regulators

commit b080c78a4e447e9c212c207f725999d4e32c5f19
"regulator: ab8500: Update voltage handling for fixed voltage regulators" remove min_uV settings and set volt_table for all fixed voltage, thus we can not use regulator_list_voltage_linear now. Use regulator_list_voltage_table instead.

---
 drivers/regulator/ab8500.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/ab8500.c +2 -2
index 09eea32..5fd764e 100644
@@ -423,14 +423,14 @@ static struct regulator_ops ab8500_regulator_mode_ops = {
 	.get_optimum_mode	= ab8500_regulator_get_optimum_mode,
 	.set_mode		= ab8500_regulator_set_mode,
 	.get_mode		= ab8500_regulator_get_mode,
-	.list_voltage		= regulator_list_voltage_linear,
+	.list_voltage		= regulator_list_voltage_table,
 };
 
 static struct regulator_ops ab8500_regulator_ops = {
 	.enable			= ab8500_regulator_enable,
 	.disable		= ab8500_regulator_disable,
 	.is_enabled		= ab8500_regulator_is_enabled,
-	.list_voltage		= regulator_list_voltage_linear,
+	.list_voltage		= regulator_list_voltage_table,
 };
 
 /* AB8500 regulator information */
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/2 regulator: ab8500: Add missing volt_table setting for AB8540_LDO_TVOUT

This is required for regulator_list_voltage_table() to properly work.

---
Hi,
The setting is copied from AB8500_LDO_TVOUT, I don't have the datasheet. Can someone test and review if this patch is correct or not?

Axel

 drivers/regulator/ab8500.c |    1 +
 1 file changed, 1 insertion(+)
drivers/regulator/ab8500.c +1 -0
index 5fd764e..44602c5 100644
@@ -1303,6 +1303,7 @@ static struct ab8500_regulator_info
 			.id		= AB8500_LDO_TVOUT,
 			.owner		= THIS_MODULE,
 			.n_voltages	= 1,
+			.volt_table	= fixed_2000000_voltage,
 		},
 		.load_lp_uA		= 1000,
 		.update_bank		= 0x03,
Signature · 1 line
1.7.10.4