Skip to contentSkip to conversation

build: add NFC defconfig file

PATCH In review Thierry Escande 3 participants 8 messages Apr 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 8/8 build: add NFC defconfig file

---
 backport/defconfigs/nfc |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 backport/defconfigs/nfc
backport/defconfigs/nfc new file +11 -0
new file mode 100644
index 0000000..999127f
@@ -0,0 +1,11 @@
+CPTCFG_NFC=m
+CPTCFG_NFC_NCI=m
+CPTCFG_NFC_HCI=m
+CPTCFG_NFC_SHDLC=y
+CPTCFG_NFC_LLCP=y
+CPTCFG_NFC_PN533=m
+CPTCFG_NFC_WILINK=m
+CPTCFG_NFC_PN544=m
+CPTCFG_NFC_PN544_I2C=m
+CPTCFG_NFC_MICROREAD=m
+CPTCFG_NFC_MICROREAD_I2C=m
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 13 lines · Thierry Escande
---
 backport/defconfigs/nfc |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 backport/defconfigs/nfc
backport/defconfigs/nfc new file +1 -0
new file mode 100644
index 0000000..999127f
@@ -0,0 +1,11 @@
+CPTCFG_NFC=m

backport/defconfigs/nfc line 11

Quoted 10 lines
backport/defconfigs/nfc new file +10 -0
+CPTCFG_NFC_NCI=m
+CPTCFG_NFC_HCI=m
+CPTCFG_NFC_SHDLC=y
+CPTCFG_NFC_LLCP=y
+CPTCFG_NFC_PN533=m
+CPTCFG_NFC_WILINK=m
+CPTCFG_NFC_PN544=m
+CPTCFG_NFC_PN544_I2C=m
+CPTCFG_NFC_MICROREAD=m
+CPTCFG_NFC_MICROREAD_I2C=m

Johannes, do we want to be disabling the other subsystems in these ?

Luis

#2 lore raw
Quoted 19 lines · Luis R. Rodriguez
Quoted 17 lines · Thierry Escande
---
 backport/defconfigs/nfc |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 backport/defconfigs/nfc
backport/defconfigs/nfc new file +5 -0
new file mode 100644
index 0000000..999127f
@@ -0,0 +1,11 @@
+CPTCFG_NFC=m
+CPTCFG_NFC_NCI=m
+CPTCFG_NFC_HCI=m
+CPTCFG_NFC_SHDLC=y
+CPTCFG_NFC_LLCP=y
Quoted 8 lines

backport/defconfigs/nfc line 11

Quoted 6 lines
backport/defconfigs/nfc new file +6 -0
+CPTCFG_NFC_PN533=m
+CPTCFG_NFC_WILINK=m
+CPTCFG_NFC_PN544=m
+CPTCFG_NFC_PN544_I2C=m
+CPTCFG_NFC_MICROREAD=m
+CPTCFG_NFC_MICROREAD_I2C=m

Johannes, do we want to be disabling the other subsystems in these ?

Well anything not listed will have the default values, so that should be OK, right? Most things should be default off.

And yeah I think for an NFC defconfig everything else is probably desired off, no?

johannes

#3 lore raw
Quoted 29 lines · Johannes Berg
Quoted 19 lines · Luis R. Rodriguez
Quoted 17 lines · Thierry Escande
---
 backport/defconfigs/nfc |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 backport/defconfigs/nfc
backport/defconfigs/nfc new file +5 -0
new file mode 100644
index 0000000..999127f
@@ -0,0 +1,11 @@
+CPTCFG_NFC=m
+CPTCFG_NFC_NCI=m
+CPTCFG_NFC_HCI=m
+CPTCFG_NFC_SHDLC=y
+CPTCFG_NFC_LLCP=y
Quoted 8 lines

backport/defconfigs/nfc line 11

Quoted 6 lines
backport/defconfigs/nfc new file +6 -0
+CPTCFG_NFC_PN533=m
+CPTCFG_NFC_WILINK=m
+CPTCFG_NFC_PN544=m
+CPTCFG_NFC_PN544_I2C=m
+CPTCFG_NFC_MICROREAD=m
+CPTCFG_NFC_MICROREAD_I2C=m

Johannes, do we want to be disabling the other subsystems in these ?

Quoted 2 lines

Well anything not listed will have the default values, so that should be OK, right? Most things should be default off.

OK so the default would be -- "if you have it on your kernel then we'll enable at build time", is that right? I wasn't clear on this, that's all.

Luis

#4 lore raw
Quoted 1 line · Luis R. Rodriguez
Quoted 1 line
Quoted 1 line
Quoted 1 line

+CPTCFG_NFC=m

[...]

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Johannes, do we want to be disabling the other subsystems in these ?

Well anything not listed will have the default values, so that should be OK, right? Most things should be default off.

OK so the default would be -- "if you have it on your kernel then we'll enable at build time", is that right? I wasn't clear on this, that's all.

No, because of the prefix rename (CONFIG_ -> CPTCFG_) the kernel's configuration has no influence on our configuration at all.

So the default is just whatever the default is in the Kconfig files, which is essentially everything else turned off.

johannes

#5 lore raw
Quoted 13 lines · Johannes Berg
Quoted 1 line · Luis R. Rodriguez
Quoted 1 line
Quoted 1 line
Quoted 1 line

+CPTCFG_NFC=m

[...]

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Johannes, do we want to be disabling the other subsystems in these ?

Well anything not listed will have the default values, so that should be OK, right? Most things should be default off.

OK so the default would be -- "if you have it on your kernel then we'll enable at build time", is that right? I wasn't clear on this, that's all.

Quoted 5 lines

No, because of the prefix rename (CONFIG_ -> CPTCFG_) the kernel's configuration has no influence on our configuration at all.

So the default is just whatever the default is in the Kconfig files, which is essentially everything else turned off.

Odd, when I tried to do media with similar defconfig I got wireless building :( but its great this was the goal, I'll try again.

Luis

#6 lore raw
Quoted 5 lines · Luis R. Rodriguez
Quoted 2 lines

So the default is just whatever the default is in the Kconfig files, which is essentially everything else turned off.

Odd, when I tried to do media with similar defconfig I got wireless building :( but its great this was the goal, I'll try again.

Did you create a new tree or rm .config first?

johannes

#7 lore raw
Quoted 9 lines · Johannes Berg
Quoted 5 lines · Luis R. Rodriguez
Quoted 2 lines

So the default is just whatever the default is in the Kconfig files, which is essentially everything else turned off.

Odd, when I tried to do media with similar defconfig I got wireless building :( but its great this was the goal, I'll try again.

Did you create a new tree or rm .config first?

I've corrected my habbits now, git clean -f -x -d and always new tree generated.

Luis