Skip to contentSkip to conversation

cifs: Trivial comment fixes

PATCH In review [email protected] 2 participants 2 messages Apr 10, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: Trivial comment fixes

From: Scott Lovenberg <[email protected]>

Two trivial comment fixes.

---
 mount.cifs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
mount.cifs.c +2 -2
index 4548fc6..58b127a 100644
@@ -975,7 +975,7 @@ parse_options(const char *data, struct parsed_mount_info *parsed_info)
 
 			fprintf(stderr, "bad option: gid=\"%s\"\n", value);
 			return EX_USAGE;
-		/* fmask fall through to file_mode */
+		/* fmask falls through to file_mode */
 		case OPT_FMASK:
 			fprintf(stderr,
 				"WARNING: CIFS mount option 'fmask' is\
@@ -1145,7 +1145,7 @@ nocopy:
 	if (got_cruid) {
 		word_len = snprintf(txtbuf, sizeof(txtbuf), "%u", cruid);
 
-		/* comma + "cruid=" + terminating NULL == 6 */
+		/* comma + "cruid=" + terminating NULL == 8 */
 		if (out_len + word_len + 8 > MAX_OPTIONS_LEN) {
 			fprintf(stderr, "Options string too long\n");
 			return EX_USAGE;
Signature · 1 line
1.7.5.4

A message that is not in the archive (sent off-list or not yet received): 1365614212-13433-1-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 23 lines · On Wed, 10 Apr 2013 13:16:52 -0400 scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@publi…

From: Scott Lovenberg <[email protected]>

Two trivial comment fixes.

---
 mount.cifs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
mount.cifs.c +1 -1
index 4548fc6..58b127a 100644
@@ -975,7 +975,7 @@ parse_options(const char *data, struct parsed_mount_info *parsed_info)
 
 			fprintf(stderr, "bad option: gid=\"%s\"\n", value);
 			return EX_USAGE;
-		/* fmask fall through to file_mode */
+		/* fmask falls through to file_mode */
 		case OPT_FMASK:
 			fprintf(stderr,
 				"WARNING: CIFS mount option 'fmask' is\

mount.cifs.c nocopy: · line 1151

Quoted 8 lines
mount.cifs.c +1 -1
@@ -1145,7 +1145,7 @@ nocopy:
 	if (got_cruid) {
 		word_len = snprintf(txtbuf, sizeof(txtbuf), "%u", cruid);
 
-		/* comma + "cruid=" + terminating NULL == 6 */
+		/* comma + "cruid=" + terminating NULL == 8 */
 		if (out_len + word_len + 8 > MAX_OPTIONS_LEN) {
 			fprintf(stderr, "Options string too long\n");
 			return EX_USAGE;

Looks good. Will merge in a day or two assuming no one objects.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>