drivers: usb: chipidea: convert to devm_ioremap_resource()
Subsystems (2)
PATCH 1/1 drivers: usb: chipidea: convert to devm_ioremap_resource()
Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths.
--- drivers/usb/chipidea/core.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/usb/chipidea/core.c +3 -5
@@ -410,11 +410,9 @@ static int ci_hdrc_probe(struct platform_device *pdev)return -ENODEV ; } - base =devm_request_and_ioremap (dev, res); -if (!base) { -dev_err (dev,"can't request and ioremap resource\n" ); -return -ENOMEM ; - } + base =devm_ioremap_resource (dev, res); +if (IS_ERR (base)) +return PTR_ERR (base); ci =devm_kzalloc (dev,sizeof (*ci),GFP_KERNEL );if (!ci) {
Signature · 1 line
1.7.9.5
Quoted 2 lines · Silviu-Mihai Popescu
Convert use of
devm_request_and_ioremap()to the newly introduceddevm_ioremap_resource()which provides more consistent error handling.
You mean, you've run coccinelle? Remember to mention it, then.
Quoted 4 lines
devm_ioremap_resource()provides its own error messages so all explicit error messages can be removed from the failure code paths.Signed-off-by Silviu-Mihai Popescu <[email protected]>
That's cool, but your chipidea patches have to be based off of ci-for-greg branch of the chipidea tree [1] or at least usb-next branch of Greg's usb.git [2].
[1] git://github.com/virtuoso/linux-ci.git
[2] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
Regards,
--
Alex
Quoted 6 lines · Alexander Shishkin
That's cool, but your chipidea patches have to be based off of ci-for-greg branch of the chipidea tree [1] or at least usb-next branch of Greg's usb.git [2].
[1]
git://github.com/virtuoso/linux-ci.git
[2]git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
Thanks for the tip. I see that both trees use devm_ioremap_resource(). I'll remember to check them next time I have a patch.
--
Silviu