Skip to contentSkip to conversation

udl: handle EDID failure properly.

PATCH In review Dave Airlie 2 participants 2 messages Apr 12, 2013

Subsystems (3)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 udl: handle EDID failure properly.

Don't oops seems proper.

---
 drivers/gpu/drm/udl/udl_connector.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/udl/udl_connector.c +4 -0
index fe5cdbc..b44d548 100644
@@ -61,6 +61,10 @@ static int udl_get_modes(struct drm_connector *connector)
 	int ret;
 
 	edid = (struct edid *)udl_get_edid(udl);
+	if (!edid) {
+		drm_mode_connector_update_edid_property(connector, NULL);
+		return 0;
+	}
 
 	/*
 	 * We only read the main block, but if the monitor reports extension
Signature · 1 line
1.8.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dave Airlie

Don't oops seems proper.

Quoted 26 lines
---
 drivers/gpu/drm/udl/udl_connector.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/udl/udl_connector.c +4 -1
index fe5cdbc..b44d548 100644
@@ -61,6 +61,10 @@ static int udl_get_modes(struct drm_connector *connector)
        int ret;
 
        edid = (struct edid *)udl_get_edid(udl);
+       if (!edid) {
+               drm_mode_connector_update_edid_property(connector, NULL);
+               return 0;
+       }
 
        /*
         * We only read the main block, but if the monitor reports extension
--

1.8.2

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel