clockevents: Switch into oneshot mode even if broadcast registered late
Subsystems (2)
PATCH 1/1 clockevents: Switch into oneshot mode even if broadcast registered late
tick_oneshot_notify() is used to notify a particular CPU to try to switch into oneshot mode after a oneshot capable tick device is registered and tick_clock_notify() is used to notify all CPUs to try to switch into oneshot mode after a high res clocksource is registered. There is one caveat; if the tick devices suffer from FEAT_C3_STOP we don't try to switch into oneshot mode unless we have a oneshot capable broadcast device already registered.
If the broadcast device is registered after the tick devices that have FEAT_C3_STOP we'll never try to switch into oneshot mode again, causing us to be stuck in periodic mode forever. Avoid this scenario by calling tick_clock_notify() after we register the broadcast device so that we try to switch into oneshot mode on all CPUs one more time.
---
Found this one when we were registering our broadcast timer after irqs were enabled. We've moved the registration before the irqs are enabled now so technically we don't need this patch anymore, but it seemed like a good idea to fix it in the core anyway to save someone else the trouble of tracking it down later.
kernel/time/tick-broadcast.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/time/tick-broadcast.c +2 -0
@@ -77,6 +77,8 @@ int tick_check_broadcast_device(struct clock_event_device *dev) tick_broadcast_device.evtdev = dev;if (!cpumask_empty (tick_get_broadcast_mask ()))tick_broadcast_start_periodic (dev); +if (dev->features &CLOCK_EVT_FEAT_ONESHOT ) +tick_clock_notify ();return 1 ; }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
tip-bot for Stephen Boyd
merge botclockevents: Switch into oneshot mode even if broadcast registered late
Commit-ID: c038c1c44179c80da6201f91ef354e48d5689617 Gitweb: http://git.kernel.org/tip/c038c1c44179c80da6201f91ef354e48d5689617 Author: Stephen Boyd <[email protected]> AuthorDate: Wed, 17 Apr 2013 10:26:06 -0700 Committer: Thomas Gleixner <[email protected]> CommitDate: Wed, 17 Apr 2013 21:30:56 +0200
clockevents: Switch into oneshot mode even if broadcast registered late
tick_oneshot_notify() is used to notify a particular CPU to try to switch into oneshot mode after a oneshot capable tick device is registered and tick_clock_notify() is used to notify all CPUs to try to switch into oneshot mode after a high res clocksource is registered. There is one caveat; if the tick devices suffer from FEAT_C3_STOP we don't try to switch into oneshot mode unless we have a oneshot capable broadcast device already registered.
If the broadcast device is registered after the tick devices that have FEAT_C3_STOP we'll never try to switch into oneshot mode again, causing us to be stuck in periodic mode forever. Avoid this scenario by calling tick_clock_notify() after we register the broadcast device so that we try to switch into oneshot mode on all CPUs one more time.
[ tglx: Adopted to timers/core and added a comment ]
--- kernel/time/tick-broadcast.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
kernel/time/tick-broadcast.c +10 -0
@@ -75,6 +75,16 @@ int tick_check_broadcast_device(struct clock_event_device *dev) tick_broadcast_device.evtdev = dev;if (!cpumask_empty (tick_broadcast_mask))tick_broadcast_start_periodic (dev); +/* +* Inform all cpus about this. We might be in a situation +* where we did not switch to oneshot mode because the per cpu +* devices are affected by CLOCK_EVT_FEAT_C3STOP and the lack +* of a oneshot capable broadcast device. Without that +* notification the systems stays stuck in periodic mode +* forever. +*/ +if (dev->features &CLOCK_EVT_FEAT_ONESHOT ) +tick_clock_notify ();return 1 ; }