Skip to contentSkip to conversation

regulator: palmas: Fix min_uV for LDO8 tracking mode

PATCH Applied Axel Lin 3 participants 3 messages Apr 18, 2013

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: palmas: Fix min_uV for LDO8 tracking mode

When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.

---
Hi Laxman,
My understanding is based on your comment in the code.
/*
* When SMPS45 is set to off and LDO8 tracking is enabled, the LDO8
* output is defined by the LDO8_VOLTAGE.VSEL register divided by two,
* and can be set from 0.45 to 1.65 V.
*/

Can you confirm if this patch is correct or not?
Axel

 drivers/regulator/palmas-regulator.c |    1 +
 1 file changed, 1 insertion(+)
drivers/regulator/palmas-regulator.c +1 -0
index d6efaf1..452d987 100644
@@ -886,6 +886,7 @@ static int palmas_regulators_probe(struct platform_device *pdev)
 			if (pdata && (id == PALMAS_REG_LDO8) &&
 					pdata->enable_ldo8_tracking) {
 				palmas_enable_ldo8_track(palmas);
+				pmic->desc[id].min_uV = 450000;
 				pmic->desc[id].uV_step = 25000;
 			}
 		} else {
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Axel Lin

When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.

---
Hi Laxman,
My understanding is based on your comment in the code.
/*
* When SMPS45 is set to off and LDO8 tracking is enabled, the LDO8
* output is defined by the LDO8_VOLTAGE.VSEL register divided by two,
* and can be set from 0.45 to 1.65 V.
*/

Quoted 1 line

Can you confirm if this patch is correct or not?

Yes, this is correct.

Unfortunately the PMIC device which we have is having bug for which we are disabling tracking before going to suspend and enabling again in resume and hence it is not caught. I will pull this change to my downstream also.

maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.

Applied, thanks.