Skip to contentSkip to conversation

f2fs: add REQ_META about metadata requests for submit bio

PATCH In review Namjae Jeon 2 participants 5 messages Apr 19, 2013 – Apr 24, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 f2fs: add REQ_META about metadata requests for submit bio

From: Namjae Jeon <[email protected]>

Adding REQ_META for all the metadata requests can help in improving the FS performance, if the underlying device supports TAGGING.
So, when considering the submit_bio path for all the f2fs requests. We can add REQ_META for all the META requests.
As a precursor to this change we considered the commit 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'

---
 fs/f2fs/segment.c |    3 +++
 1 file changed, 3 insertions(+)
fs/f2fs/segment.c +3 -0
index 1193a26..a2e5de7 100644
@@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
 	if (type >= META_FLUSH)
 		rw = WRITE_FLUSH_FUA;
 
+	if (type == META)
+		rw |= REQ_META;
+
 	if (sbi->bio[btype]) {
 		struct bio_private *p = sbi->bio[btype]->bi_private;
 		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,
Signature · 1 line
1.7.9.5
#1 lore raw

2013-04-20 (토), 01:27 +0900, Namjae Jeon:

Quoted 20 lines

From: Namjae Jeon <[email protected]>

Adding REQ_META for all the metadata requests can help in improving the FS performance, if the underlying device supports TAGGING.
So, when considering the submit_bio path for all the f2fs requests. We can add REQ_META for all the META requests.
As a precursor to this change we considered the commit 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'

---
 fs/f2fs/segment.c |    3 +++
 1 file changed, 3 insertions(+)
fs/f2fs/segment.c +0 -0
index 1193a26..a2e5de7 100644

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 692

Quoted 4 lines
fs/f2fs/segment.c +1 -0
@@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
 	if (type >= META_FLUSH)
 		rw = WRITE_FLUSH_FUA;
 
+	if (type == META)

Should be if (btype == META).
Thanks,

Quoted 5 lines
fs/f2fs/segment.c +2 -0
+		rw |= REQ_META;
+
 	if (sbi->bio[btype]) {
 		struct bio_private *p = sbi->bio[btype]->bi_private;
 		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,
Signature · 2 lines
Jaegeuk Kim
Samsung
#2 lore raw

2013/4/22, Jaegeuk Kim <[email protected]>:

Quoted 25 lines

2013-04-20 (토), 01:27 +0900, Namjae Jeon:

Quoted 24 lines

From: Namjae Jeon <[email protected]>

Adding REQ_META for all the metadata requests can help in improving the FS performance, if the underlying device supports TAGGING. So, when considering the submit_bio path for all the f2fs requests. We can
add REQ_META for all the META requests.
As a precursor to this change we considered the commit 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'

---
 fs/f2fs/segment.c |    3 +++
 1 file changed, 3 insertions(+)
fs/f2fs/segment.c +0 -0
index 1193a26..a2e5de7 100644
@@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
 	if (type >= META_FLUSH)
 		rw = WRITE_FLUSH_FUA;
 
Quoted 4 lines

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 692

Quoted 1 line
fs/f2fs/segment.c +1 -0
+	if (type == META)

Should be if (btype == META).
Thanks,

Yes, Right :)
Thanks for fixing.

Quoted 11 lines

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 697

Quoted 6 lines
fs/f2fs/segment.c +2 -0
+		rw |= REQ_META;
+
 	if (sbi->bio[btype]) {
 		struct bio_private *p = sbi->bio[btype]->bi_private;
 		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,

--
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 7 lines
Quoted 5 lines

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 692

Quoted 2 lines
fs/f2fs/segment.c +1 -0
+	if (type == META)

Should be if (btype == META).
Thanks,

Yes, Right :)
Thanks for fixing.

Hi. Jaegeuk.
Should I resend the fixed patch as above your comment ?

Thanks.

Quoted 12 lines
Quoted 11 lines

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 697

Quoted 6 lines
fs/f2fs/segment.c +2 -0
+		rw |= REQ_META;
+
 	if (sbi->bio[btype]) {
 		struct bio_private *p = sbi->bio[btype]->bi_private;
 		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,

--
Jaegeuk Kim
Samsung

#4 lore raw

2013-04-24 (수), 15:08 +0900, Namjae Jeon:

Quoted 9 lines
Quoted 7 lines
Quoted 5 lines

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 692

Quoted 2 lines
fs/f2fs/segment.c +1 -0
+	if (type == META)

Should be if (btype == META).
Thanks,

Yes, Right :)
Thanks for fixing.

Hi. Jaegeuk.
Should I resend the fixed patch as above your comment ?

I can handle it. :)
Thanks,

Quoted 19 lines

Thanks.

Quoted 12 lines
Quoted 11 lines

fs/f2fs/segment.c static void do_submit_bio(struct f2fs_sb_info *sbi, · line 697

Quoted 6 lines
fs/f2fs/segment.c +2 -0
+		rw |= REQ_META;
+
 	if (sbi->bio[btype]) {
 		struct bio_private *p = sbi->bio[btype]->bi_private;
 		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,

--
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Jaegeuk Kim
Samsung