Skip to contentSkip to conversation

ath10k: WMI API updates

PATCH Superseded Sujith Manoharan 3 participants 10 messages Apr 23, 2013 Qualcomm Atheros ATH10K wireless driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ath10k: WMI API updates

From: Sujith Manoharan <[email protected]>

To sync with new FW.

---
 drivers/net/wireless/ath/ath10k/wmi.h | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/net/wireless/ath/ath10k/wmi.h +9 -0
index 2bb8f0a..ffc9d28 100644
@@ -378,6 +378,8 @@ enum wmi_cmd_id {
 	WMI_DBGLOG_CFG_CMDID,
 	WMI_PDEV_QVIT_CMDID,
 	WMI_PDEV_FTM_INTG_CMDID,
+	WMI_VDEV_SET_KEEPALIVE_CMDID,
+	WMI_VDEV_GET_KEEPALIVE_CMDID,
 	WMI_PDEV_UTF_CMDID,
 };
 
@@ -440,6 +442,8 @@ enum wmi_event_id {
 	WMI_PDEV_QVIT_EVENTID,
 	WMI_WLAN_PROFILE_DATA_EVENTID,
 	WMI_PDEV_FTM_INTG_EVENTID,
+	WMI_WLAN_FREQ_AVOID_EVENTID,
+	WMI_VDEV_GET_KEEPALIVE_EVENTID,
 	WMI_PDEV_UTF_EVENTID,
 };
 
@@ -1054,6 +1058,9 @@ struct wmi_start_scan_cmd {
 	__le32 probe_delay;
 	/* Scan control flags */
 	__le32 scan_ctrl_flags;
+
+	/* Burst duration time in msecs */
+	__le32 burst_duration;
 	/*
 	 * TLV (tag length value )  paramerters follow the scan_cmd structure.
 	 * TLV can contain channel list, bssid list, ssid list and
@@ -2038,6 +2045,8 @@ enum wmi_vdev_param {
 	WMI_VDEV_PARAM_MCAST_INDICATE,
 	/* Tx DHCP packet indicate Enable/Disable */
 	WMI_VDEV_PARAM_DHCP_INDICATE,
+	/* Enable host inspection of Tx unicast packet to unknown destination */
+	WMI_VDEV_PARAM_UNKNOWN_DEST_INDICATE,
 
 	/* The minimum amount of time AP begins to consider STA inactive */
 	WMI_VDEV_PARAM_AP_KEEPALIVE_MIN_IDLE_INACTIVE_TIME_SECS,
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 2/3 ath10k: Merge debug levels

From: Sujith Manoharan <[email protected]>

BMI, BOOT with CORE and RX with HTT.

---
 drivers/net/wireless/ath/ath10k/bmi.c   |  8 ++++----
 drivers/net/wireless/ath/ath10k/core.c  |  4 ++--
 drivers/net/wireless/ath/ath10k/debug.h | 19 ++++++++-----------
 drivers/net/wireless/ath/ath10k/txrx.c  |  2 +-
 4 files changed, 15 insertions(+), 18 deletions(-)
drivers/net/wireless/ath/ath10k/bmi.c +4 -4
index 85bf366..512f54f 100644
@@ -27,7 +27,7 @@ int ath10k_bmi_done(struct ath10k *ar)
 	int ret;
 
 	if (ar->bmi.done_sent) {
-		ath10k_dbg(ATH10K_DBG_BMI, "%s skipped\n", __func__);
+		ath10k_dbg(ATH10K_DBG_CORE, "%s skipped\n", __func__);
 		return 0;
 	}
 
@@ -91,7 +91,7 @@ int ath10k_bmi_read_memory(struct ath10k *ar,
 		return -EBUSY;
 	}
 
-	ath10k_dbg(ATH10K_DBG_BMI,
+	ath10k_dbg(ATH10K_DBG_CORE,
 		   "%s: (device: 0x%p, address: 0x%x, length: %d)\n",
 		   __func__, ar, address, length);
 
@@ -130,7 +130,7 @@ int ath10k_bmi_write_memory(struct ath10k *ar,
 		return -EBUSY;
 	}
 
-	ath10k_dbg(ATH10K_DBG_BMI,
+	ath10k_dbg(ATH10K_DBG_CORE,
 		   "%s: (device: 0x%p, address: 0x%x, length: %d)\n",
 		   __func__, ar, address, length);
 
@@ -176,7 +176,7 @@ int ath10k_bmi_execute(struct ath10k *ar, u32 address, u32 *param)
 		return -EBUSY;
 	}
 
-	ath10k_dbg(ATH10K_DBG_BMI,
+	ath10k_dbg(ATH10K_DBG_CORE,
 		   "%s: (device: 0x%p, address: 0x%x, param: %d)\n",
 		   __func__, ar, address, *param);
 
drivers/net/wireless/ath/ath10k/core.c +2 -2
index 07102b8..e2379ff 100644
@@ -266,7 +266,7 @@ static int ath10k_init_transfer_bin_file(struct ath10k *ar,
 		/* Determine where in Target RAM to write Board Data */
 		ath10k_bmi_read32(ar, hi_board_ext_data, &board_ext_address);
 
-		ath10k_dbg(ATH10K_DBG_BOOT,
+		ath10k_dbg(ATH10K_DBG_CORE,
 			   "ath10k: Board extended Data download addr: 0x%x\n",
 			   board_ext_address);
 
@@ -347,7 +347,7 @@ static int ath10k_init_download_firmware(struct ath10k *ar)
 
 	/* Transfer One Time Programmable data */
 	address = ar->hw_params.patch_load_addr;
-	ath10k_dbg(ATH10K_DBG_BOOT,
+	ath10k_dbg(ATH10K_DBG_CORE,
 		   "Using 0x%x for the remainder of init\n", address);
 
 	status = ath10k_init_transfer_bin_file(ar, ATH10K_FILE_OTP,
drivers/net/wireless/ath/ath10k/debug.h +8 -11
index 3ae598a..8c0a499 100644
@@ -23,17 +23,14 @@
 
 enum ath10k_debug_mask {
 	ATH10K_DBG_PCI		= 0x00000001,
-	ATH10K_DBG_BMI		= 0x00000002,
-	ATH10K_DBG_WMI		= 0x00000004,
-	ATH10K_DBG_HTC		= 0x00000008,
-	ATH10K_DBG_HTT		= 0x00000010,
-	ATH10K_DBG_MAC		= 0x00000020,
-	ATH10K_DBG_CORE		= 0x00000040,
-	ATH10K_DBG_BOOT		= 0x00000080,
-	ATH10K_DBG_PCI_DUMP	= 0x00000100,
-	ATH10K_DBG_HTT_DUMP	= 0x00000200,
-	ATH10K_DBG_RX		= 0x00000400,
-	ATH10K_DBG_BEACON	= 0x00000800,
+	ATH10K_DBG_WMI		= 0x00000002,
+	ATH10K_DBG_HTC		= 0x00000004,
+	ATH10K_DBG_HTT		= 0x00000008,
+	ATH10K_DBG_MAC		= 0x00000010,
+	ATH10K_DBG_CORE		= 0x00000020,
+	ATH10K_DBG_PCI_DUMP	= 0x00000040,
+	ATH10K_DBG_HTT_DUMP	= 0x00000080,
+	ATH10K_DBG_BEACON	= 0x00000100,
 	ATH10K_DBG_ANY		= 0xffffffff,
 };
 
drivers/net/wireless/ath/ath10k/txrx.c +1 -1
index 6a66dc2..0e8f86d 100644
@@ -269,7 +269,7 @@ void ath10k_process_rx(struct ath10k *ar, struct htt_rx_info *info)
 	status->freq = ch->center_freq;
 	rcu_read_unlock();
 
-	ath10k_dbg(ATH10K_DBG_RX,
+	ath10k_dbg(ATH10K_DBG_HTT,
 		   "rx skb %p len %u %s%s%s%s%s %srate_idx %u vht_nss %u freq %u band %u\n",
 		   info->skb,
 		   info->skb->len,
Signature · 1 line
1.8.2.1
#2 lore raw

PATCH 3/3 ath10k: Initialize CW mode

In reply to Sujith Manoharan

From: Sujith Manoharan <[email protected]>

Set the channel width mode to static by default.

---
 drivers/net/wireless/ath/ath10k/mac.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/wireless/ath/ath10k/mac.c +7 -0
index 60855fb..84a5359 100644
@@ -1519,6 +1519,9 @@ static void ath10k_tx(struct ieee80211_hw *hw,
 	ath10k_tx_htt(ar, skb);
 }
 
+/*
+ * Initialize various parameters with default vaules.
+ */
 static int ath10k_start(struct ieee80211_hw *hw)
 {
 	struct ath10k *ar = hw->priv;
@@ -1528,6 +1531,10 @@ static int ath10k_start(struct ieee80211_hw *hw)
 	if (ret)
 		ath10k_warn("could not enable WMI_PDEV_PARAM_PMF_QOS (%d)\n", ret);
 
+	ret = ath10k_wmi_pdev_set_param(ar, WMI_PDEV_PARAM_DYNAMIC_BW, 0);
+	if (ret)
+		ath10k_warn("could not init WMI_PDEV_PARAM_DYNAMIC_BW (%d)\n", ret);
+
 	return 0;
 }
 
Signature · 1 line
1.8.2.1
#3 lore raw

PATCH 3/3 ath10k: Initialize CW mode

Quoted 5 lines · Sujith Manoharan

From: Sujith Manoharan <[email protected]>

Set the channel width mode to static by default.

Why? What's the change from user's point of view?

(The patch is ok, the reasoning just needs to be documented.)

Signature · 1 line
Kalle Valo
#4 lore raw

PATCH 3/3 ath10k: Initialize CW mode

Quoted 1 line · Kalle Valo

Why? What's the change from user's point of view?

Dynamic CWM needs to be tested properly. For now static channel bandwidth can be used (whatever hostapd gives the driver).

Sujith

#5 lore raw

PATCH 1/3 ath10k: WMI API updates

In reply to Sujith Manoharan
Quoted 1 line

-----Original Message-----

From: [email protected] [mailto:ath9k-devel-

Quoted 8 lines

bounces at lists.ath9k.org] On Behalf Of Sujith Manoharan
Sent: 23 kwietnia 2013 09:59
To: ath9k-devel at lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/3] ath10k: WMI API updates

From: Sujith Manoharan <[email protected]>

To sync with new FW.

You mean with .599 or newer?

-Bartosz

#7 lore raw

PATCH 1/3 ath10k: WMI API updates

Quoted 3 lines · Kalle Valo
Quoted 1 line

To sync with new FW.

What version?

I think with version .603.

Sujith

#8 lore raw

PATCH 1/3 ath10k: WMI API updates

Quoted 6 lines · Sujith Manoharan
Quoted 3 lines · Kalle Valo
Quoted 1 line

To sync with new FW.

What version?

I think with version .603.

Please add the firmware version to the commit log and update SUPPORTED_FW_BUILD accordingly.

Signature · 1 line
Kalle Valo
#9 lore raw

PATCH 1/3 ath10k: WMI API updates

Quoted 2 lines · Kalle Valo

Please add the firmware version to the commit log and update SUPPORTED_FW_BUILD accordingly.

Ok. I'll send a v2 once the new FW is uploaded.

Sujith