Skip to contentSkip to conversation

mtd: spi: winbond: add W25PXX support

PATCH New Kuo-Jung Su 2 participants 10 messages Apr 26, 2013 – May 28, 2013 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +16 -1
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	{
+		.id			= 0x2014,
+		.nr_blocks		= 16,
+		.name			= "W25P80",
+	},
+	{
+		.id			= 0x2015,
+		.nr_blocks		= 32,
+		.name			= "W25P16",
+	},
+	{
+		.id			= 0x2016,
+		.nr_blocks		= 64,
+		.name			= "W25P32",
+	},
+	{
 		.id			= 0x3013,
 		.nr_blocks		= 8,
 		.name			= "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
 	}
 
 	flash->page_size = 256;
-	flash->sector_size = 4096;
+	flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
 	flash->size = 4096 * 16 * params->nr_blocks;
 
 	return flash;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

Hi,

I have a simple question like these parts are legacy flashes i guess. Could you please tell me on which boards these were used?

Thanks,
Jagan.

Quoted 49 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +16 -2
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",
+       },
+       {
+               .id                     = 0x2015,
+               .nr_blocks              = 32,
+               .name                   = "W25P16",
+       },
+       {
+               .id                     = 0x2016,
+               .nr_blocks              = 64,
+               .name                   = "W25P32",
+       },
+       {
                .id                     = 0x3013,
                .nr_blocks              = 8,
                .name                   = "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
        }
 
        flash->page_size = 256;
-       flash->sector_size = 4096;
+       flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
        flash->size = 4096 * 16 * params->nr_blocks;
 
        return flash;
--

1.7.9.5

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#2 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

2013/5/22 Jagan Teki <[email protected]>:

Quoted 5 lines

Hi,

I have a simple question like these parts are legacy flashes i guess. Could you please tell me on which boards these were used?

It's used on Faraday A369 evaluation board.
However the u-boot source codes for A369 is still waiting for approval. Here is the link to u-boot patchwork:

http://patchwork.ozlabs.org/patch/242006/

Quoted 45 lines

Thanks,
Jagan.

Quoted 41 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +16 -1
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",
+       },
+       {
+               .id                     = 0x2015,
+               .nr_blocks              = 32,
+               .name                   = "W25P16",
+       },
+       {
+               .id                     = 0x2016,
+               .nr_blocks              = 64,
+               .name                   = "W25P32",
+       },
+       {
                .id                     = 0x3013,
                .nr_blocks              = 8,
                .name                   = "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
        }
 
        flash->page_size = 256;
-       flash->sector_size = 4096;
+       flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
        flash->size = 4096 * 16 * params->nr_blocks;
 
Quoted 8 lines
Quoted 8 lines
drivers/mtd/spi/winbond.c +0 -1
        return flash;
--

1.7.9.5

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Best wishes,
Kuo-Jung Su

#3 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

Hi,

Quoted 10 lines · Kuo-Jung Su

2013/5/22 Jagan Teki <[email protected]>:

Quoted 5 lines

Hi,

I have a simple question like these parts are legacy flashes i guess. Could you please tell me on which boards these were used?

It's used on Faraday A369 evaluation board.
However the u-boot source codes for A369 is still waiting for approval. Here is the link to u-boot patchwork:

Ok, Thanks for your information.

Quoted 20 lines

http://patchwork.ozlabs.org/patch/242006/

Quoted 17 lines

Thanks,
Jagan.

Quoted 13 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +0 -0
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
Quoted 5 lines
Quoted 5 lines

drivers/mtd/spi/winbond.c struct winbond_spi_flash_params { · line 23

Quoted 5 lines
drivers/mtd/spi/winbond.c +3 -0
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",

W25P80 is an 8Mbit flash right, is this name W25P80 or W25P08? ofcourse, I have seen the same on datasheet as well.

Thanks,
Jagan.

Quoted 37 lines
Quoted 23 lines
Quoted 23 lines
drivers/mtd/spi/winbond.c +13 -1
+       },
+       {
+               .id                     = 0x2015,
+               .nr_blocks              = 32,
+               .name                   = "W25P16",
+       },
+       {
+               .id                     = 0x2016,
+               .nr_blocks              = 64,
+               .name                   = "W25P32",
+       },
+       {
                .id                     = 0x3013,
                .nr_blocks              = 8,
                .name                   = "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
        }
 
        flash->page_size = 256;
-       flash->sector_size = 4096;
+       flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
        flash->size = 4096 * 16 * params->nr_blocks;
 
Quoted 8 lines
Quoted 8 lines
drivers/mtd/spi/winbond.c +0 -1
        return flash;
--

1.7.9.5

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Best wishes,
Kuo-Jung Su

#4 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

2013/5/23 Jagan Teki <[email protected]>:

Quoted 36 lines

Hi,

Quoted 10 lines · Kuo-Jung Su

2013/5/22 Jagan Teki <[email protected]>:

Quoted 5 lines

Hi,

I have a simple question like these parts are legacy flashes i guess. Could you please tell me on which boards these were used?

It's used on Faraday A369 evaluation board.
However the u-boot source codes for A369 is still waiting for approval. Here is the link to u-boot patchwork:

Ok, Thanks for your information.

Quoted 20 lines

http://patchwork.ozlabs.org/patch/242006/

Quoted 17 lines

Thanks,
Jagan.

Quoted 13 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +0 -0
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
Quoted 9 lines
Quoted 5 lines
Quoted 5 lines

drivers/mtd/spi/winbond.c struct winbond_spi_flash_params { · line 23

Quoted 5 lines
drivers/mtd/spi/winbond.c +3 -0
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",

W25P80 is an 8Mbit flash right, is this name W25P80 or W25P08? ofcourse, I have seen the same on datasheet as well.

It's W25P80.
They are formally NexFlash NX25P80, NX25P16 and NX25P32.

I've google for the W25P08, it looks like that Windond did have some legacy small SPI flash: W25P01, W25P02 .. W25P16. I guess it's a different production line...

BTW I don't have these chips and corresponding datasheet, too.

Quoted 40 lines

Thanks,
Jagan.

Quoted 37 lines
Quoted 23 lines
Quoted 23 lines
drivers/mtd/spi/winbond.c +13 -1
+       },
+       {
+               .id                     = 0x2015,
+               .nr_blocks              = 32,
+               .name                   = "W25P16",
+       },
+       {
+               .id                     = 0x2016,
+               .nr_blocks              = 64,
+               .name                   = "W25P32",
+       },
+       {
                .id                     = 0x3013,
                .nr_blocks              = 8,
                .name                   = "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
        }
 
        flash->page_size = 256;
-       flash->sector_size = 4096;
+       flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
        flash->size = 4096 * 16 * params->nr_blocks;
 
Quoted 8 lines
Quoted 8 lines
drivers/mtd/spi/winbond.c +0 -1
        return flash;
--

1.7.9.5

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Best wishes,
Kuo-Jung Su

--
Best wishes,
Kuo-Jung Su

#5 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

Quoted 47 lines · Kuo-Jung Su

2013/5/23 Jagan Teki <[email protected]>:

Quoted 36 lines

Hi,

Quoted 10 lines · Kuo-Jung Su

2013/5/22 Jagan Teki <[email protected]>:

Quoted 5 lines

Hi,

I have a simple question like these parts are legacy flashes i guess. Could you please tell me on which boards these were used?

It's used on Faraday A369 evaluation board.
However the u-boot source codes for A369 is still waiting for approval. Here is the link to u-boot patchwork:

Ok, Thanks for your information.

Quoted 20 lines

http://patchwork.ozlabs.org/patch/242006/

Quoted 17 lines

Thanks,
Jagan.

Quoted 13 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +0 -0
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
Quoted 9 lines
Quoted 5 lines
Quoted 5 lines

drivers/mtd/spi/winbond.c struct winbond_spi_flash_params { · line 23

Quoted 5 lines
drivers/mtd/spi/winbond.c +3 -0
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",

W25P80 is an 8Mbit flash right, is this name W25P80 or W25P08? ofcourse, I have seen the same on datasheet as well.

Quoted 8 lines

It's W25P80.
They are formally NexFlash NX25P80, NX25P16 and NX25P32.

I've google for the W25P08, it looks like that Windond did have some legacy small SPI flash: W25P01, W25P02 .. W25P16. I guess it's a different production line...

BTW I don't have these chips and corresponding datasheet, too.

Ok.

Can you use the commit msg header as
"sf: winbond: "
Which is used for winbond mtd driver since from long, of-course not a big deal and
also mentioned atleast single line message on body.

Simple recommendation here:.
"Add support for Winbond's W25PXX SPI flash. These devices is used on Faraday A369 evaluation board"

Thanks,
Jagan.

#6 lore raw

PATCH 1/1 mtd: spi: winbond: add W25PXX support

2013/5/23 Jagan Teki <[email protected]>:

Quoted 57 lines · Kuo-Jung Su
Quoted 47 lines

2013/5/23 Jagan Teki <[email protected]>:

Quoted 36 lines

Hi,

Quoted 10 lines · Kuo-Jung Su

2013/5/22 Jagan Teki <[email protected]>:

Quoted 5 lines

Hi,

I have a simple question like these parts are legacy flashes i guess. Could you please tell me on which boards these were used?

It's used on Faraday A369 evaluation board.
However the u-boot source codes for A369 is still waiting for approval. Here is the link to u-boot patchwork:

Ok, Thanks for your information.

Quoted 20 lines

http://patchwork.ozlabs.org/patch/242006/

Quoted 17 lines

Thanks,
Jagan.

Quoted 13 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

---
 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +0 -0
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
Quoted 9 lines
Quoted 5 lines
Quoted 5 lines

drivers/mtd/spi/winbond.c struct winbond_spi_flash_params { · line 23

Quoted 5 lines
drivers/mtd/spi/winbond.c +3 -0
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",

W25P80 is an 8Mbit flash right, is this name W25P80 or W25P08? ofcourse, I have seen the same on datasheet as well.

Quoted 8 lines

It's W25P80.
They are formally NexFlash NX25P80, NX25P16 and NX25P32.

I've google for the W25P08, it looks like that Windond did have some legacy small SPI flash: W25P01, W25P02 .. W25P16. I guess it's a different production line...

BTW I don't have these chips and corresponding datasheet, too.

Quoted 8 lines

Ok.

Can you use the commit msg header as
"sf: winbond: "
Which is used for winbond mtd driver since from long, of-course not a big deal and
also mentioned atleast single line message on body.

Sure, I'll re-format the patch and re-post again.

Quoted 4 lines

Simple recommendation here:.
"Add support for Winbond's W25PXX SPI flash. These devices is used on Faraday A369 evaluation board"

Thanks.
It's pretty helpful to me, because my English is really terrible. :)

Quoted 2 lines

Thanks,
Jagan.

--
Best wishes,
Kuo-Jung Su

#7 lore raw

PATCH v2 1/1 sf: winbond: Add support for W25PXX SPI flash

In reply to Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

Add support for Winbond's W25PXX SPI flash. These devices is used on Faraday A369 evaluation board.

---
Changes for v2:
- Update commit message header
- Add commit message body

 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +16 -1
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	{
+		.id			= 0x2014,
+		.nr_blocks		= 16,
+		.name			= "W25P80",
+	},
+	{
+		.id			= 0x2015,
+		.nr_blocks		= 32,
+		.name			= "W25P16",
+	},
+	{
+		.id			= 0x2016,
+		.nr_blocks		= 64,
+		.name			= "W25P32",
+	},
+	{
 		.id			= 0x3013,
 		.nr_blocks		= 8,
 		.name			= "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
 	}
 
 	flash->page_size = 256;
-	flash->sector_size = 4096;
+	flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
 	flash->size = 4096 * 16 * params->nr_blocks;
 
 	return flash;
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH v2 1/1 sf: winbond: Add support for W25PXX SPI flash

Quoted 52 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

Add support for Winbond's W25PXX SPI flash. These devices is used on Faraday A369 evaluation board.

---
Changes for v2:
- Update commit message header
- Add commit message body

 drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +16 -2
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
 static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
+               .id                     = 0x2014,
+               .nr_blocks              = 16,
+               .name                   = "W25P80",
+       },
+       {
+               .id                     = 0x2015,
+               .nr_blocks              = 32,
+               .name                   = "W25P16",
+       },
+       {
+               .id                     = 0x2016,
+               .nr_blocks              = 64,
+               .name                   = "W25P32",
+       },
+       {
                .id                     = 0x3013,
                .nr_blocks              = 8,
                .name                   = "W25X40",
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
        }
 
        flash->page_size = 256;
-       flash->sector_size = 4096;
+       flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
        flash->size = 4096 * 16 * params->nr_blocks;
 
        return flash;
--
Quoted 2 lines

1.7.9.5

--
Thanks,
Jagan.

#9 lore raw

PATCH v2 1/1 sf: winbond: Add support for W25PXX SPI flash

In reply to Kuo-Jung Su
Quoted 44 lines · Kuo-Jung Su

From: Kuo-Jung Su <[email protected]>

Add support for Winbond's W25PXX SPI flash. These devices is used on Faraday A369 evaluation board.

---
Changes for v2:
- Update commit message header
- Add commit message body

  drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
  1 file changed, 16 insertions(+), 1 deletion(-)
drivers/mtd/spi/winbond.c +15 -0
index 2716209..2a27837 100644
@@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
 
  static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
  	{
+		.id			= 0x2014,
+		.nr_blocks		= 16,
+		.name			= "W25P80",
+	},
+	{
+		.id			= 0x2015,
+		.nr_blocks		= 32,
+		.name			= "W25P16",
+	},
+	{
+		.id			= 0x2016,
+		.nr_blocks		= 64,
+		.name			= "W25P32",
+	},
+	{
  		.id			= 0x3013,
  		.nr_blocks		= 8,
  		.name			= "W25X40",

drivers/mtd/spi/winbond.c struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode) · line 125

Quoted 8 lines
drivers/mtd/spi/winbond.c +1 -1
@@ -104,7 +119,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
  	}
 
  	flash->page_size = 256;
-	flash->sector_size = 4096;
+	flash->sector_size = (idcode[1] == 0x20) ? 65536 : 4096;
  	flash->size = 4096 * 16 * params->nr_blocks;
 
  	return flash;

Applied to u-boot-spi/master

--
Thanks,
Jagan.