Skip to contentSkip to conversation

pinctrl: fix mutex deadlock in get_pinctrl_dev_from_of_node()

PATCH In review Daniel Mack 2 participants 2 messages Apr 26, 2013 – Apr 29, 2013 Pin control

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: fix mutex deadlock in get_pinctrl_dev_from_of_node()

This obvious bug was introduced by d755910b7 ("pinctrl: move subsystem mutex to pinctrl_dev struct").

---
This applies on today's linux-next.

 drivers/pinctrl/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/core.c +1 -1
index 37cd774..78eae4d 100644
@@ -129,7 +129,7 @@ struct pinctrl_dev *get_pinctrl_dev_from_of_node(struct device_node *np)
 			return pctldev;
 		}
 
-	mutex_lock(&pinctrldev_list_mutex);
+	mutex_unlock(&pinctrldev_list_mutex);
 
 	return NULL;
 }
Signature · 1 line
1.8.1.4