Skip to contentSkip to conversation

posix_timers: do not account group_exec_runtime for dying autoreaped tasks

PATCH In review Olivier Langlois 3 participants 4 messages Apr 29, 2013 – May 11, 2013 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/3 posix_timers: do not account group_exec_runtime for dying autoreaped tasks

Forbids the cputimer to drift ahead of its process clock by blocking its update when a tick occurs while a autoreaping task is currently in do_exit() between the call to release_task() and its final call to schedule().

Any task stats update after having called release_task() will be lost because they are added to the global process stats located in the signal struct from release_task().

---
 kernel/sched/fair.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
kernel/sched/fair.c +9 -1
index 7a33e59..52d7b10 100644
@@ -708,7 +708,15 @@ static void update_curr(struct cfs_rq *cfs_rq)
 
                trace_sched_stat_runtime(curtask, delta_exec, curr->vruntime);
                cpuacct_charge(curtask, delta_exec);
-               account_group_exec_runtime(curtask, delta_exec);
+               /*
+                * Do not update the cputimer if the task is already released by
+                * release_task().
+                *
+                * it would preferable to defer the autoreap release_task
+                * after the last context switch but harder to do.
+                */
+               if (likely(curtask->sighand))
+                       account_group_exec_runtime(curtask, delta_exec);
        }
 
        account_cfs_rq_runtime(cfs_rq, delta_exec);
Signature · 1 line
1.8.2.1
#1 lore raw
Quoted 10 lines · Olivier Langlois

Forbids the cputimer to drift ahead of its process clock by blocking its update when a tick occurs while a autoreaping task is currently in do_exit() between the call to release_task() and its final call to schedule().

Any task stats update after having called release_task() will be lost because they are added to the global process stats located in the signal struct from release_task().

I wonder if this is real problem that the clock is ahead of the timer. Have you seen any issue in practice with this? Or may be it's a guarantee that the posix clock should provide wrt. to the timer?

thanks.

Quoted 36 lines
---
 kernel/sched/fair.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
kernel/sched/fair.c +9 -1
index 7a33e59..52d7b10 100644
@@ -708,7 +708,15 @@ static void update_curr(struct cfs_rq *cfs_rq)
 
                trace_sched_stat_runtime(curtask, delta_exec, curr->vruntime);
                cpuacct_charge(curtask, delta_exec);
-               account_group_exec_runtime(curtask, delta_exec);
+               /*
+                * Do not update the cputimer if the task is already released by
+                * release_task().
+                *
+                * it would preferable to defer the autoreap release_task
+                * after the last context switch but harder to do.
+                */
+               if (likely(curtask->sighand))
+                       account_group_exec_runtime(curtask, delta_exec);
        }
 
        account_cfs_rq_runtime(cfs_rq, delta_exec);
Signature · 8 lines
1.8.2.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw

Frederic,

Quoted 8 lines · Frederic Weisbecker
Quoted 7 lines · Olivier Langlois

Forbids the cputimer to drift ahead of its process clock by blocking its update when a tick occurs while a autoreaping task is currently in do_exit() between the call to release_task() and its final call to schedule().

Quoted 6 lines
Quoted 3 lines

Any task stats update after having called release_task() will be lost because they are added to the global process stats located in the signal struct from release_task().

I wonder if this is real problem that the clock is ahead of the timer. Have you seen any issue in practice with this?

note that it is the timer that will be ahead because the process clock is the sum of past group tasks exec time plus current group tasks exec time. Few updates are missing in the past group tasks exec time counter in struct signal.

The effect of this is failure of the unittest testing POSIX compliance in glibc rt/tst-cputimer1.c

pseudo code of the test is:

1. call clock_gettime() to get now
2. Compute timer expiring time now+timer interval
3. call clock_gettime() when timer cb is called
4. Compare that clock_gettime() result is >= than computed expiring time

The error is adding up as more thread exits and usually the test fails when testing periodic timers where threads are created to handle the timer timeouts.

Quoted 43 lines

Or may be it's a
guarantee that the posix clock should provide wrt. to the timer?

thanks.

Quoted 36 lines
---
 kernel/sched/fair.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
kernel/sched/fair.c +9 -1
index 7a33e59..52d7b10 100644
@@ -708,7 +708,15 @@ static void update_curr(struct cfs_rq *cfs_rq)
 
                trace_sched_stat_runtime(curtask, delta_exec, curr->vruntime);
                cpuacct_charge(curtask, delta_exec);
-               account_group_exec_runtime(curtask, delta_exec);
+               /*
+                * Do not update the cputimer if the task is already released by
+                * release_task().
+                *
+                * it would preferable to defer the autoreap release_task
+                * after the last context switch but harder to do.
+                */
+               if (likely(curtask->sighand))
+                       account_group_exec_runtime(curtask, delta_exec);
        }
 
        account_cfs_rq_runtime(cfs_rq, delta_exec);
Signature · 8 lines
1.8.2.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#3 lore raw
Quoted 28 lines · Olivier Langlois

Frederic,

Quoted 8 lines · Frederic Weisbecker
Quoted 7 lines · Olivier Langlois

Forbids the cputimer to drift ahead of its process clock by blocking its update when a tick occurs while a autoreaping task is currently in do_exit() between the call to release_task() and its final call to schedule().

Quoted 6 lines
Quoted 3 lines

Any task stats update after having called release_task() will be lost because they are added to the global process stats located in the signal struct from release_task().

I wonder if this is real problem that the clock is ahead of the timer. Have you seen any issue in practice with this?

note that it is the timer that will be ahead because the process clock is the sum of past group tasks exec time plus current group tasks exec time. Few updates are missing in the past group tasks exec time counter in struct signal.

The effect of this is failure of the unittest testing POSIX compliance in glibc rt/tst-cputimer1.c

pseudo code of the test is:

Quoted 8 lines

1. call clock_gettime() to get now
2. Compute timer expiring time now+timer interval
3. call clock_gettime() when timer cb is called
4. Compare that clock_gettime() result is >= than computed expiring time

The error is adding up as more thread exits and usually the test fails when testing periodic timers where threads are created to handle the timer timeouts.

I see. Ok if it breaks a glibc test, it seems like a good reason to fix it :)

Thanks!