exynos4-is: Fix off-by-one valid range checking for is->config_index

PATCH New Axel Lin 1 participant 1 message Apr 30, 2013

Subsystems (2)

Media (V4L/DVB) Arm Samsung Exynos

lore

Share & tools

lore

Axel Lin

author

2013-04-30 14:18 UTC #0 lore raw

PATCH 1/1 exynos4-is: Fix off-by-one valid range checking for is->config_index

Current code uses is->config_index as array subscript, thus the valid value range is 0 ... ARRAY_SIZE(cmd) - 1.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/media/platform/exynos4-is/fimc-is-regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/media/platform/exynos4-is/fimc-is-regs.c +1 -1

index b0ff67b..d05eaa2 100644
@@ -174,7 +174,7 @@ int fimc_is_hw_change_mode(struct fimc_is *is)
 		HIC_CAPTURE_STILL, HIC_CAPTURE_VIDEO,
 	};
 
-	if (WARN_ON(is->config_index > ARRAY_SIZE(cmd)))
+	if (WARN_ON(is->config_index >= ARRAY_SIZE(cmd)))
 		return -EINVAL;
 
 	mcuctl_write(cmd[is->config_index], is, MCUCTL_REG_ISSR(0));

Signature · 1 line

1.8.1.2