Skip to contentSkip to conversation

added mounting debugfs recipe

PATCH Superseded [email protected] 3 participants 10 messages May 2, 2013 – May 3, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 added mounting debugfs recipe

From: Jingting Zhou <a0221004@ares-ubuntu>

---
 .../packagegroup-arago-base-tisdk-server-extra.bb  |    3 ++-
 .../initscript-debugfs/files/debugfs.sh            |    8 ++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   17 +++++++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100755 meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh
 create mode 100755 meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb +2 -1
index 46db7c2..ba618b2 100755
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \	
-	syslog-ng-plugins \
+    syslog-ng-plugins \
     dtc \
     strongswan \ 
     strongswan-plugins \ 
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \
 	"
meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh new file +8 -0
new file mode 100755
index 0000000..17e2474
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb new file +17 -0
new file mode 100755
index 0000000..c9cb7d0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
+
+LIC_FILES_CHKSUM = "file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"
+
+PR ="r1"
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh ${D}${sysconfdir}/init.d/debugfs.sh
+	ln -sf ../init.d/debugfs.sh ${D}${sysconfdir}/rcS.d/S09debugfs
+}
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 32 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Zhou, Jingting
Sent: Thursday, May 02, 2013 1:36 PM
To: [email protected]
Cc: Zhou, Jingting
Subject: [meta-arago] [PATCH] added mounting debugfs recipe

From: Jingting Zhou <a0221004@ares-ubuntu>

---
 .../packagegroup-arago-base-tisdk-server-extra.bb  |    3 ++-
 .../initscript-debugfs/files/debugfs.sh            |    8
++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   17
+++++++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100755 meta-arago-extras/recipes-bsp/initscript-
debugfs/files/debugfs.sh
 create mode 100755 meta-arago-extras/recipes-bsp/initscript-

debugfs/initscript-debugfs.bb

(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
index 46db7c2..ba618b2 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb RDEPENDS_${PN} = "\ · line 69

Quoted 5 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb +1 -1
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \
-	syslog-ng-plugins \
+    syslog-ng-plugins \

This looks like a mistake. Either in the other patch or this one.

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb RDEPENDS_${PN} = "\ · line 98

Quoted 8 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb +1 -0
     dtc \
     strongswan \
     strongswan-plugins \
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \

Usually this should be split into apatch that adds the recipe and one that adds it to the packagegroup.

Quoted 31 lines
(quoted diff) +0 -0
 	"
(quoted diff) +0 -0

debugfs/files/debugfs.sh b/meta-arago-extras/recipes- bsp/initscript-debugfs/files/debugfs.sh
new file mode 100755
index 0000000..17e2474

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +8 -0
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb
new file mode 100755
index 0000000..c9cb7d0

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +4 -0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
+
+LIC_FILES_CHKSUM =
Quoted 1 line

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"

This file does not have a real license header in it. If you are going to point here you should put the license header in it or use the license file from the core layer. And I wouldn't do the whole script because then you have to update this for every script change.

meta-arago-extras/recipes-bsp/initscript-

Quoted 2 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+PR ="r1"

Why not start at r0?

Quoted 11 lines
meta-arago-extras/recipes-bsp/initscript- new file +9 -0
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +1 -0
+	ln -sf ../init.d/debugfs.sh
Quoted 2 lines

${D}${sysconfdir}/rcS.d/S09debugfs
+}

Use the update-rc.d class instead. Life will be better this way.

Quoted 7 lines

--
1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#2 lore raw

Don't want to create another email thread using git send-email. So I just copy-pasted the subsequent patch here. I can resend it using git send-email if you want.

Had a quick look at update-rc.d.bbclass. But I didn't figure out how to use it.

From 5cd281ab3e6eed71d5a9a899911e9b4485cb39fb Mon Sep 17 00:00:00 2001
From: Jingting Zhou <a0221004@ares-ubuntu>
Date: Thu, 2 May 2013 17:15:23 -0400
Subject: [PATCH] some fix on the initscript-debugfs recipe

---
 .../recipes-bsp/initscript-debugfs/files/LICENSE   |   30 ++++++++++++++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |    7 +++--
 2 files changed, 34 insertions(+), 3 deletions(-)
 create mode 100644 meta-arago-extras/recipes-bsp/initscript-debugfs/files/LICENSE
meta-arago-extras/recipes-bsp/initscript-debugfs/files/LICENSE new file +30 -0
new file mode 100644
index 0000000..33b30bf
@@ -0,0 +1,30 @@
+ *  Copyright 2012, Texas Instruments, Inc.
+ * 
+ *  Redistribution and use in source and binary forms, with or without 
+ *  modification, are permitted provided that the following conditions 
+ *  are met:
+ *
+ *    Redistributions of source code must retain the above copyright 
+ *    notice, this list of conditions and the following disclaimer.
+ *
+ *    Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the 
+ *    documentation and/or other materials provided with the   
+ *    distribution.
+ *
+ *    Neither the name of Texas Instruments Incorporated nor the names of
+ *    its contributors may be used to endorse or promote products derived
+ *    from this software without specific prior written permission.
+ *
+ *  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
+ *  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 
+ *  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *  A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
+ *  OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
+ *  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
+ *  LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
+ *  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
+ *  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +4 -3
index c9cb7d0..eaf316a 100755
@@ -1,11 +1,12 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
-LIC_FILES_CHKSUM = "file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"
 
-PR ="r1"
+PR ="r0"
 
-SRC_URI = "file://debugfs.sh"
+SRC_URI = "file://debugfs.sh \
+		   file://LICENSE"
 
 S = "${WORKDIR}"
 
Signature · 1 line
1.7.9.5

-----Original Message-----
From: Maupin, Chase
Sent: Thursday, May 02, 2013 3:55 PM
To: Zhou, Jingting; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 32 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Zhou, Jingting
Sent: Thursday, May 02, 2013 1:36 PM
To: [email protected]
Cc: Zhou, Jingting
Subject: [meta-arago] [PATCH] added mounting debugfs recipe

From: Jingting Zhou <a0221004@ares-ubuntu>

---
 .../packagegroup-arago-base-tisdk-server-extra.bb  |    3 ++-
 .../initscript-debugfs/files/debugfs.sh            |    8
++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   17
+++++++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)  create mode 100755 
meta-arago-extras/recipes-bsp/initscript-
debugfs/files/debugfs.sh
 create mode 100755 meta-arago-extras/recipes-bsp/initscript-

debugfs/initscript-debugfs.bb

(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
index 46db7c2..ba618b2 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb

Review RDEPENDS_${PN} = "\ · line 69

Quoted 5 lines
(quoted diff) +1 -1
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \
-	syslog-ng-plugins \
+    syslog-ng-plugins \

This looks like a mistake. Either in the other patch or this one.

Review RDEPENDS_${PN} = "\ · line 98

Quoted 8 lines
(quoted diff) +1 -0
     dtc \
     strongswan \
     strongswan-plugins \
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \

Usually this should be split into apatch that adds the recipe and one that adds it to the packagegroup.

Quoted 31 lines
(quoted diff) +0 -0
 	"
(quoted diff) +0 -0

debugfs/files/debugfs.sh b/meta-arago-extras/recipes- bsp/initscript-debugfs/files/debugfs.sh
new file mode 100755
index 0000000..17e2474

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +8 -0
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb
new file mode 100755
index 0000000..c9cb7d0

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +4 -0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
+
+LIC_FILES_CHKSUM =
Quoted 1 line

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"

This file does not have a real license header in it. If you are going to point here you should put the license header in it or use the license file from the core layer. And I wouldn't do the whole script because then you have to update this for every script change.

meta-arago-extras/recipes-bsp/initscript-

Quoted 2 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+PR ="r1"

Why not start at r0?

Quoted 11 lines
meta-arago-extras/recipes-bsp/initscript- new file +9 -0
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +1 -0
+	ln -sf ../init.d/debugfs.sh
Quoted 2 lines

${D}${sysconfdir}/rcS.d/S09debugfs
+}

Use the update-rc.d class instead. Life will be better this way.

Quoted 7 lines

--
1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#3 lore raw
Quoted 6 lines

-----Original Message-----
From: Zhou, Jingting
Sent: Thursday, May 02, 2013 4:34 PM
To: Maupin, Chase; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 6 lines

Don't want to create another email thread using git send-email. So I just copy-pasted the subsequent patch here. I can resend it using git send-email if you want.

Had a quick look at update-rc.d.bbclass. But I didn't figure out how to use it.

Check out meta-arago/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb

Quoted 87 lines

From 5cd281ab3e6eed71d5a9a899911e9b4485cb39fb Mon Sep 17 00:00:00 2001
From: Jingting Zhou <a0221004@ares-ubuntu>
Date: Thu, 2 May 2013 17:15:23 -0400
Subject: [PATCH] some fix on the initscript-debugfs recipe

---
 .../recipes-bsp/initscript-debugfs/files/LICENSE   |   30
++++++++++++++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |    7 +++--
 2 files changed, 34 insertions(+), 3 deletions(-)
 create mode 100644 meta-arago-extras/recipes-bsp/initscript-

debugfs/files/LICENSE

(quoted diff) +0 -0

debugfs/files/LICENSE b/meta-arago-extras/recipes-bsp/initscript- debugfs/files/LICENSE
new file mode 100644
index 0000000..33b30bf

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/LICENSE

meta-arago-extras/recipes-bsp/initscript- new file +3 -0
@@ -0,0 +1,30 @@
+ *  Copyright 2012, Texas Instruments, Inc.
+ *
+ *  Redistribution and use in source and binary forms, with or

without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * Redistributions of source code must retain the above
copyright
+ * notice, this list of conditions and the following
disclaimer.
+ *
+ * Redistributions in binary form must reproduce the above
copyright
+ * notice, this list of conditions and the following
disclaimer in the
+ * documentation and/or other materials provided with the
+ * distribution.
+ *
+ * Neither the name of Texas Instruments Incorporated nor the
names of
+ * its contributors may be used to endorse or promote
products derived
+ * from this software without specific prior written
permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *

(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb index c9cb7d0..eaf316a 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +0 -1
@@ -1,11 +1,12 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
-LIC_FILES_CHKSUM =
Quoted 3 lines

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32" +LIC_FILES_CHKSUM = "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"

You should either add the license in the .sh text file or point to the one that already exists in OE-Core. No need to make your own copy.

Quoted 144 lines
meta-arago-extras/recipes-bsp/initscript- new file +3 -3
-PR ="r1"
+PR ="r0"
 
-SRC_URI = "file://debugfs.sh"
+SRC_URI = "file://debugfs.sh \
+		   file://LICENSE"
 
 S = "${WORKDIR}"
 
--

1.7.9.5

-----Original Message-----
From: Maupin, Chase
Sent: Thursday, May 02, 2013 3:55 PM
To: Zhou, Jingting; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Zhou, Jingting
Sent: Thursday, May 02, 2013 1:36 PM
To: [email protected]
Cc: Zhou, Jingting
Subject: [meta-arago] [PATCH] added mounting debugfs recipe

From: Jingting Zhou <a0221004@ares-ubuntu>

Quoted 7 lines
---
 .../packagegroup-arago-base-tisdk-server-extra.bb  |    3 ++-
 .../initscript-debugfs/files/debugfs.sh            |    8
++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   17
+++++++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)  create mode

100755

Quoted 7 lines

meta-arago-extras/recipes-bsp/initscript-
debugfs/files/debugfs.sh

 create mode 100755 meta-arago-extras/recipes-bsp/initscript-

debugfs/initscript-debugfs.bb

(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-base-tisdk-server-

extra.bb

Quoted 4 lines

b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
index 46db7c2..ba618b2 100755
--- a/meta-arago-distro/recipes-

core/packagegroups/packagegroup-

Quoted 2 lines

arago-base-tisdk-server-extra.bb
+++ b/meta-arago-distro/recipes-

core/packagegroups/packagegroup-

Review RDEPENDS_${PN} = "\ · line 69

Quoted 7 lines

arago-base-tisdk-server-extra.bb

(quoted diff) +1 -1
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \
-	syslog-ng-plugins \
+    syslog-ng-plugins \

This looks like a mistake. Either in the other patch or this one.

Review RDEPENDS_${PN} = "\ · line 98

Quoted 8 lines
(quoted diff) +1 -0
     dtc \
     strongswan \
     strongswan-plugins \
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \

Usually this should be split into apatch that adds the recipe and one that adds it to the packagegroup.

Quoted 31 lines
(quoted diff) +0 -0
 	"
(quoted diff) +0 -0

debugfs/files/debugfs.sh b/meta-arago-extras/recipes- bsp/initscript-debugfs/files/debugfs.sh
new file mode 100755
index 0000000..17e2474

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +8 -0
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb
new file mode 100755
index 0000000..c9cb7d0

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +4 -0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
+
+LIC_FILES_CHKSUM =
Quoted 1 line

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"

This file does not have a real license header in it. If you are going to point here you should put the license header in it or use the license file from the core layer. And I wouldn't do the whole script because then you have to update this for every script change.

meta-arago-extras/recipes-bsp/initscript-

Quoted 2 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+PR ="r1"

Why not start at r0?

Quoted 11 lines
meta-arago-extras/recipes-bsp/initscript- new file +9 -0
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +1 -0
+	ln -sf ../init.d/debugfs.sh
Quoted 2 lines

${D}${sysconfdir}/rcS.d/S09debugfs
+}

Use the update-rc.d class instead. Life will be better this way.

Quoted 7 lines

--
1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#4 lore raw

Hey Chase, thanks for the comments. Here's the patch.

From a1684ac257292855c03e58f3fee60232ed039b81 Mon Sep 17 00:00:00 2001
From: Jingting Zhou <a0221004@ares-ubuntu>
Date: Fri, 3 May 2013 11:56:05 -0400
Subject: [PATCH] using inherit update-rc.d in the initscript-debugfs recipe

---
 .../recipes-bsp/initscript-debugfs/files/LICENSE   |   30 ------------------
 .../initscript-debugfs/files/debugfs.sh            |   32 ++++++++++++++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   16 +++++-----
 3 files changed, 41 insertions(+), 37 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-bsp/initscript-debugfs/files/LICENSE
meta-arago-extras/recipes-bsp/initscript-debugfs/files/LICENSE deleted +0 -30
deleted file mode 100644
index 33b30bf..0000000
@@ -1,30 +0,0 @@
- *  Copyright 2012, Texas Instruments, Inc.
- * 
- *  Redistribution and use in source and binary forms, with or without 
- *  modification, are permitted provided that the following conditions 
- *  are met:
- *
- *    Redistributions of source code must retain the above copyright 
- *    notice, this list of conditions and the following disclaimer.
- *
- *    Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the 
- *    documentation and/or other materials provided with the   
- *    distribution.
- *
- *    Neither the name of Texas Instruments Incorporated nor the names of
- *    its contributors may be used to endorse or promote products derived
- *    from this software without specific prior written permission.
- *
- *  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
- *  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 
- *  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *  A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
- *  OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
- *  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
- *  LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
- *  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
- *  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- *
meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh +32 -0
index 17e2474..9b26279 100755
@@ -1,5 +1,37 @@
 #!/bin/sh
 
+#   Copyright 2012, Texas Instruments, Inc.
+#  
+#   Redistribution and use in source and binary forms, with or without 
+#   modification, are permitted provided that the following conditions 
+#   are met:
+# 
+#     Redistributions of source code must retain the above copyright 
+#     notice, this list of conditions and the following disclaimer.
+# 
+#     Redistributions in binary form must reproduce the above copyright
+#     notice, this list of conditions and the following disclaimer in the 
+#     documentation and/or other materials provided with the   
+#     distribution.
+# 
+#     Neither the name of Texas Instruments Incorporated nor the names of
+#     its contributors may be used to endorse or promote products derived
+#     from this software without specific prior written permission.
+# 
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
+#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 
+#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
+#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
+#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
+#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
+#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
+#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# 
+
+
 if ! [ -e /debug ] ; then
   mkdir -p /debug
 fi
meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +9 -7
index eaf316a..0137214 100755
@@ -1,18 +1,20 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
-LIC_FILES_CHKSUM = "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"
+LIC_FILES_CHKSUM = "file://debugfs.sh;md5=a530203f3f8bf332686f4abf1e434e21"
 
 PR ="r0"
 
-SRC_URI = "file://debugfs.sh \
-		   file://LICENSE"
+SRC_URI = "file://debugfs.sh"
+		   
+INITSCRIPT_NAME = "debugfs.sh"
+INITSCRIPT_PARAMS = "defaults 10"
+
+inherit update-rc.d
 
 S = "${WORKDIR}"
 
 do_install () {
-	install -d ${D}${sysconfdir}/init.d/
-	install -d ${D}${sysconfdir}/rcS.d/
-	install -c -m 755 ${WORKDIR}/debugfs.sh ${D}${sysconfdir}/init.d/debugfs.sh
-	ln -sf ../init.d/debugfs.sh ${D}${sysconfdir}/rcS.d/S09debugfs
+	install -d ${D}${sysconfdir}/init.d/ 
+	install -c -m 755 ${WORKDIR}/debugfs.sh ${D}${sysconfdir}/init.d/debugfs.sh 
 }
Signature · 1 line
1.7.9.5

-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 03, 2013 7:55 AM
To: Zhou, Jingting; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 6 lines

-----Original Message-----
From: Zhou, Jingting
Sent: Thursday, May 02, 2013 4:34 PM
To: Maupin, Chase; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 6 lines

Don't want to create another email thread using git send-email. So I just copy-pasted the subsequent patch here. I can resend it using git send-email if you want.

Had a quick look at update-rc.d.bbclass. But I didn't figure out how to use it.

Check out meta-arago/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb

Quoted 87 lines

From 5cd281ab3e6eed71d5a9a899911e9b4485cb39fb Mon Sep 17 00:00:00 2001
From: Jingting Zhou <a0221004@ares-ubuntu>
Date: Thu, 2 May 2013 17:15:23 -0400
Subject: [PATCH] some fix on the initscript-debugfs recipe

---
 .../recipes-bsp/initscript-debugfs/files/LICENSE   |   30
++++++++++++++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |    7 +++--
 2 files changed, 34 insertions(+), 3 deletions(-)  create mode 100644 

meta-arago-extras/recipes-bsp/initscript-
debugfs/files/LICENSE

(quoted diff) +0 -0

debugfs/files/LICENSE b/meta-arago-extras/recipes-bsp/initscript- debugfs/files/LICENSE
new file mode 100644
index 0000000..33b30bf

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/LICENSE

meta-arago-extras/recipes-bsp/initscript- new file +3 -0
@@ -0,0 +1,30 @@
+ *  Copyright 2012, Texas Instruments, Inc.
+ *
+ *  Redistribution and use in source and binary forms, with or

without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * Redistributions of source code must retain the above
copyright
+ * notice, this list of conditions and the following
disclaimer.
+ *
+ * Redistributions in binary form must reproduce the above
copyright
+ * notice, this list of conditions and the following
disclaimer in the
+ * documentation and/or other materials provided with the
+ * distribution.
+ *
+ * Neither the name of Texas Instruments Incorporated nor the
names of
+ * its contributors may be used to endorse or promote
products derived
+ * from this software without specific prior written
permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *

(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb index c9cb7d0..eaf316a 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +0 -1
@@ -1,11 +1,12 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
-LIC_FILES_CHKSUM =
Quoted 3 lines

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32" +LIC_FILES_CHKSUM = "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"

You should either add the license in the .sh text file or point to the one that already exists in OE-Core. No need to make your own copy.

Quoted 142 lines
meta-arago-extras/recipes-bsp/initscript- new file +3 -3
-PR ="r1"
+PR ="r0"
 
-SRC_URI = "file://debugfs.sh"
+SRC_URI = "file://debugfs.sh \
+		   file://LICENSE"
 
 S = "${WORKDIR}"
 
--

1.7.9.5

-----Original Message-----
From: Maupin, Chase
Sent: Thursday, May 02, 2013 3:55 PM
To: Zhou, Jingting; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Zhou, Jingting
Sent: Thursday, May 02, 2013 1:36 PM
To: [email protected]
Cc: Zhou, Jingting
Subject: [meta-arago] [PATCH] added mounting debugfs recipe

From: Jingting Zhou <a0221004@ares-ubuntu>

Quoted 7 lines
---
 .../packagegroup-arago-base-tisdk-server-extra.bb  |    3 ++-
 .../initscript-debugfs/files/debugfs.sh            |    8
++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   17
+++++++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)  create mode

100755

Quoted 7 lines

meta-arago-extras/recipes-bsp/initscript-
debugfs/files/debugfs.sh

 create mode 100755 meta-arago-extras/recipes-bsp/initscript-

debugfs/initscript-debugfs.bb

(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-base-tisdk-server-

extra.bb

Quoted 4 lines

b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
index 46db7c2..ba618b2 100755
--- a/meta-arago-distro/recipes-

core/packagegroups/packagegroup-

Quoted 2 lines

arago-base-tisdk-server-extra.bb
+++ b/meta-arago-distro/recipes-

core/packagegroups/packagegroup-

Review RDEPENDS_${PN} = "\ · line 69

Quoted 7 lines

arago-base-tisdk-server-extra.bb

(quoted diff) +1 -1
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \
-	syslog-ng-plugins \
+    syslog-ng-plugins \

This looks like a mistake. Either in the other patch or this one.

Review RDEPENDS_${PN} = "\ · line 98

Quoted 8 lines
(quoted diff) +1 -0
     dtc \
     strongswan \
     strongswan-plugins \
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \

Usually this should be split into apatch that adds the recipe and one that adds it to the packagegroup.

Quoted 31 lines
(quoted diff) +0 -0
 	"
(quoted diff) +0 -0

debugfs/files/debugfs.sh b/meta-arago-extras/recipes- bsp/initscript-debugfs/files/debugfs.sh
new file mode 100755
index 0000000..17e2474

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +8 -0
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb
new file mode 100755
index 0000000..c9cb7d0

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +4 -0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
+
+LIC_FILES_CHKSUM =
Quoted 1 line

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"

This file does not have a real license header in it. If you are going to point here you should put the license header in it or use the license file from the core layer. And I wouldn't do the whole script because then you have to update this for every script change.

meta-arago-extras/recipes-bsp/initscript-

Quoted 2 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+PR ="r1"

Why not start at r0?

Quoted 11 lines
meta-arago-extras/recipes-bsp/initscript- new file +9 -0
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +1 -0
+	ln -sf ../init.d/debugfs.sh
Quoted 2 lines

${D}${sysconfdir}/rcS.d/S09debugfs
+}

Use the update-rc.d class instead. Life will be better this way.

Quoted 7 lines

--
1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#5 lore raw
Quoted 6 lines

-----Original Message-----
From: Zhou, Jingting
Sent: Friday, May 03, 2013 10:58 AM
To: Maupin, Chase; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 8 lines

Hey Chase, thanks for the comments. Here's the patch.

From a1684ac257292855c03e58f3fee60232ed039b81 Mon Sep 17 00:00:00 2001
From: Jingting Zhou <a0221004@ares-ubuntu>
Date: Fri, 3 May 2013 11:56:05 -0400
Subject: [PATCH] using inherit update-rc.d in the initscript- debugfs recipe

You need to use a proper commit message here. See http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

This should probably be squashed with the commit that adds the recipe

Quoted 150 lines
---
 .../recipes-bsp/initscript-debugfs/files/LICENSE   |   30 ------
------------
 .../initscript-debugfs/files/debugfs.sh            |   32
++++++++++++++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   16 +++++-
----
 3 files changed, 41 insertions(+), 37 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-bsp/initscript-

debugfs/files/LICENSE

(quoted diff) +0 -0

debugfs/files/LICENSE b/meta-arago-extras/recipes-bsp/initscript- debugfs/files/LICENSE
deleted file mode 100644
index 33b30bf..0000000
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/files/LICENSE
+++ /dev/null

meta-arago-extras/recipes-bsp/initscript-debugfs/files/LICENSE deleted +0 -3
@@ -1,30 +0,0 @@
- *  Copyright 2012, Texas Instruments, Inc.
- *
- *  Redistribution and use in source and binary forms, with or

without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * Redistributions of source code must retain the above
copyright
- * notice, this list of conditions and the following
disclaimer.
- *
- * Redistributions in binary form must reproduce the above
copyright
- * notice, this list of conditions and the following
disclaimer in the
- * documentation and/or other materials provided with the
- * distribution.
- *
- * Neither the name of Texas Instruments Incorporated nor the
names of
- * its contributors may be used to endorse or promote
products derived
- * from this software without specific prior written
permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- *

(quoted diff) +0 -0

debugfs/files/debugfs.sh b/meta-arago-extras/recipes- bsp/initscript-debugfs/files/debugfs.sh
index 17e2474..9b26279 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/files/debugfs.sh
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/files/debugfs.sh

meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh +3 -0
@@ -1,5 +1,37 @@
 #!/bin/sh
 
+#   Copyright 2012, Texas Instruments, Inc.
+#
+#   Redistribution and use in source and binary forms, with or

without
+# modification, are permitted provided that the following
conditions

meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh +3 -0
+#   are met:
+#
+#     Redistributions of source code must retain the above

copyright
+# notice, this list of conditions and the following
disclaimer.

(quoted diff) +2 -0
+#
+#     Redistributions in binary form must reproduce the above

copyright
+# notice, this list of conditions and the following
disclaimer in the

meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh +4 -0
+#     documentation and/or other materials provided with the
+#     distribution.
+#
+#     Neither the name of Texas Instruments Incorporated nor the

names of
+# its contributors may be used to endorse or promote
products derived
+# from this software without specific prior written
permission.

(quoted diff) +2 -0
+#
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND

CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
DAMAGE.

meta-arago-extras/recipes-bsp/initscript-debugfs/files/debugfs.sh +3 -0
+#
+
+
 if ! [ -e /debug ] ; then
   mkdir -p /debug
 fi
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb index eaf316a..0137214 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +0 -1
@@ -1,18 +1,20 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
-LIC_FILES_CHKSUM =
Quoted 3 lines

"file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a" +LIC_FILES_CHKSUM = "file://debugfs.sh;md5=a530203f3f8bf332686f4abf1e434e21"

Do your checksum of only the license lines. This prevents a script change from changing your license checksum. Like meta-ti/recipes-connectivity/uim/uim_git.bb. Notice the startline and end line fields.

Quoted 23 lines

PR ="r0"

meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +6 -5
-SRC_URI = "file://debugfs.sh \
-		   file://LICENSE"
+SRC_URI = "file://debugfs.sh"
+
+INITSCRIPT_NAME = "debugfs.sh"
+INITSCRIPT_PARAMS = "defaults 10"
+
+inherit update-rc.d
 
 S = "${WORKDIR}"
 
 do_install () {
-	install -d ${D}${sysconfdir}/init.d/
-	install -d ${D}${sysconfdir}/rcS.d/
-	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

(quoted diff) +0 -1
-	ln -sf ../init.d/debugfs.sh

${D}${sysconfdir}/rcS.d/S09debugfs

(quoted diff) +2 -0
+	install -d ${D}${sysconfdir}/init.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh
Quoted 1 line

${D}${sysconfdir}/init.d/debugfs.sh

Just a nitpick but there is no need to specify debugfs.sh in the destination path. Also, most init scripts don't bother with the .sh extension. BTW, using "defaults" for update-rc.d will put this script in run levels 2345. If you want it in rcS then you need to change your INITSCRIPT_PARAMS setting. Do a man of update-rc.d to find out how that utility works.

Quoted 283 lines

}
--
1.7.9.5

-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 03, 2013 7:55 AM
To: Zhou, Jingting; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 8 lines

-----Original Message-----
From: Zhou, Jingting
Sent: Thursday, May 02, 2013 4:34 PM
To: Maupin, Chase; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Don't want to create another email thread using git send-email. So I just copy-pasted the subsequent patch here. I can resend

it using

Quoted 3 lines

git send-email if you want.

Had a quick look at update-rc.d.bbclass. But I didn't figure

out how

Quoted 1 line

to use it.

Check out meta-arago/meta-arago-extras/recipes-
core/matrix/matrix-gui_2.0.bb

Quoted 2 lines

From 5cd281ab3e6eed71d5a9a899911e9b4485cb39fb Mon Sep 17

00:00:00

Quoted 9 lines

2001
From: Jingting Zhou <a0221004@ares-ubuntu>
Date: Thu, 2 May 2013 17:15:23 -0400
Subject: [PATCH] some fix on the initscript-debugfs recipe

---
 .../recipes-bsp/initscript-debugfs/files/LICENSE   |   30
++++++++++++++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |    7 +++-

-

Quoted 1 line
 2 files changed, 34 insertions(+), 3 deletions(-)  create mode

100644

Quoted 5 lines

meta-arago-extras/recipes-bsp/initscript-
debugfs/files/LICENSE

(quoted diff) +0 -0

debugfs/files/LICENSE b/meta-arago-extras/recipes-

bsp/initscript-

Quoted 20 lines

debugfs/files/LICENSE
new file mode 100644
index 0000000..33b30bf

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/LICENSE

meta-arago-extras/recipes-bsp/initscript- new file +3 -0
@@ -0,0 +1,30 @@
+ *  Copyright 2012, Texas Instruments, Inc.
+ *
+ *  Redistribution and use in source and binary forms, with or

without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * Redistributions of source code must retain the above
copyright
+ * notice, this list of conditions and the following
disclaimer.
+ *

Quoted 8 lines

+ * Redistributions in binary form must reproduce the above
copyright
+ * notice, this list of conditions and the following
disclaimer in the
+ * documentation and/or other materials provided with the
+ * distribution.
+ *
+ * Neither the name of Texas Instruments Incorporated nor

the

Quoted 9 lines

names of
+ * its contributors may be used to endorse or promote
products derived
+ * from this software without specific prior written
permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,

Quoted 8 lines

BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,

BUT

Quoted 6 lines

NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT

LIABILITY,

Quoted 4 lines

OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF

SUCH

Quoted 15 lines

DAMAGE.
+ *

(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb index c9cb7d0..eaf316a 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +0 -1
@@ -1,11 +1,12 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
-LIC_FILES_CHKSUM =
Quoted 3 lines

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32" +LIC_FILES_CHKSUM = "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"

You should either add the license in the .sh text file or point to the one that already exists in OE-Core. No need to make your own copy.

Quoted 14 lines
meta-arago-extras/recipes-bsp/initscript- new file +3 -3
-PR ="r1"
+PR ="r0"
 
-SRC_URI = "file://debugfs.sh"
+SRC_URI = "file://debugfs.sh \
+		   file://LICENSE"
 
 S = "${WORKDIR}"
 
--

1.7.9.5

Quoted 8 lines

-----Original Message-----
From: Maupin, Chase
Sent: Thursday, May 02, 2013 3:55 PM
To: Zhou, Jingting; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 2 lines

-----Original Message-----
From: [email protected] [mailto:meta-

arago-

Quoted 10 lines
Quoted 10 lines

[email protected]] On Behalf Of Zhou, Jingting
Sent: Thursday, May 02, 2013 1:36 PM
To: [email protected]
Cc: Zhou, Jingting
Subject: [meta-arago] [PATCH] added mounting debugfs recipe

From: Jingting Zhou <a0221004@ares-ubuntu>

---
 .../packagegroup-arago-base-tisdk-server-extra.bb  |    3

++-

Quoted 5 lines
Quoted 5 lines
 .../initscript-debugfs/files/debugfs.sh            |    8
++++++++
 .../initscript-debugfs/initscript-debugfs.bb       |   17
+++++++++++++++++
 3 files changed, 27 insertions(+), 1 deletion(-)  create

mode

Quoted 17 lines

100755

Quoted 7 lines

meta-arago-extras/recipes-bsp/initscript-
debugfs/files/debugfs.sh

 create mode 100755 meta-arago-extras/recipes-bsp/initscript-

debugfs/initscript-debugfs.bb

(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-base-tisdk-server-

extra.bb

Quoted 4 lines

b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
index 46db7c2..ba618b2 100755
--- a/meta-arago-distro/recipes-

core/packagegroups/packagegroup-

Quoted 2 lines

arago-base-tisdk-server-extra.bb
+++ b/meta-arago-distro/recipes-

core/packagegroups/packagegroup-

Quoted 9 lines

Review RDEPENDS_${PN} = "\ · line 69

Quoted 7 lines

arago-base-tisdk-server-extra.bb

(quoted diff) +1 -1
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \
-	syslog-ng-plugins \
+    syslog-ng-plugins \

This looks like a mistake. Either in the other patch or this

one.

Quoted 11 lines

Review RDEPENDS_${PN} = "\ · line 98

Quoted 9 lines
(quoted diff) +1 -0
     dtc \
     strongswan \
     strongswan-plugins \
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \

Usually this should be split into apatch that adds the recipe

and one

Quoted 28 lines

that adds it to the packagegroup.

Quoted 26 lines
(quoted diff) +0 -0
 	"
(quoted diff) +0 -0

debugfs/files/debugfs.sh b/meta-arago-extras/recipes- bsp/initscript-debugfs/files/debugfs.sh
new file mode 100755
index 0000000..17e2474

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/files/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +8 -0
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb
new file mode 100755
index 0000000..c9cb7d0

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/initscript-debugfs.bb

Quoted 8 lines
Quoted 6 lines
meta-arago-extras/recipes-bsp/initscript- new file +4 -0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
+
+LIC_FILES_CHKSUM =

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"

This file does not have a real license header in it. If you

are going

Quoted 1 line

to point here you should put the license header in it or use

the

Quoted 1 line

license file from the core layer. And I wouldn't do the whole

script

Quoted 7 lines

because then you have to update this for every script change.

meta-arago-extras/recipes-bsp/initscript-

Quoted 2 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+PR ="r1"

Why not start at r0?

Quoted 15 lines
Quoted 11 lines
meta-arago-extras/recipes-bsp/initscript- new file +9 -0
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +1 -0
+	ln -sf ../init.d/debugfs.sh
Quoted 2 lines

${D}${sysconfdir}/rcS.d/S09debugfs
+}

Use the update-rc.d class instead. Life will be better this

way.

Quoted 8 lines
Quoted 8 lines

--
1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#6 lore raw
Quoted 5 lines · Chase
Quoted 5 lines

Hey Chase, thanks for the comments. Here's the patch.

From a1684ac257292855c03e58f3fee60232ed039b81 Mon Sep 17 00:00:00 2001
From: Jingting Zhou <a0221004@ares-ubuntu>

^^^^

Quoted 7 lines
Quoted 3 lines

Date: Fri, 3 May 2013 11:56:05 -0400
Subject: [PATCH] using inherit update-rc.d in the initscript- debugfs recipe

You need to use a proper commit message here. See
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Correct. Also make sure your From line is valid. Please configure your git properly - git-config.

Quoted 1 line

This should probably be squashed with the commit that adds the recipe

Heh, and this time it's a patch over patch on top of a patch... :) Don't do this, send a version 3 of the original patch.

Quoted 12 lines
Quoted 12 lines
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb index eaf316a..0137214 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +0 -0
@@ -1,18 +1,20 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
Quoted 9 lines
Quoted 4 lines
(quoted diff) +0 -1
-LIC_FILES_CHKSUM =

"file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a" +LIC_FILES_CHKSUM = "file://debugfs.sh;md5=a530203f3f8bf332686f4abf1e434e21"

Do your checksum of only the license lines. This prevents a script change from changing your license checksum. Like meta-ti/recipes-connectivity/uim/uim_git.bb. Notice the startline and end line fields.

I'd suggest initscript-telnetd here again :)

Quoted 13 lines
Quoted 13 lines

PR ="r0"

meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +6 -2
-SRC_URI = "file://debugfs.sh \
-		   file://LICENSE"
+SRC_URI = "file://debugfs.sh"
+
+INITSCRIPT_NAME = "debugfs.sh"
+INITSCRIPT_PARAMS = "defaults 10"
+
+inherit update-rc.d
 
 S = "${WORKDIR}"
Quoted 16 lines
Quoted 10 lines

do_install () {

meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +0 -3
-	install -d ${D}${sysconfdir}/init.d/
-	install -d ${D}${sysconfdir}/rcS.d/
-	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

(quoted diff) +0 -1
-	ln -sf ../init.d/debugfs.sh

${D}${sysconfdir}/rcS.d/S09debugfs

(quoted diff) +2 -0
+	install -d ${D}${sysconfdir}/init.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

Just a nitpick but there is no need to specify debugfs.sh in the destination path. Also, most init scripts don't bother with the .sh extension. BTW, using "defaults" for update-rc.d will put this script in run levels 2345. If you want it in rcS then you need to change your INITSCRIPT_PARAMS setting. Do a man of update-rc.d to find out how that utility works.

Learning on update-rc.d in general is beneficial for you and your future recipes, so you may want to allocate some "training" time for that.

And for now the quickest approach would be to just copy the usage from initscript-telnetd - it is after all a very similar initscript...

Signature · 1 line
Denys
#7 lore raw
In reply to Maupin, Chase
Quoted 27 lines · Chase
Quoted 6 lines

-----Original Message-----
From: Zhou, Jingting
Sent: Thursday, May 02, 2013 4:34 PM
To: Maupin, Chase; [email protected]
Subject: RE: [meta-arago] [PATCH] added mounting debugfs recipe

Quoted 6 lines

Don't want to create another email thread using git send-email. So I just copy-pasted the subsequent patch here. I can resend it using git send-email if you want.

Had a quick look at update-rc.d.bbclass. But I didn't figure out how to use it.

Check out meta-arago/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb

Quoted 12 lines
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb index c9cb7d0..eaf316a 100755
--- a/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb
+++ b/meta-arago-extras/recipes-bsp/initscript- debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript-debugfs/initscript-debugfs.bb +0 -0
@@ -1,11 +1,12 @@
 DESCRIPTION = "Initscripts for debugfs"
 LICENSE = "BSD"
 
Quoted 7 lines
Quoted 4 lines
(quoted diff) +0 -1
-LIC_FILES_CHKSUM =

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32" +LIC_FILES_CHKSUM = "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"

You should either add the license in the .sh text file or point to the one that already exists in OE-Core. No need to make your own copy.

Again, check initscript-telnetd for both - how to use update-rc.d and also how to handle license info at the top of your shell script.

If you would rather want to use one of the standard license files, point to it like this:

LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"

In this case it's using standard GPLv2 license text, but it's probably better to have own instance of COPYING as required by GPL...

Signature · 1 line
Denys
#8 lore raw
In reply to Zhou, Jingting
Quoted 3 lines · Jingting

Don't want to create another email thread using git send-email. So I just copy-pasted the subsequent patch here. I can resend it using git send-email if you want.

Actually, you don't do subsequent patches fixing comments in the original patch - i.e. no patch on top of a patch. Please update the original patch with the fixes and re-send it again. Make sure you mark it as [PATCHv2] or v3 etc. and also put a log of changes against the previous submission after --- line. Here's an example of version 3 of a patch:
http://arago-project.org/pipermail/meta-arago/2013-April/001265.html

Quoted 2 lines

Had a quick look at update-rc.d.bbclass. But I didn't figure out how to use it.

initscript-telnet in meta-arago-distro/recipe-connectivity is a good example.

Signature · 1 line
Denys
#9 lore raw
In reply to Maupin, Chase

Jingting,

I know there's already a thread going on, I just wanted to follow up on some of the previous comments from Chase to explain and/or correct, since it's still new to you and you may need some more details. Please see inline.

Quoted 9 lines · Chase
Quoted 9 lines
(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
index 46db7c2..ba618b2 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-base-tisdk-server-extra.bb

Quoted 8 lines

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb RDEPENDS_${PN} = "\ · line 69

Quoted 6 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb +1 -1
@@ -66,7 +66,7 @@ RDEPENDS_${PN} = "\
     ptpd \
     vsftpd \
     syslog-ng \
-	syslog-ng-plugins \
+    syslog-ng-plugins \

This looks like a mistake. Either in the other patch or this one.

In other words - this fix should be rolled into the previous patch (that is still under review), and not piggy-backing on the new patch, that has nothing to do with syslog.

Quoted 11 lines

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb RDEPENDS_${PN} = "\ · line 98

Quoted 8 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk-server-extra.bb +1 -0
     dtc \
     strongswan \
     strongswan-plugins \
@@ -95,4 +95,5 @@ RDEPENDS_${PN} = "\
     ti-netapi \
     ti-ipc \
     ebtables \
+    initscript-debugfs \

Usually this should be split into apatch that adds the recipe and one that adds it to the packagegroup.

While this one is not really so critical, it's still better to have the first patch adding new functionality and the second patch to enable that functionality in the system - #1 adds initscript-debugfs.bb and #2 enables it in the packagegroup.

Quoted 11 lines
Quoted 11 lines
(quoted diff) +0 -0

debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes- bsp/initscript-debugfs/initscript-debugfs.bb
new file mode 100755
index 0000000..c9cb7d0

meta-arago-extras/recipes-bsp/initscript- new file +0 -0

debugfs/initscript-debugfs.bb

meta-arago-extras/recipes-bsp/initscript- new file +2 -0
@@ -0,0 +1,17 @@
+DESCRIPTION = "Initscripts for debugfs"
+LICENSE = "BSD"
Quoted 8 lines
Quoted 3 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+LIC_FILES_CHKSUM =

"file://debugfs.sh;md5=ecbae24c97c0fa80c5977bf22eec1f32"

This file does not have a real license header in it. If you are going to point here you should put the license header in it or use the license file from the core layer. And I wouldn't do the whole script because then you have to update this for every script change.

IF and only if you have a license info at the top of your source file (.sh or .c or .h), then you would point to that file AND also specify beginline=# and endline=# in there to limit the checksum to those lines only. Like Chase said, that way you don't need to update checksum with every fix you make to the code.

Quoted 4 lines

meta-arago-extras/recipes-bsp/initscript-

Quoted 2 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+
+PR ="r1"

Why not start at r0?

I personally don't have preference here. If you put r0, then another person would start argue that you don't need to set it to r0, as that's the default and you can drop the line altogether. I prefer to have it from the beginning, so you won't forget to update it on the next change.

Quoted 7 lines
Quoted 7 lines
meta-arago-extras/recipes-bsp/initscript- new file +7 -0
+
+SRC_URI = "file://debugfs.sh"
+
+S = "${WORKDIR}"
+
+do_install () {
+	install -d ${D}${sysconfdir}/init.d/
Quoted 8 lines
Quoted 6 lines
meta-arago-extras/recipes-bsp/initscript- new file +2 -0
+	install -d ${D}${sysconfdir}/rcS.d/
+	install -c -m 755 ${WORKDIR}/debugfs.sh

${D}${sysconfdir}/init.d/debugfs.sh

meta-arago-extras/recipes-bsp/initscript- new file +1 -0
+	ln -sf ../init.d/debugfs.sh

${D}${sysconfdir}/rcS.d/S09debugfs
+}

Use the update-rc.d class instead. Life will be better this way.

Indeed.

Signature · 1 line
Denys