Skip to contentSkip to conversation

iio: adc: exynos_adc: use devm_ioremap_resource()

PATCH In review Laurent Navet 2 participants 2 messages May 2, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: exynos_adc: use devm_ioremap_resource()

Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.

Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.

---
 drivers/iio/adc/exynos_adc.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/iio/adc/exynos_adc.c +6 -6
index 9f3a8ef..22d034a 100644
@@ -270,16 +270,16 @@ static int exynos_adc_probe(struct platform_device *pdev)
 	info = iio_priv(indio_dev);
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_request_and_ioremap(&pdev->dev, mem);
-	if (!info->regs) {
-		ret = -ENOMEM;
+	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	if (IS_ERR(info->regs)) {
+		ret = PTR_ERR(info->regs);
 		goto err_iio;
 	}
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-	info->enable_reg = devm_request_and_ioremap(&pdev->dev, mem);
-	if (!info->enable_reg) {
-		ret = -ENOMEM;
+	info->enable_reg = devm_ioremap_resource(&pdev->dev, mem);
+	if (IS_ERR(info->enable_reg)) {
+		ret = PTR_ERR(info->enable_reg);
 		goto err_iio;
 	}
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 6 lines · Laurent Navet

Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.

Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.

Hello Laurent,

But, we already have patch from Sachin
http://patches.linaro.org/15833/
lined up for merge.

Thanks for the post.
Naveen

Quoted 34 lines
---
 drivers/iio/adc/exynos_adc.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/iio/adc/exynos_adc.c +6 -7
index 9f3a8ef..22d034a 100644
@@ -270,16 +270,16 @@ static int exynos_adc_probe(struct platform_device *pdev)
        info = iio_priv(indio_dev);
 
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       info->regs = devm_request_and_ioremap(&pdev->dev, mem);
-       if (!info->regs) {
-               ret = -ENOMEM;
+       info->regs = devm_ioremap_resource(&pdev->dev, mem);
+       if (IS_ERR(info->regs)) {
+               ret = PTR_ERR(info->regs);
                goto err_iio;
        }
 
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       info->enable_reg = devm_request_and_ioremap(&pdev->dev, mem);
-       if (!info->enable_reg) {
-               ret = -ENOMEM;
+       info->enable_reg = devm_ioremap_resource(&pdev->dev, mem);
+       if (IS_ERR(info->enable_reg)) {
+               ret = PTR_ERR(info->enable_reg);
                goto err_iio;
        }
 
--

1.7.10.4

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Shine bright,
(: Nav :)