regulator: Remove all platform_set_drvdata(pdev, NULL) in drivers
Subsystems (3)
PATCH 1/1 regulator: Remove all platform_set_drvdata(pdev, NULL) in drivers
Since 0998d06310 "device-core: Ensure drvdata = NULL when no driver is bound", this is done by driver core after device_release or on probe failure. Thus we can remove all platform_set_drvdata(pdev, NULL) in drivers.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/88pm8607.c | 1 - drivers/regulator/lp8788-buck.c | 1 - drivers/regulator/lp8788-ldo.c | 2 -- drivers/regulator/max8925-regulator.c | 1 - drivers/regulator/mc13783-regulator.c | 2 -- drivers/regulator/mc13892-regulator.c | 2 -- drivers/regulator/pcap-regulator.c | 1 - drivers/regulator/pcf50633-regulator.c | 1 - drivers/regulator/tps65217-regulator.c | 2 -- drivers/regulator/virtual.c | 2 -- drivers/regulator/wm831x-dcdc.c | 7 ------- drivers/regulator/wm831x-isink.c | 2 -- drivers/regulator/wm831x-ldo.c | 2 -- drivers/regulator/wm8400-regulator.c | 1 - drivers/regulator/wm8994-regulator.c | 2 -- 15 files changed, 29 deletions(-)
drivers/regulator/88pm8607.c +0 -1
@@ -406,7 +406,6 @@ static int pm8607_regulator_remove(struct platform_device *pdev) {struct pm8607_regulator_info *info =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (info->regulator);return 0 ; }
drivers/regulator/lp8788-buck.c +0 -1
@@ -533,7 +533,6 @@ static int lp8788_buck_remove(struct platform_device *pdev) {struct lp8788_buck *buck =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (buck->regulator);return 0 ;
drivers/regulator/lp8788-ldo.c +0 -2
@@ -561,7 +561,6 @@ static int lp8788_dldo_remove(struct platform_device *pdev) {struct lp8788_ldo *ldo =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (ldo->regulator);return 0 ;
@@ -622,7 +621,6 @@ static int lp8788_aldo_remove(struct platform_device *pdev) {struct lp8788_ldo *ldo =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (ldo->regulator);return 0 ;
drivers/regulator/max8925-regulator.c +0 -1
@@ -327,7 +327,6 @@ static int max8925_regulator_remove(struct platform_device *pdev) {struct regulator_dev *rdev =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (rdev);return 0 ;
drivers/regulator/mc13783-regulator.c +0 -2
@@ -466,8 +466,6 @@ static int mc13783_regulator_remove(struct platform_device *pdev)struct mc13xxx_regulator_priv *priv =platform_get_drvdata (pdev);int i; -platform_set_drvdata (pdev,NULL ); -for (i =0 ; i < priv->num_regulators; i++)regulator_unregister (priv->regulators[i]);
drivers/regulator/mc13892-regulator.c +0 -2
@@ -636,8 +636,6 @@ static int mc13892_regulator_remove(struct platform_device *pdev)struct mc13xxx_regulator_priv *priv =platform_get_drvdata (pdev);int i; -platform_set_drvdata (pdev,NULL ); -for (i =0 ; i < priv->num_regulators; i++)regulator_unregister (priv->regulators[i]);
drivers/regulator/pcap-regulator.c +0 -1
@@ -260,7 +260,6 @@ static int pcap_regulator_remove(struct platform_device *pdev)struct regulator_dev *rdev =platform_get_drvdata (pdev);regulator_unregister (rdev); -platform_set_drvdata (pdev,NULL );return 0 ; }
drivers/regulator/pcf50633-regulator.c +0 -1
@@ -106,7 +106,6 @@ static int pcf50633_regulator_remove(struct platform_device *pdev) {struct regulator_dev *rdev =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (rdev);return 0 ;
drivers/regulator/tps65217-regulator.c +0 -2
@@ -405,8 +405,6 @@ static int tps65217_regulator_remove(struct platform_device *pdev)for (i =0 ; i <TPS65217_NUM_REGULATOR ; i++)regulator_unregister (tps->rdev[i]); -platform_set_drvdata (pdev,NULL ); -return 0 ; }
drivers/regulator/virtual.c +0 -2
@@ -330,8 +330,6 @@ static int regulator_virtual_remove(struct platform_device *pdev)if (drvdata->enabled)regulator_disable (drvdata->regulator); -platform_set_drvdata (pdev,NULL ); -return 0 ; }
drivers/regulator/wm831x-dcdc.c +0 -7
@@ -567,8 +567,6 @@ static int wm831x_buckv_remove(struct platform_device *pdev)struct wm831x_dcdc *dcdc =platform_get_drvdata (pdev);struct wm831x *wm831x = dcdc->wm831x; -platform_set_drvdata (pdev,NULL ); -free_irq (wm831x_irq (wm831x,platform_get_irq_byname (pdev,"HC" )), dcdc); free_irq(wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV")),
@@ -714,8 +712,6 @@ static int wm831x_buckp_remove(struct platform_device *pdev) {struct wm831x_dcdc *dcdc =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL ); -free_irq (wm831x_irq (dcdc->wm831x,platform_get_irq_byname (pdev,"UV" )), dcdc);regulator_unregister (dcdc->regulator);
@@ -849,8 +845,6 @@ static int wm831x_boostp_remove(struct platform_device *pdev) {struct wm831x_dcdc *dcdc =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL ); -free_irq (wm831x_irq (dcdc->wm831x,platform_get_irq_byname (pdev,"UV" )), dcdc);regulator_unregister (dcdc->regulator);
@@ -940,7 +934,6 @@ static int wm831x_epe_remove(struct platform_device *pdev) {struct wm831x_dcdc *dcdc =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (dcdc->regulator);return 0 ;
drivers/regulator/wm831x-isink.c +0 -2
@@ -225,8 +225,6 @@ static int wm831x_isink_remove(struct platform_device *pdev) {struct wm831x_isink *isink =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL ); -free_irq (wm831x_irq (isink->wm831x,platform_get_irq (pdev,0 )), isink);regulator_unregister (isink->regulator);
drivers/regulator/wm831x-ldo.c +0 -2
@@ -338,8 +338,6 @@ static int wm831x_gp_ldo_remove(struct platform_device *pdev) {struct wm831x_ldo *ldo =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL ); -free_irq (wm831x_irq (ldo->wm831x,platform_get_irq_byname (pdev,"UV" )), ldo);regulator_unregister (ldo->regulator);
drivers/regulator/wm8400-regulator.c +0 -1
@@ -250,7 +250,6 @@ static int wm8400_regulator_remove(struct platform_device *pdev) {struct regulator_dev *rdev =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );regulator_unregister (rdev);return 0 ;
drivers/regulator/wm8994-regulator.c +0 -2
@@ -185,8 +185,6 @@ static int wm8994_ldo_remove(struct platform_device *pdev) {struct wm8994_ldo *ldo =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL ); -regulator_unregister (ldo->regulator);return 0 ;
Signature · 1 line
1.8.1.2
Quoted 3 lines · Axel Lin
Since
0998d06310"device-core: Ensure drvdata = NULL when no driver is bound", this is done by driver core afterdevice_releaseor on probe failure. Thus we can remove allplatform_set_drvdata(pdev, NULL)in drivers.
Applied, but note that this is nothing to do with the above commit - it has always been a bug for drivers to rely on drvdata except while bound so any driver that relied on clearing it was buggy.