cifs: only set ops for inodes in I_NEW state
Subsystems (2)
PATCH 1/1 cifs: only set ops for inodes in I_NEW state
It's generally not safe to reset the inode ops once they've been set. In the case where the inode was originally thought to be a directory and then later found to be a DFS referral, this can lead to an oops when we try to trigger an inode op on it after changing the ops to the blank referral operations.
Cc <[email protected]>
Reported-and-Tested-by Sachin Prabhu <[email protected]>
Signed-off-by Jeff Layton <[email protected]>
--- fs/cifs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/cifs/inode.c +2 -1
@@ -171,7 +171,8 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr)if (fattr->cf_flags &CIFS_FATTR_DFS_REFERRAL ) inode->i_flags |=S_AUTOMOUNT ; -cifs_set_ops (inode); +if (inode->i_state &I_NEW ) +cifs_set_ops (inode); }void
Signature · 1 line
1.8.1.4