Skip to contentSkip to conversation

kvm/ppc: interrupt disabling fixes

PATCH Benjamin Herrenschmidt 1 participant 1 message May 7, 2013 1 message not in the archive KVM

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1367953139.3398.28@snotra

#1 lore raw
Quoted 6 lines · Scott Wood

This will have to wait until book3s_hv disables interrupts as well. If this does eventually happen, then the local_irq_enable()/kvmppc_lazy_ee_enable() should also probably go into kvmppc_prepare_to_enter() -- though that could cause problems in book3s_pr, if it's depending on the kvmppc_lazy_ee_enable() happening as late as it does.

Is book3s calling prepare_to_enter at all ? It has its own things with no interrupt disabling which afaik is racy vs. checking for signals & resched...

(CC'ing Paul).

BTW. Linus just pulled my tree which contains my changed to hard_irq_disable() to do the trace_hardirqs_off() when neeed.

Cheers,
Ben.