Skip to contentSkip to conversation

qxl: fix bug with object eviction and update area

PATCH New Dave Airlie 1 participant 1 message May 9, 2013

Subsystems (3)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 qxl: fix bug with object eviction and update area

From: Dave Airlie <[email protected]>

if the surface is evicted, this validation will happen to the wrong place, I noticed this with other work I was doing, haven't seen it go wrong in practice.

---
 drivers/gpu/drm/qxl/qxl_ioctl.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/qxl/qxl_ioctl.c +1 -0
index 04b64f9..6db7370 100644
@@ -294,6 +294,7 @@ static int qxl_update_area_ioctl(struct drm_device *dev, void *data,
 		goto out;
 
 	if (!qobj->pin_count) {
+		qxl_ttm_placement_from_domain(qobj, qobj->type);
 		ret = ttm_bo_validate(&qobj->tbo, &qobj->placement,
 				      true, false);
 		if (unlikely(ret))
Signature · 1 line
1.8.2.1