Skip to contentSkip to conversation

perf record: fix symbol processing bug and greatly improve performance

PATCH In review Waiman Long 4 participants 6 messages May 9, 2013 – Jul 12, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 perf record: fix symbol processing bug and greatly improve performance

When "perf record" was used on a large machine with a lot of CPUs, the perf post-processing time (the time after the workload was done until the perf command itself exited) could take a lot of minutes and even hours depending on how large the resulting perf.data file was.

While running AIM7 1500-user high_systime workload on a 80-core x86-64 system with a 3.9 kernel (with only the -s -a options used), the workload itself took about 2 minutes to run and the perf.data file had a size of 1108.746 MB. However, the post-processing step took more than 10 minutes.

With a gprof-profiled perf binary, the time spent by perf was as follows:

  %   cumulative   self              self     total
 time   seconds   seconds    calls   s/call   s/call  name
 96.90    822.10   822.10   192156     0.00     0.00  dsos__find
  0.81    828.96     6.86 172089958     0.00     0.00  rb_next
  0.41    832.44     3.48 48539289     0.00     0.00  rb_erase

So 97% (822 seconds) of the time was spent in a single dsos_find() function. After analyzing the call-graph data below:

-----------------------------------------------

                0.00  822.12  192156/192156      map__new [6]
[7]     96.9    0.00  822.12  192156         vdso__dso_findnew [7]
              822.10    0.00  192156/192156      dsos__find [8]
                0.01    0.00  192156/192156      dsos__add [62]
                0.01    0.00  192156/192366      dso__new [61]
                0.00    0.00       1/45282525     memdup [31]
                0.00    0.00  192156/192230      dso__set_long_name [91]
-----------------------------------------------
              822.10    0.00  192156/192156      vdso__dso_findnew [7]
[8]     96.9  822.10    0.00  192156         dsos__find [8]

-----------------------------------------------

It was found that the vdso__dso_findnew() function failed to locate VDSO__MAP_NAME ("[vdso]") in the dso list and have to insert a new entry at the end for 192156 times. This problem is due to the fact that there are 2 types of name in the dso entry - short name and long name. The initial dso__new() adds "[vdso]" to both the short and long names. After that, vdso__dso_findnew() modifies the long name to something like /tmp/perf-vdso.so-NoXkDj. The dsos__find() function only compares the long name. As a result, the same vdso entry is duplicated many time in the dso list. This bug increases memory consumption as well as slows the symbol processing time to a crawl.

To resolve this problem, the dsos__find() function interface was modified to enable searching either the long name or the short name. The vdso__dso_findnew() will now search only the short name while the other call sites search for the long name as before.

With this change, the cpu time of perf was reduced from 848.38s to 15.77s and dsos__find() only accounted for 0.06% of the total time.

0.06 15.73 0.01 192151 0.00 0.00 dsos__find

---
 tools/perf/util/dso.c  |   10 ++++++++--
 tools/perf/util/dso.h  |    3 ++-
 tools/perf/util/vdso.c |    2 +-
 3 files changed, 11 insertions(+), 4 deletions(-)
tools/perf/util/dso.c +8 -2
index 6f7d5a9..3d80f92 100644
@@ -513,10 +513,16 @@ void dsos__add(struct list_head *head, struct dso *dso)
 	list_add_tail(&dso->node, head);
 }
 
-struct dso *dsos__find(struct list_head *head, const char *name)
+struct dso *dsos__find(struct list_head *head, const char *name, bool cmp_short)
 {
 	struct dso *pos;
 
+	if (cmp_short) {
+		list_for_each_entry(pos, head, node)
+			if (strcmp(pos->short_name, name) == 0)
+				return pos;
+		return NULL;
+	}
 	list_for_each_entry(pos, head, node)
 		if (strcmp(pos->long_name, name) == 0)
 			return pos;
@@ -525,7 +531,7 @@ struct dso *dsos__find(struct list_head *head, const char *name)
 
 struct dso *__dsos__findnew(struct list_head *head, const char *name)
 {
-	struct dso *dso = dsos__find(head, name);
+	struct dso *dso = dsos__find(head, name, FALSE);
 
 	if (!dso) {
 		dso = dso__new(name);
tools/perf/util/dso.h +2 -1
index 450199a..d51aaf2 100644
@@ -133,7 +133,8 @@ struct dso *dso__kernel_findnew(struct machine *machine, const char *name,
 				const char *short_name, int dso_type);
 
 void dsos__add(struct list_head *head, struct dso *dso);
-struct dso *dsos__find(struct list_head *head, const char *name);
+struct dso *dsos__find(struct list_head *head, const char *name,
+		       bool cmp_short);
 struct dso *__dsos__findnew(struct list_head *head, const char *name);
 bool __dsos__read_build_ids(struct list_head *head, bool with_hits);
 
tools/perf/util/vdso.c +1 -1
index e60951f..a8fd73d 100644
@@ -91,7 +91,7 @@ void vdso__exit(void)
 
 struct dso *vdso__dso_findnew(struct list_head *head)
 {
-	struct dso *dso = dsos__find(head, VDSO__MAP_NAME);
+	struct dso *dso = dsos__find(head, VDSO__MAP_NAME, TRUE);
 
 	if (!dso) {
 		char *file;
Signature · 1 line
1.7.1
Acked-by on v2 1/1
#1 lore raw
Quoted 55 lines · Waiman Long

When "perf record" was used on a large machine with a lot of CPUs, the perf post-processing time (the time after the workload was done until the perf command itself exited) could take a lot of minutes and even hours depending on how large the resulting perf.data file was.

While running AIM7 1500-user high_systime workload on a 80-core x86-64 system with a 3.9 kernel (with only the -s -a options used), the workload itself took about 2 minutes to run and the perf.data file had a size of 1108.746 MB. However, the post-processing step took more than 10 minutes.

With a gprof-profiled perf binary, the time spent by perf was as follows:

  %   cumulative   self              self     total
 time   seconds   seconds    calls   s/call   s/call  name
 96.90    822.10   822.10   192156     0.00     0.00  dsos__find
  0.81    828.96     6.86 172089958     0.00     0.00  rb_next
  0.41    832.44     3.48 48539289     0.00     0.00  rb_erase

So 97% (822 seconds) of the time was spent in a single dsos_find() function. After analyzing the call-graph data below:

-----------------------------------------------

                0.00  822.12  192156/192156      map__new [6]
[7]     96.9    0.00  822.12  192156         vdso__dso_findnew [7]
              822.10    0.00  192156/192156      dsos__find [8]
                0.01    0.00  192156/192156      dsos__add [62]
                0.01    0.00  192156/192366      dso__new [61]
                0.00    0.00       1/45282525     memdup [31]
                0.00    0.00  192156/192230      dso__set_long_name [91]
-----------------------------------------------
              822.10    0.00  192156/192156      vdso__dso_findnew [7]
[8]     96.9  822.10    0.00  192156         dsos__find [8]

-----------------------------------------------

It was found that the vdso__dso_findnew() function failed to locate VDSO__MAP_NAME ("[vdso]") in the dso list and have to insert a new entry at the end for 192156 times. This problem is due to the fact that there are 2 types of name in the dso entry - short name and long name. The initial dso__new() adds "[vdso]" to both the short and long names. After that, vdso__dso_findnew() modifies the long name to something like /tmp/perf-vdso.so-NoXkDj. The dsos__find() function only compares the long name. As a result, the same vdso entry is duplicated many time in the dso list. This bug increases memory consumption as well as slows the symbol processing time to a crawl.

To resolve this problem, the dsos__find() function interface was modified to enable searching either the long name or the short name. The vdso__dso_findnew() will now search only the short name while the other call sites search for the long name as before.

With this change, the cpu time of perf was reduced from 848.38s to 15.77s and dsos__find() only accounted for 0.06% of the total time.

Quoted 8 lines

0.06 15.73 0.01 192151 0.00 0.00 dsos__find

---
 tools/perf/util/dso.c  |   10 ++++++++--
 tools/perf/util/dso.h  |    3 ++-
 tools/perf/util/vdso.c |    2 +-
 3 files changed, 11 insertions(+), 4 deletions(-)

Thanks,

Ingo

#2 lore raw
Quoted 65 lines · Ingo Molnar
Quoted 55 lines · Waiman Long

When "perf record" was used on a large machine with a lot of CPUs, the perf post-processing time (the time after the workload was done until the perf command itself exited) could take a lot of minutes and even hours depending on how large the resulting perf.data file was.

While running AIM7 1500-user high_systime workload on a 80-core x86-64 system with a 3.9 kernel (with only the -s -a options used), the workload itself took about 2 minutes to run and the perf.data file had a size of 1108.746 MB. However, the post-processing step took more than 10 minutes.

With a gprof-profiled perf binary, the time spent by perf was as follows:

   %   cumulative   self              self     total
  time   seconds   seconds    calls   s/call   s/call  name
  96.90    822.10   822.10   192156     0.00     0.00  dsos__find
   0.81    828.96     6.86 172089958     0.00     0.00  rb_next
   0.41    832.44     3.48 48539289     0.00     0.00  rb_erase

So 97% (822 seconds) of the time was spent in a single dsos_find() function. After analyzing the call-graph data below:

-----------------------------------------------

                 0.00  822.12  192156/192156      map__new [6]
[7]     96.9    0.00  822.12  192156         vdso__dso_findnew [7]
               822.10    0.00  192156/192156      dsos__find [8]
                 0.01    0.00  192156/192156      dsos__add [62]
                 0.01    0.00  192156/192366      dso__new [61]
                 0.00    0.00       1/45282525     memdup [31]
                 0.00    0.00  192156/192230      dso__set_long_name [91]
-----------------------------------------------
               822.10    0.00  192156/192156      vdso__dso_findnew [7]

[8] 96.9 822.10 0.00 192156 dsos__find [8]
-----------------------------------------------

It was found that the vdso__dso_findnew() function failed to locate VDSO__MAP_NAME ("[vdso]") in the dso list and have to insert a new entry at the end for 192156 times. This problem is due to the fact that there are 2 types of name in the dso entry - short name and long name. The initial dso__new() adds "[vdso]" to both the short and long names. After that, vdso__dso_findnew() modifies the long name to something like /tmp/perf-vdso.so-NoXkDj. The dsos__find() function only compares the long name. As a result, the same vdso entry is duplicated many time in the dso list. This bug increases memory consumption as well as slows the symbol processing time to a crawl.

To resolve this problem, the dsos__find() function interface was modified to enable searching either the long name or the short name. The vdso__dso_findnew() will now search only the short name while the other call sites search for the long name as before.

With this change, the cpu time of perf was reduced from 848.38s to 15.77s and dsos__find() only accounted for 0.06% of the total time.

Quoted 8 lines
   0.06     15.73     0.01   192151     0.00     0.00  dsos__find
---
  tools/perf/util/dso.c  |   10 ++++++++--
  tools/perf/util/dso.h  |    3 ++-
  tools/perf/util/vdso.c |    2 +-
  3 files changed, 11 insertions(+), 4 deletions(-)
Quoted 5 lines

Thanks,

Ingo

Thank for the Ack. Will that patch go into v3.11?

Regards,
Longman

#3 lore raw

Em Fri, Jul 05, 2013 at 01:09:17PM -0400, Waiman Long escreveu:

Quoted 7 lines · Ingo Molnar
Quoted 4 lines · Waiman Long
Quoted 2 lines
 3 files changed, 11 insertions(+), 4 deletions(-)

Thank for the Ack. Will that patch go into v3.11?

I'm back at processing patches, I'm putting everything on the perf/core branch and afterwards will go thru the queue looking for pure bug fixex to put on perf/urgent and send to Ingo.

- Arnaldo

#4 lore raw
Quoted 11 lines · Arnaldo Carvalho de Melo

Em Fri, Jul 05, 2013 at 01:09:17PM -0400, Waiman Long escreveu:

Quoted 5 lines · Ingo Molnar
Quoted 3 lines · Waiman Long
Quoted 1 line
  3 files changed, 11 insertions(+), 4 deletions(-)

Thank for the Ack. Will that patch go into v3.11?

I'm back at processing patches, I'm putting everything on the perf/core branch and afterwards will go thru the queue looking for pure bug fixex to put on perf/urgent and send to Ingo.

- Arnaldo

Thank for the clarification. I would really like to see it merged as I don't want to manually merge it every time when I build the perf binary with the latest kernel source.

Regards,
Longman

#5 lore raw

[tip:perf/urgent] perf symbols: Fix vdso list searching

In reply to Waiman Long
perf symbols: Fix vdso list searching
Commit-ID:  f9ceffb605be7b3b3b2a6e6d14dd0d7a97eae580
Gitweb:     http://git.kernel.org/tip/f9ceffb605be7b3b3b2a6e6d14dd0d7a97eae580
Author:     Waiman Long <[email protected]>
AuthorDate: Thu, 9 May 2013 10:42:48 -0400
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 8 Jul 2013 17:59:07 -0300

perf symbols: Fix vdso list searching

When "perf record" was used on a large machine with a lot of CPUs, the perf post-processing time (the time after the workload was done until the perf command itself exited) could take a lot of minutes and even hours depending on how large the resulting perf.data file was.

While running AIM7 1500-user high_systime workload on a 80-core x86-64 system with a 3.9 kernel (with only the -s -a options used), the workload itself took about 2 minutes to run and the perf.data file had a size of 1108.746 MB. However, the post-processing step took more than 10 minutes.

With a gprof-profiled perf binary, the time spent by perf was as follows:

  %   cumulative   self              self     total
 time   seconds   seconds    calls   s/call   s/call  name
 96.90    822.10   822.10   192156     0.00     0.00  dsos__find
  0.81    828.96     6.86 172089958     0.00     0.00  rb_next
  0.41    832.44     3.48 48539289     0.00     0.00  rb_erase

So 97% (822 seconds) of the time was spent in a single dsos_find() function. After analyzing the call-graph data below:

-----------------------------------------------

                 0.00  822.12  192156/192156      map__new [6]
 [7]     96.9    0.00  822.12  192156         vdso__dso_findnew [7]
               822.10    0.00  192156/192156      dsos__find [8]
                 0.01    0.00  192156/192156      dsos__add [62]
                 0.01    0.00  192156/192366      dso__new [61]
                 0.00    0.00       1/45282525     memdup [31]
                 0.00    0.00  192156/192230      dso__set_long_name [91]
 -----------------------------------------------
               822.10    0.00  192156/192156      vdso__dso_findnew [7]
 [8]     96.9  822.10    0.00  192156         dsos__find [8]

-----------------------------------------------

It was found that the vdso__dso_findnew() function failed to locate VDSO__MAP_NAME ("[vdso]") in the dso list and have to insert a new entry at the end for 192156 times. This problem is due to the fact that there are 2 types of name in the dso entry - short name and long name. The initial dso__new() adds "[vdso]" to both the short and long names. After that, vdso__dso_findnew() modifies the long name to something like /tmp/perf-vdso.so-NoXkDj. The dsos__find() function only compares the long name. As a result, the same vdso entry is duplicated many time in the dso list. This bug increases memory consumption as well as slows the symbol processing time to a crawl.

To resolve this problem, the dsos__find() function interface was modified to enable searching either the long name or the short name. The vdso__dso_findnew() will now search only the short name while the other call sites search for the long name as before.

With this change, the cpu time of perf was reduced from 848.38s to 15.77s and dsos__find() only accounted for 0.06% of the total time.

0.06 15.73 0.01 192151 0.00 0.00 dsos__find

Cc "Chandramouleeswaran, Aswin" <[email protected]>
Cc "Norton, Scott J" <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>

[ replaced TRUE/FALSE with stdbool.h equivalents, fixing builds where
those macros are not present (NO_LIBPYTHON=1 NO_LIBPERL=1), fix from Jiri Olsa ]

---
 tools/perf/util/dso.c  | 10 ++++++++--
 tools/perf/util/dso.h  |  3 ++-
 tools/perf/util/vdso.c |  2 +-
 3 files changed, 11 insertions(+), 4 deletions(-)
tools/perf/util/dso.c +8 -2
index 6f7d5a9..c4374f0 100644
@@ -513,10 +513,16 @@ void dsos__add(struct list_head *head, struct dso *dso)
 	list_add_tail(&dso->node, head);
 }
 
-struct dso *dsos__find(struct list_head *head, const char *name)
+struct dso *dsos__find(struct list_head *head, const char *name, bool cmp_short)
 {
 	struct dso *pos;
 
+	if (cmp_short) {
+		list_for_each_entry(pos, head, node)
+			if (strcmp(pos->short_name, name) == 0)
+				return pos;
+		return NULL;
+	}
 	list_for_each_entry(pos, head, node)
 		if (strcmp(pos->long_name, name) == 0)
 			return pos;
@@ -525,7 +531,7 @@ struct dso *dsos__find(struct list_head *head, const char *name)
 
 struct dso *__dsos__findnew(struct list_head *head, const char *name)
 {
-	struct dso *dso = dsos__find(head, name);
+	struct dso *dso = dsos__find(head, name, false);
 
 	if (!dso) {
 		dso = dso__new(name);
tools/perf/util/dso.h +2 -1
index 450199a..d51aaf2 100644
@@ -133,7 +133,8 @@ struct dso *dso__kernel_findnew(struct machine *machine, const char *name,
 				const char *short_name, int dso_type);
 
 void dsos__add(struct list_head *head, struct dso *dso);
-struct dso *dsos__find(struct list_head *head, const char *name);
+struct dso *dsos__find(struct list_head *head, const char *name,
+		       bool cmp_short);
 struct dso *__dsos__findnew(struct list_head *head, const char *name);
 bool __dsos__read_build_ids(struct list_head *head, bool with_hits);
 
tools/perf/util/vdso.c +1 -1
index e60951f..3915982 100644
@@ -91,7 +91,7 @@ void vdso__exit(void)
 
 struct dso *vdso__dso_findnew(struct list_head *head)
 {
-	struct dso *dso = dsos__find(head, VDSO__MAP_NAME);
+	struct dso *dso = dsos__find(head, VDSO__MAP_NAME, true);
 
 	if (!dso) {
 		char *file;