Skip to contentSkip to conversation

ppc: do not register IABR SPR twice for 603e

PATCH Applied Hervé Poussineau 4 participants 7 messages May 11, 2013 – Jun 18, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc: do not register IABR SPR twice for 603e

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

---
 target-ppc/translate_init.c |    5 -----
 1 file changed, 5 deletions(-)
target-ppc/translate_init.c +0 -5
index 6feb62a..248d3e0 100644
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
                  SPR_NOACCESS, SPR_NOACCESS,
                  &spr_read_generic, &spr_write_generic,
                  0x00000000);
-    /* XXX : not implemented */
-    spr_register(env, SPR_IABR, "IABR",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
     /* Memory management */
     gen_low_BATs(env);
     gen_6xx_7xx_soft_tlb(env, 64, 2);
Signature · 1 line
1.7.10.4
#1 lore raw

Ping.
This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e

Hervé

Quoted 23 lines · Hervé Poussineau

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

---
 target-ppc/translate_init.c |    5 -----
 1 file changed, 5 deletions(-)
target-ppc/translate_init.c +0 -5
index 6feb62a..248d3e0 100644
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
                  SPR_NOACCESS, SPR_NOACCESS,
                  &spr_read_generic, &spr_write_generic,
                  0x00000000);
-    /* XXX : not implemented */
-    spr_register(env, SPR_IABR, "IABR",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
     /* Memory management */
     gen_low_BATs(env);
     gen_6xx_7xx_soft_tlb(env, 64, 2);
#2 lore raw
Quoted 3 lines · Hervé Poussineau

Ping.
This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e

Ping^2. Looking to pull this in for 1.5.1

Quoted 29 lines

Hervé

Quoted 23 lines · Hervé Poussineau

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

---
target-ppc/translate_init.c | 5 -----

1 file changed, 5 deletions(-)
target-ppc/translate_init.c +0 -5
index 6feb62a..248d3e0 100644
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
                 SPR_NOACCESS, SPR_NOACCESS,
                 &spr_read_generic, &spr_write_generic,
                 0x00000000);
-    /* XXX : not implemented */
-    spr_register(env, SPR_IABR, "IABR",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
    /* Memory management */
    gen_low_BATs(env);
    gen_6xx_7xx_soft_tlb(env, 64, 2);
#3 lore raw
Quoted 6 lines · mdroth
Quoted 3 lines · Hervé Poussineau

Ping.
This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e

Ping^2. Looking to pull this in for 1.5.1

Ping^3

Quoted 29 lines
Quoted 28 lines

Hervé

Quoted 23 lines · Hervé Poussineau

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

---
target-ppc/translate_init.c | 5 -----

1 file changed, 5 deletions(-)
target-ppc/translate_init.c +0 -5
index 6feb62a..248d3e0 100644
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
                 SPR_NOACCESS, SPR_NOACCESS,
                 &spr_read_generic, &spr_write_generic,
                 0x00000000);
-    /* XXX : not implemented */
-    spr_register(env, SPR_IABR, "IABR",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
    /* Memory management */
    gen_low_BATs(env);
    gen_6xx_7xx_soft_tlb(env, 64, 2);
#4 lore raw
In reply to mdroth
Quoted 6 lines · mdroth
Quoted 3 lines · Hervé Poussineau

Ping.
This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e

Ping^2. Looking to pull this in for 1.5.1

Ping^3

Quoted 26 lines
Quoted 25 lines
Quoted 23 lines · Hervé Poussineau

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

---
target-ppc/translate_init.c | 5 -----

1 file changed, 5 deletions(-)
target-ppc/translate_init.c +0 -5
index 6feb62a..248d3e0 100644
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
                 SPR_NOACCESS, SPR_NOACCESS,
                 &spr_read_generic, &spr_write_generic,
                 0x00000000);
-    /* XXX : not implemented */
-    spr_register(env, SPR_IABR, "IABR",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
    /* Memory management */
    gen_low_BATs(env);
    gen_6xx_7xx_soft_tlb(env, 64, 2);
Reviewed-by on v1 1/1
#5 lore raw
In reply to Hervé Poussineau

Am 11.05.2013 21:03, schrieb Hervé Poussineau:

Quoted 3 lines

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

Confirmed,

Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
#6 lore raw
In reply to Hervé Poussineau
Quoted 3 lines · Hervé Poussineau

IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().

Thanks, applied to ppc-next. Sorry for the long delay - I was on vacation :)

Alex

Quoted 23 lines

---
target-ppc/translate_init.c | 5 -----

1 file changed, 5 deletions(-)
target-ppc/translate_init.c +0 -5
index 6feb62a..248d3e0 100644
@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
                 SPR_NOACCESS, SPR_NOACCESS,
                 &spr_read_generic, &spr_write_generic,
                 0x00000000);
-    /* XXX : not implemented */
-    spr_register(env, SPR_IABR, "IABR",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, &spr_write_generic,
-                 0x00000000);
    /* Memory management */
    gen_low_BATs(env);
    gen_6xx_7xx_soft_tlb(env, 64, 2);
Signature · 1 line
1.7.10.4