Skip to contentSkip to conversation

pam: Add libtirpc to build dependencies

PATCH In review Khem Raj 4 participants 7 messages May 14, 2013

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 pam: Add libtirpc to build dependencies

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---
 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/pam/libpam_1.1.6.bb +1 -1
index c355634..581f687 100644
@@ -23,7 +23,7 @@ SRC_URI[sha256sum] = "bab887d6280f47fc3963df3b95735a27a16f0f663636163ddf3acab5f1
 
 SRC_URI_append_libc-uclibc = " file://pam-no-innetgr.patch"
 
-DEPENDS = "bison flex flex-native cracklib"
+DEPENDS = "bison flex flex-native cracklib libtirpc"
 
 EXTRA_OECONF = "--with-db-uniquename=_pam \
                 --includedir=${includedir}/security \
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 8 lines · Khem Raj

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---
 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What is the benefit of this dependency?

Cheers,

Richard

author
#2 lore raw
Quoted 11 lines · RicharPurdie
Quoted 8 lines · Khem Raj

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---
 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What is the benefit of this dependency?

When building from sstate the build of libpam would fail during configure if the machine who populated sstate had libtirpc staged before building libpam and with high parallelism its quite often

Quoted 6 lines

Cheers,

Richard

#3 lore raw
Quoted 10 lines · On Tuesday 14 May 2013 07:33:49 Khem Raj wrote:
Quoted 8 lines · RicharPurdie
Quoted 7 lines · Khem Raj

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What is the benefit of this dependency?

When building from sstate the build of libpam would fail during configure if the machine who populated sstate had libtirpc staged before building libpam and with high parallelism its quite often

Understood, but the question was what is the benefit of the added dependency on libtirpc; i.e. should we really be explicitly enabling this or explicitly disabling it?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#4 lore raw
Quoted 2 lines · Paul Eggleton
Quoted 1 line · On Tuesday 14 May 2013 07:33:49 Khem Raj wrote:

On Tuesday, May 14, 2013, RicharPurdie <

[email protected]>

Quoted 12 lines
Quoted 12 lines
Quoted 11 lines · wrote:
Quoted 9 lines · Khem Raj

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---

 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

What is the benefit of this dependency?

When building from sstate the build of libpam would fail during configure if the machine who populated sstate had libtirpc staged before building libpam and with high parallelism its quite often

Understood, but the question was what is the benefit of the added

dependency on

Quoted 2 lines

libtirpc; i.e. should we really be explicitly enabling this or explicitly disabling it?

There is no knob to disable/disable it. Adding one would be ideal but for another day

Quoted 9 lines

Cheers,
Paul

--

Paul Eggleton
Intel Open Source Technology Centre

#5 lore raw
In reply to Khem Raj
Quoted 14 lines · Khem Raj
Quoted 10 lines · RicharPurdie
Quoted 8 lines · Khem Raj

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---
 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines
Quoted 1 line

What is the benefit of this dependency?

When building from sstate the build of libpam would fail during configure if the machine who populated sstate had libtirpc staged before building libpam and with high parallelism its quite often

Does this mean that every image which uses pam will also drag in tirpc? What's the cost in space and time for that?

p.

author
#6 lore raw
Quoted 15 lines · Phil Blundell
Quoted 14 lines · Khem Raj
Quoted 10 lines · RicharPurdie
Quoted 8 lines · Khem Raj

libtirpc is looked for by configure and if found its enabled. So lets make it consistent and enable it always

---
meta/recipes-extended/pam/libpam_1.1.6.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

What is the benefit of this dependency?

When building from sstate the build of libpam would fail during configure if the machine who populated sstate had libtirpc staged before building libpam and with high parallelism its quite often

Does this mean that every image which uses pam will also drag in tirpc?

yes.

Quoted 2 lines

What's the cost in space and time for that?

142K - libtirpc.so.1.0.10

Time I can't quantify, depends on your build system e.g. on my system built from scratch with and without dependency showed few (20+) seconds difference. It might vary for you.

Quoted 3 lines

p.