x86 platform drivers: fix gpio leak
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 3/3 x86 platform drivers: fix gpio leak
when request_irq faild, we should release gpiochip
Signed-off-by Libo Chen <[email protected]>
--- drivers/platform/x86/intel_pmic_gpio.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c
drivers/platform/x86/intel_pmic_gpio.c +4 -1
@@ -288,7 +288,7 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev) retval =request_irq (pg->irq, pmic_irq_handler,0 ,"pmic" , pg);if (retval) {pr_warn ("Interrupt request failed\n" ); - goto err; + goto fail_request_irq; }for (i =0 ; i <8 ; i++) {
@@ -299,6 +299,9 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)irq_set_chip_data (i + pg->irq_base, pg); }return 0 ; + +fail_request_irq: +gpiochip_remove (&pg->chip); err:iounmap (pg->gpiointr); err2:
Signature · 1 line
1.8.1.2