Skip to contentSkip to conversation

patch: diable xattr as default

PATCH In review Saul Wold 2 participants 4 messages May 21, 2013 – May 22, 2013

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 patch: diable xattr as default

There is a optional dependency on xattr (and thus the attr package), disable it by default, to ensure it builds correctly.

---
 meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/patch/patch_2.7.1.bb +2 -0
index 38df034..b131204 100644
@@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
 acpaths = "-I ${S}/m4 "
+
+EXTRA_OECONF += "--disable-xattr"
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 13 lines · Saul Wold

There is a optional dependency on xattr (and thus the attr package), disable it by default, to ensure it builds correctly.

---
  meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
  1 file changed, 2 insertions(+)
meta/recipes-devtools/patch/patch_2.7.1.bb +0 -0
index 38df034..b131204 100644

meta/recipes-devtools/patch/patch_2.7.1.bb SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 · line 13

Quoted 5 lines
meta/recipes-devtools/patch/patch_2.7.1.bb +2 -0
@@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
  acpaths = "-I ${S}/m4 "
+
+EXTRA_OECONF += "--disable-xattr"

There is an xattr distro feature. It would be better to use:

ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr', '--disable-xattr', d)}"

EXTRA_OECONF += "${ENABLE_XATTR}"

(Might need a -native/-nativesdk version?)

Quoted 1 line
#2 lore raw
Quoted 22 lines · Mark Hatle
Quoted 13 lines · Saul Wold

There is a optional dependency on xattr (and thus the attr package), disable it by default, to ensure it builds correctly.

---
   meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
   1 file changed, 2 insertions(+)
meta/recipes-devtools/patch/patch_2.7.1.bb +0 -0
index 38df034..b131204 100644

meta/recipes-devtools/patch/patch_2.7.1.bb SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 · line 13

Quoted 5 lines
meta/recipes-devtools/patch/patch_2.7.1.bb +2 -0
@@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
   acpaths = "-I ${S}/m4 "
+
+EXTRA_OECONF += "--disable-xattr"

There is an xattr distro feature. It would be better to use:

Quoted 6 lines

ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr', '--disable-xattr', d)}"

EXTRA_OECONF += "${ENABLE_XATTR}"

(Might need a -native/-nativesdk version?)

I forgot, PACKAGECONFIG might be better to use.... then the attr package dependencies can more easily be added.

PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}" PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"

--Mark

Quoted 8 lines
Quoted 1 line

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw
Quoted 32 lines · Mark Hatle
Quoted 31 lines · Mark Hatle
Quoted 19 lines · Saul Wold

There is a optional dependency on xattr (and thus the attr package), disable it by default, to ensure it builds correctly.

---
   meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
   1 file changed, 2 insertions(+)
meta/recipes-devtools/patch/patch_2.7.1.bb +0 -0
index 38df034..b131204 100644
@@ -9,3 +9,5 @@ SRC_URI[sha256sum] =

"c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
LIC_FILES_CHKSUM =
"file://COPYING;md5=d32239bcb673463ab874e80d47fae504"

   acpaths = "-I ${S}/m4 "

meta/recipes-devtools/patch/patch_2.7.1.bb SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 · line 13

Quoted 2 lines
meta/recipes-devtools/patch/patch_2.7.1.bb +2 -0
+
+EXTRA_OECONF += "--disable-xattr"

There is an xattr distro feature. It would be better to use:

ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr',
'--disable-xattr', d)}"

EXTRA_OECONF += "${ENABLE_XATTR}"

Quoted 9 lines
Quoted 1 line

(Might need a -native/-nativesdk version?)

I forgot, PACKAGECONFIG might be better to use.... then the attr package dependencies can more easily be added.

PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"

Yup, this is more correct and slap my hand for forgetting the xattr DISTO_FEATURE!

V2 coming after some tests.

Sau!

Quoted 17 lines

--Mark

Quoted 8 lines
Quoted 1 line

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core