Skip to contentSkip to conversation

net-next: export skb_splice_bits()

PATCH In review Michel Machado 2 participants 2 messages May 23, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net-next: export skb_splice_bits()

skb_splice_bits() is already available in include/linux/skbuff.h, but without EXPORT_SYMBOL it can't be used by kernel modules.

CC "David S. Miller" <[email protected]>
CC Eric Dumazet <[email protected]>
CC Pravin B Shelar <[email protected]>

---

net/core/skbuff.c +1 -0
index af9185d..0976908 100644
@@ -1854,6 +1854,7 @@ done:
 
 	return ret;
 }
+EXPORT_SYMBOL(skb_splice_bits);
 
 /**
  *	skb_store_bits - store bits from kernel buffer to skb
maintainer
#1 lore raw

Ummm, no.

You don't export every single function just because it appears in a header file.

When we have an in-kernel module that needs these functions, we can export them, but no sooner.

So until you submit a set of changes that use these routines from modules we're not exporting them.