Skip to contentSkip to conversation

tracing: code cleanup

PATCH In review Harsh Prateek Bora 2 participants 2 messages May 24, 2013 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: code cleanup

---
 kernel/trace/trace_events.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
kernel/trace/trace_events.c +1 -4
index 7a0cf68..371c7b0 100644
@@ -2011,10 +2011,7 @@ event_enable_func(struct ftrace_hash *hash,
 	int ret;
 
 	/* hash funcs only work with set_ftrace_filter */
-	if (!enabled)
-		return -EINVAL;
-
-	if (!param)
+	if (!enabled || !param)
 		return -EINVAL;
 
 	system = strsep(&param, ":");
Signature · 1 line
1.7.11.7
maintainer
#1 lore raw
Quoted 11 lines · Harsh Prateek Bora
---
 kernel/trace/trace_events.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
kernel/trace/trace_events.c +0 -0
index 7a0cf68..371c7b0 100644
@@ -2011,10 +2011,7 @@ event_enable_func(struct ftrace_hash *hash,
 	int ret;

kernel/trace/trace_events.c event_enable_func(struct ftrace_hash *hash, · line 2017

Quoted 10 lines
kernel/trace/trace_events.c +1 -4
 
 	/* hash funcs only work with set_ftrace_filter */
-	if (!enabled)
-		return -EINVAL;
-
-	if (!param)
+	if (!enabled || !param)
 		return -EINVAL;
 
 	system = strsep(&param, ":");

Thanks, I added it to my 3.11 queue.

-- Steve