Skip to contentSkip to conversation

Yocto SDK IDE cleanup

PATCH In review Ioana Grigoropol 2 participants 4 messages May 24, 2013

lore
Share & tools
lore
#0 lore raw

v3 cover Yocto SDK IDE cleanup

- org.yocto.sdk.ide clean up - remove unused classes

Ioana Grigoropol (2):
Remove unused TCFTerminalConnectors
Remove all plugin dependencies to RSE APi from remote tools plugin

 .../org.yocto.sdk.remotetools/META-INF/MANIFEST.MF |   10 +-
 .../remotetools/views/TCFTerminalConnector.java    |   49 ----------
 .../views/TCFTerminalConnectorImpl.java            |   98 --------------------
 3 files changed, 4 insertions(+), 153 deletions(-)
 delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnector.java
 delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnectorImpl.java
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v3 1/2 Remove unused TCFTerminalConnectors

- removed TCFTerminalConnector and TCFTerminalConnectorImpl since there are no usages of this classes

---
 .../remotetools/views/TCFTerminalConnector.java    |   49 ----------
 .../views/TCFTerminalConnectorImpl.java            |   98 --------------------
 2 files changed, 147 deletions(-)
 delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnector.java
 delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnectorImpl.java
plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnector.java deleted +0 -49
deleted file mode 100644
index 6239136..0000000
@@ -1,49 +0,0 @@
-/********************************************************************************
- * Copyright (c) 2008, 2009 MontaVista Software, Inc. and others
- * This program and the accompanying materials are made available under the terms
- * of the Eclipse Public License v1.0 which accompanies this distribution, and is
- * available at http://www.eclipse.org/legal/epl-v10.html
- *
- * Contributors:
- * Anna Dushistova (MontaVista) - initial API and implementation
- * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point
- ********************************************************************************/
-package org.yocto.sdk.remotetools.views;
-
-import org.eclipse.core.runtime.Platform;
-import org.eclipse.rse.core.model.IHost;
-import org.eclipse.tm.internal.terminal.provisional.api.ITerminalConnector;
-
-public class TCFTerminalConnector extends TCFTerminalConnectorImpl implements ITerminalConnector {
-
-    public TCFTerminalConnector(IHost host) {
-		super(host);
-    }
-
-    public String getId() {
-        return "yocto_tcf_internal_connector"; //$NON-NLS-1$
-    }
-
-    public String getInitializationErrorMessage() {
-        return null;
-    }
-
-    public String getName() {
-        return "yocto_tcf_internal_connector";
-    }
-
-    public boolean isHidden() {
-    	return true;
-    }
-
-    public boolean isInitialized() {
-        return true;
-    }
-
-	public Object getAdapter(Class adapterType) {
-		if (adapterType.isInstance(this))
-			return this;
-		return Platform.getAdapterManager().getAdapter(this, adapterType);
-	}
-
-}
plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnectorImpl.java deleted +0 -98

98 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v3 2/2 Remove all plugin dependencies to RSE APi from remote tools plugin

In reply to Ioana Grigoropol

- removed all plugin dependencies to the RSE API & kept only the ones needed for GUI actions and Terminal views

---
 .../org.yocto.sdk.remotetools/META-INF/MANIFEST.MF |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
plugins/org.yocto.sdk.remotetools/META-INF/MANIFEST.MF +4 -6
index c34ad9e..5147c1a 100644
@@ -7,16 +7,10 @@ Bundle-Activator: org.yocto.sdk.remotetools.Activator
 Require-Bundle: org.eclipse.ui,
  org.eclipse.core.runtime,
  org.eclipse.rse.core;bundle-version="3.0.0",
- org.eclipse.rse.services;bundle-version="3.0.0",
- org.eclipse.rse.subsystems.files.core;bundle-version="3.0.0",
- org.eclipse.rse.ui;bundle-version="3.0.0",
  org.yocto.sdk.ide,
- org.eclipse.tm.terminal;bundle-version="3.0.1",
- org.eclipse.rse.subsystems.terminals.core;bundle-version="[1.0.0,2.0.0)",
  org.eclipse.rse.terminals.ui;bundle-version="1.0.100",
  org.eclipse.cdt;bundle-version="7.0.0",
  org.eclipse.linuxtools.tmf.core;bundle-version="0.4.0",
- org.eclipse.rse.subsystems.shells.core,
  org.eclipse.ui.ide;bundle-version="3.8.0",
  org.eclipse.ui.console;bundle-version="3.5.100"
 Bundle-ActivationPolicy: lazy
@@ -24,6 +18,10 @@ Bundle-RequiredExecutionEnvironment: JavaSE-1.6
 Import-Package: org.eclipse.core.resources,
  org.eclipse.debug.internal.ui,
  org.eclipse.rse.shells.ui,
+ org.eclipse.rse.ui.actions,
+ org.eclipse.tm.internal.terminal.control,
+ org.eclipse.tm.internal.terminal.control.actions,
+ org.eclipse.tm.internal.terminal.provisional.api,
  org.eclipse.ui.forms.widgets,
  org.yocto.remote.utils
 Bundle-Vendor: %Bundle-Vendor
Signature · 1 line
1.7.9.5
#3 lore raw
In reply to Ioana Grigoropol

The remote tools related changes are merged to eclipse-poky master plus the following patch:

http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-poky/commit/?id=ff4ccb4d65243f2a28eb89c72e9b425702b6c3aa

For headless build.

Thanks,
Jessica

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Ioana Grigoropol
Sent: Friday, May 24, 2013 1:45 AM
To: [email protected]
Subject: [yocto] [PATCH v3 0/2] Yocto SDK IDE cleanup

- org.yocto.sdk.ide clean up - remove unused classes

Ioana Grigoropol (2):
Remove unused TCFTerminalConnectors
Remove all plugin dependencies to RSE APi from remote tools plugin

 .../org.yocto.sdk.remotetools/META-INF/MANIFEST.MF |   10 +-
 .../remotetools/views/TCFTerminalConnector.java    |   49 ----------
 .../views/TCFTerminalConnectorImpl.java            |   98 --------------------
 3 files changed, 4 insertions(+), 153 deletions(-)  delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnector.java
 delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/views/TCFTerminalConnectorImpl.java

--
1.7.9.5

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto