Skip to contentSkip to conversation

xfstests: cleanup the codes related to h_chksum

PATCH In review [email protected] 4 participants 5 messages May 25, 2013 – May 28, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: cleanup the codes related to h_chksum

From: Zhi Yong Wu <[email protected]>

Since h_chksum field has gone away, we should cleanup the related codes

[CC] loggen
loggen.c: In function 'loggen_unmount':
loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum' loggen.c: In function 'loggen_empty':
loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'

---
 src/loggen.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
src/loggen.c +0 -2
index 4b55667..522c917 100644
@@ -134,7 +134,6 @@ loggen_unmount(int count)
     head->h_cycle = cpu_to_be32(param_cycle);
     head->h_version = cpu_to_be32(1);
     head->h_len = cpu_to_be32(20);
-    head->h_chksum = cpu_to_be32(0);
     head->h_prev_block = cpu_to_be32(-1);
     head->h_num_logops = cpu_to_be32(1);
     head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
@@ -202,7 +201,6 @@ loggen_empty(int count)
                                                     sizeof(xfs_trans_header_t)+
                                                     sizeof(xfs_buf_log_format_t)+
                                                     sizeof(int));
-    head->h_chksum         = cpu_to_be32(0);
     head->h_prev_block     = cpu_to_be32(-1);
     head->h_num_logops     = cpu_to_be32(5);
     head->h_cycle_data[0]  = cpu_to_be32(0xb0c0d0d0);
Signature · 6 lines
1.7.6.5

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#1 lore raw
Quoted 29 lines · On 05/25/2013 07:15 PM, [email protected] wrote:

From: Zhi Yong Wu <[email protected]>

Since h_chksum field has gone away, we should cleanup the related codes

[CC] loggen
loggen.c: In function 'loggen_unmount':
loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum' loggen.c: In function 'loggen_empty':
loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'

---
 src/loggen.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
src/loggen.c +0 -1
index 4b55667..522c917 100644
@@ -134,7 +134,6 @@ loggen_unmount(int count)
     head->h_cycle = cpu_to_be32(param_cycle);
     head->h_version = cpu_to_be32(1);
     head->h_len = cpu_to_be32(20);
-    head->h_chksum = cpu_to_be32(0);
     head->h_prev_block = cpu_to_be32(-1);
     head->h_num_logops = cpu_to_be32(1);
     head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);

src/loggen.c loggen_empty(int count) · line 206

Quoted 7 lines
src/loggen.c +0 -1
@@ -202,7 +201,6 @@ loggen_empty(int count)
                                                     sizeof(xfs_trans_header_t)+
                                                     sizeof(xfs_buf_log_format_t)+
                                                     sizeof(int));
-    head->h_chksum         = cpu_to_be32(0);
     head->h_prev_block     = cpu_to_be32(-1);
     head->h_num_logops     = cpu_to_be32(5);
     head->h_cycle_data[0]  = cpu_to_be32(0xb0c0d0d0);

I've been taking a wild guess and changing "h_chksum" to "h_crc", just as a pure sysadmin hack to keep going. Is there more than one correct answer on this issue?

Michael

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw

HI,

I don't think that this is one hacking, but one formal patch to fix this issue.

Quoted 47 lines · Michael L. Semon
Quoted 28 lines · On 05/25/2013 07:15 PM, [email protected] wrote:

From: Zhi Yong Wu <[email protected]>

Since h_chksum field has gone away, we should cleanup the related codes

[CC] loggen
loggen.c: In function 'loggen_unmount':
loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum' loggen.c: In function 'loggen_empty':
loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'

---
 src/loggen.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
src/loggen.c +0 -1
index 4b55667..522c917 100644
@@ -134,7 +134,6 @@ loggen_unmount(int count)
     head->h_cycle = cpu_to_be32(param_cycle);
     head->h_version = cpu_to_be32(1);
     head->h_len = cpu_to_be32(20);
-    head->h_chksum = cpu_to_be32(0);
     head->h_prev_block = cpu_to_be32(-1);
     head->h_num_logops = cpu_to_be32(1);
     head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);

src/loggen.c loggen_empty(int count) · line 201

Quoted 1 line
src/loggen.c +0 -0
@@ -202,7 +201,6 @@ loggen_empty(int count)
 

sizeof(xfs_trans_header_t)+

Quoted 1 line

sizeof(xfs_buf_log_format_t)+

Quoted 6 lines
                                                     sizeof(int));
-    head->h_chksum         = cpu_to_be32(0);
     head->h_prev_block     = cpu_to_be32(-1);
     head->h_num_logops     = cpu_to_be32(5);
     head->h_cycle_data[0]  = cpu_to_be32(0xb0c0d0d0);

I've been taking a wild guess and changing "h_chksum" to "h_crc", just as a pure sysadmin hack to keep going. Is there more than one correct answer on this issue?

Michael

Signature · 3 lines
Regards,

Zhi Yong Wu

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#3 lore raw
In reply to [email protected]
Quoted 11 lines · On Sun, May 26, 2013 at 07:15:32AM +0800, [email protected] wrote:

From: Zhi Yong Wu <[email protected]>

Since h_chksum field has gone away, we should cleanup the related codes

[CC] loggen
loggen.c: In function 'loggen_unmount':
loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum' loggen.c: In function 'loggen_empty':
loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'

Looks fine.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#4 lore raw
In reply to [email protected]
Quoted 11 lines · On 05/25/2013 06:15 PM, [email protected] wrote:

From: Zhi Yong Wu <[email protected]>

Since h_chksum field has gone away, we should cleanup the related codes

[CC] loggen
loggen.c: In function 'loggen_unmount':
loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum' loggen.c: In function 'loggen_empty':
loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'

Thanks for the patch, it has been committed:

commit f761cd9a6aa9b44be7f3056f01c419edf1356789

Author: Zhi Yong Wu <[email protected]>
Date:   Tue May 28 08:31:52 2013 -0500

xfstests: cleanup the codes related to h_chksum

--Rich

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs