perf: reset SIGTERM handler in workload child process
PATCH 1/1 perf: reset SIGTERM handler in workload child process
Jiri reported hanging perf tests on latest acme's perf/core and bisected it to 87f303a9f:
[jolsa@krava2 perf]$ cat /proc/sys/kernel/perf_event_paranoid 1
[jolsa@krava2 perf]$ ./perf record -C 0 kill
Error:
You may not have permission to collect %sstats. Consider tweaking /proc/sys/kernel/perf_event_paranoid:
-1 - Not paranoid at all
0 - Disallow raw tracepoint access for unpriv
1 - Disallow cpu events for unpriv
2 - Disallow kernel profiling for unpriv
Need to let default handling kickin for workload process.
--- tools/perf/util/evlist.c | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/util/evlist.c +2 -0
@@ -776,6 +776,8 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist,if (pipe_output)dup2 (2 ,1 ); +signal (SIGTERM ,SIG_DFL ); +close (child_ready_pipe[0 ]);close (go_pipe[1 ]);fcntl (go_pipe[0 ],F_SETFD ,FD_CLOEXEC );
Signature · 1 line
1.7.10.1
tip-bot for David Ahern
merge bot[tip:perf/core] perf evlist: Reset SIGTERM handler in workload child process
perf evlist: Reset SIGTERM handler in workload child process
Commit-ID: 0817df08d31cd961be225e601d8ec92acac62027 Gitweb: http://git.kernel.org/tip/0817df08d31cd961be225e601d8ec92acac62027 Author: David Ahern <[email protected]> AuthorDate: Sat, 25 May 2013 17:50:39 -0600 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 30 May 2013 14:34:56 +0300
perf evlist: Reset SIGTERM handler in workload child process
Jiri reported hanging perf tests on latest acme's perf/core and bisected it to 87f303a9f:
[jolsa@krava2 perf]$ cat /proc/sys/kernel/perf_event_paranoid 1
[jolsa@krava2 perf]$ ./perf record -C 0 kill
Error:
You may not have permission to collect %sstats. Consider tweaking /proc/sys/kernel/perf_event_paranoid:
-1 - Not paranoid at all
0 - Disallow raw tracepoint access for unpriv
1 - Disallow cpu events for unpriv
2 - Disallow kernel profiling for unpriv
Need to let default handling kickin for workload process.
--- tools/perf/util/evlist.c | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/util/evlist.c +2 -0
@@ -776,6 +776,8 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist,if (pipe_output)dup2 (2 ,1 ); +signal (SIGTERM ,SIG_DFL ); +close (child_ready_pipe[0 ]);close (go_pipe[1 ]);fcntl (go_pipe[0 ],F_SETFD ,FD_CLOEXEC );