f2fs: return proper error from start_gc_thread
Subsystems (2)
PATCH v2 1/2 f2fs: return proper error from start_gc_thread
From: Namjae Jeon <[email protected]>
when there is an error from kthread_run, then return proper error rather than returning -ENOMEM.
Signed-off-by Namjae Jeon <[email protected]>
Signed-off-by Amit Sahrawat <[email protected]>
--- fs/f2fs/gc.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
fs/f2fs/gc.c +10 -5
@@ -91,23 +91,28 @@ int start_gc_thread(struct f2fs_sb_info *sbi) {struct f2fs_gc_kthread *gc_th;dev_t dev = sbi->sb->s_bdev->bd_dev; +int err =0 ;if (!test_opt (sbi,BG_GC )) -return 0 ; + goto out; gc_th =kmalloc (sizeof (struct f2fs_gc_kthread ),GFP_KERNEL ); -if (!gc_th) -return -ENOMEM ; +if (!gc_th) { + err = -ENOMEM ; + goto out; + } sbi->gc_thread = gc_th;init_waitqueue_head (&sbi->gc_thread->gc_wait_queue_head); sbi->gc_thread->f2fs_gc_task =kthread_run (gc_thread_func, sbi,"f2fs_gc-%u:%u" ,MAJOR (dev),MINOR (dev));if (IS_ERR (gc_th->f2fs_gc_task)) { + err =PTR_ERR (gc_th->f2fs_gc_task);kfree (gc_th); sbi->gc_thread =NULL ; -return -ENOMEM ; } -return 0 ; + +out: +return err; }void stop_gc_thread (struct f2fs_sb_info *sbi)
Signature · 9 lines
1.7.9.5 ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may