perf: save parent pid in thread struct
PATCH 1/2 perf: save parent pid in thread struct
Information is available, so why not save it in case some command wants to use it.
Signed-off-by David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
--- tools/perf/util/thread.c | 4 ++++ tools/perf/util/thread.h | 1 + 2 files changed, 5 insertions(+)
tools/perf/util/thread.c +4 -0
@@ -14,6 +14,7 @@ struct thread *thread__new(pid_t pid)if (self !=NULL ) {map_groups__init (&self->mg); self->pid = pid; + self->ppid =-1 ; self->comm =malloc (32 );if (self->comm)snprintf (self->comm,32 ,":%d" , self->pid);
@@ -82,5 +83,8 @@ int thread__fork(struct thread *self, struct thread *parent)for (i =0 ; i <MAP__NR_TYPES ; ++i)if (map_groups__clone (&self->mg, &parent->mg, i) <0 )return -ENOMEM ; + + self->ppid = parent->pid; +return 0 ; }
tools/perf/util/thread.h +1 -0
@@ -13,6 +13,7 @@ struct thread { };struct map_groups mg;pid_t pid; +pid_t ppid;char shortname[3 ];bool comm_set;char *comm;
Signature · 1 line
1.7.10.1
PATCH 2/2 perf script: add option to dump parent pid
Signed-off-by David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
--- tools/perf/Documentation/perf-script.txt | 2 +- tools/perf/builtin-script.c | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-)
tools/perf/Documentation/perf-script.txt +1 -1
@@ -115,7 +115,7 @@ OPTIONS -f:: --fields:: Comma separated list of fields to print. Options are: - comm, tid, pid, time, cpu, event, trace, ip, sym, dso, addr, symoff. + comm, tid, pid, ppid, time, cpu, event, trace, ip, sym, dso, addr, symoff. Field list can be prepended with the type, trace, sw or hw, to indicate to which event type the field list applies. e.g., -f sw:comm,tid,time,ip,sym and -f trace:time,cpu,trace
tools/perf/builtin-script.c +7 -2
@@ -41,6 +41,7 @@ enum perf_output_field {PERF_OUTPUT_DSO =1U <<9 ,PERF_OUTPUT_ADDR =1U <<10 ,PERF_OUTPUT_SYMOFFSET =1U <<11 , + PERF_OUTPUT_PPID = 1U << 12, }; struct output_option {
@@ -50,6 +51,7 @@ struct output_option { {.str = "comm", .field = PERF_OUTPUT_COMM}, {.str = "tid", .field = PERF_OUTPUT_TID}, {.str = "pid", .field = PERF_OUTPUT_PID}, + {.str = "ppid", .field = PERF_OUTPUT_PPID}, {.str = "time", .field = PERF_OUTPUT_TIME}, {.str = "cpu", .field = PERF_OUTPUT_CPU}, {.str = "event", .field = PERF_OUTPUT_EVNAME},
@@ -208,7 +210,7 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel,return -EINVAL ; } -if ((PRINT_FIELD (PID ) ||PRINT_FIELD (TID )) && +if ((PRINT_FIELD (PID ) ||PRINT_FIELD (TID ) ||PRINT_FIELD (PPID )) &&perf_evsel__check_stype (evsel,PERF_SAMPLE_TID ,"TID" ,PERF_OUTPUT_TID |PERF_OUTPUT_PID ))return -EINVAL ;
@@ -283,6 +285,9 @@ static void print_sample_start(struct perf_sample *sample,else if (PRINT_FIELD (TID ))printf ("%5d " , sample->tid); +if (PRINT_FIELD (PPID )) +printf ("%5d " , thread->ppid); +if (PRINT_FIELD (CPU )) {if (latency_format)printf ("%3d " , sample->cpu);
@@ -1274,7 +1279,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)OPT_CALLBACK ('f' ,"fields" ,NULL ,"str" ,"comma separated output fields prepend with 'type:'. " "Valid types: hw,sw,trace,raw. " -"Fields: comm,tid,pid,time,cpu,event,trace,ip,sym,dso," +"Fields: comm,tid,pid,ppid,time,cpu,event,trace,ip,sym,dso," "addr,symoff" , parse_output_fields),OPT_BOOLEAN ('a' ,"all-cpus" , &system_wide, "system-wide collection from all CPUs"),
Signature · 1 line
1.7.10.1
tip-bot for David Ahern
merge bot[tip:perf/core] perf tools: Save parent pid in thread struct
In reply to David Ahernperf tools: Save parent pid in thread struct
Commit-ID: 70c57efb6118bff7426a6086026a4a8f3bd3c9e3 Gitweb: http://git.kernel.org/tip/70c57efb6118bff7426a6086026a4a8f3bd3c9e3 Author: David Ahern <[email protected]> AuthorDate: Sat, 25 May 2013 22:47:10 -0600 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 28 May 2013 16:24:05 +0300
perf tools: Save parent pid in thread struct
Information is available, so why not save it in case some command wants to use it.
Signed-off-by David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/thread.c | 4 ++++ tools/perf/util/thread.h | 1 + 2 files changed, 5 insertions(+)
tools/perf/util/thread.c +4 -0
@@ -14,6 +14,7 @@ struct thread *thread__new(pid_t pid)if (self !=NULL ) {map_groups__init (&self->mg); self->pid = pid; + self->ppid =-1 ; self->comm =malloc (32 );if (self->comm)snprintf (self->comm,32 ,":%d" , self->pid);
@@ -82,5 +83,8 @@ int thread__fork(struct thread *self, struct thread *parent)for (i =0 ; i <MAP__NR_TYPES ; ++i)if (map_groups__clone (&self->mg, &parent->mg, i) <0 )return -ENOMEM ; + + self->ppid = parent->pid; +return 0 ; }
tools/perf/util/thread.h +1 -0
@@ -13,6 +13,7 @@ struct thread { };struct map_groups mg;pid_t pid; +pid_t ppid;char shortname[3 ];bool comm_set;char *comm;