image.bbclass: depend on gdk-pixbuf-native

PATCH In review Eric Bénard 2 participants 4 messages May 29, 2013 – May 30, 2013

Share & tools

Eric Bénard

author

2013-05-29 21:30 UTC #0 lore raw

PATCH 1/1 image.bbclass: depend on gdk-pixbuf-native

it's using scripts from scripts/postinst-intercepts/ which contain gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native else the host binary will be used and it will try to update the host's cache

[YOCTO #4572]

Signed-off-by Eric Bénard <[email protected]>

---
fix the same problem in dylan

 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/classes/image.bbclass +1 -1

index 04db533..6c16a1a 100644
@@ -10,7 +10,7 @@ inherit gzipnative
 
 LICENSE = "MIT"
 PACKAGES = ""
-DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
+DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
 RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
 RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"

Signature · 1 line

1.8.1.4

Richard Purdie

2013-05-29 21:54 UTC #1 lore raw

Quoted 19 lines · Eric Bénard

it's using scripts from scripts/postinst-intercepts/ which contain gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native else the host binary will be used and it will try to update the host's cache
[YOCTO #4572]
Signed-off-by Eric Bénard <[email protected]>
---
fix the same problem in dylan
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image.bbclass +0 -0
index 04db533..6c16a1a 100644

meta/classes/image.bbclass inherit gzipnative · line 15

Quoted 7 lines

meta/classes/image.bbclass +1 -1

@@ -10,7 +10,7 @@ inherit gzipnative
 
 LICENSE = "MIT"
 PACKAGES = ""
-DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
+DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
 RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
 RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"

Ah, this has made me realise what the real problem is and that there is a better way to fix this. We need to add

DEPENDS += "gdk-pixbuf-native"

to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using those things don't get the dependency added.

Cheers,

Richard

Eric Bénard

author

2013-05-30 07:01 UTC #2 lore raw

Quoted 31 lines · Richard Purdie

Quoted 19 lines · Eric Bénard
it's using scripts from scripts/postinst-intercepts/ which contain gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native else the host binary will be used and it will try to update the host's cache
[YOCTO #4572]
Signed-off-by Eric Bénard <[email protected]>
---
fix the same problem in dylan
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image.bbclass +0 -0
index 04db533..6c16a1a 100644
meta/classes/image.bbclass inherit gzipnative · line 15
Quoted 7 lines
meta/classes/image.bbclass +1 -1
@@ -10,7 +10,7 @@ inherit gzipnative
 
 LICENSE = "MIT"
 PACKAGES = ""
-DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
+DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
 RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
 RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
Ah, this has made me realise what the real problem is and that there is a better way to fix this. We need to add

Quoted 5 lines

DEPENDS += "gdk-pixbuf-native"
to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using those things don't get the dependency added.

I tried on gtk-icon-cache and that didn't work ... seems I missed pixbufcache.bbclass ;-)

Eric

Eric Bénard

author

2013-05-30 07:36 UTC #3 lore raw

Quoted 34 lines · Eric Bénard

Quoted 31 lines · Richard Purdie
Quoted 19 lines · Eric Bénard
it's using scripts from scripts/postinst-intercepts/ which contain gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native else the host binary will be used and it will try to update the host's cache
[YOCTO #4572]
Signed-off-by Eric Bénard <[email protected]>
---
fix the same problem in dylan
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image.bbclass +0 -0
index 04db533..6c16a1a 100644
meta/classes/image.bbclass inherit gzipnative · line 15
Quoted 7 lines
meta/classes/image.bbclass +1 -1
@@ -10,7 +10,7 @@ inherit gzipnative
 
 LICENSE = "MIT"
 PACKAGES = ""
-DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
+DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
 RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
 RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
Ah, this has made me realise what the real problem is and that there is a better way to fix this. We need to add

Quoted 8 lines

Quoted 5 lines
DEPENDS += "gdk-pixbuf-native"
to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using those things don't get the dependency added.
I tried on gtk-icon-cache and that didn't work ... seems I missed pixbufcache.bbclass ;-)

OK that was not the real problem. The real problem is that my image installs hicolor-icon-theme which has :

inherit gnome allarch

DEPENDS = ""

so despite the classes that this recipe inherit have the correct dependencies, it won't have any dependency so if you install this package without any gnome package that will fail ...

Patch is following.

Eric