edac: Add code to handle new MCE signatures for new models of Fam15h
Subsystems (2)
PATCH 1/1 edac: Add code to handle new MCE signatures for new models of Fam15h
There are some newer error signatures in Family 15h models 30h-3fh. Code has been added in the patch to support these new signatures.
Patch has been tested on Fam15h using mce_amd_inj facility and has been verified to work correctly.
--- drivers/edac/mce_amd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/edac/mce_amd.c +3 -2
@@ -134,7 +134,8 @@ static const char * const mc5_mce_desc[] = {"Physical register file AG0 port" ,"Physical register file AG1 port" ,"Flag register file" , - "DE error occurred" +"DE error occurred" , + "Retire Status Queue Parity" };static bool f12h_mc0_mce (u16 ec,u8 xec)
@@ -624,7 +625,7 @@ static void decode_mc5_mce(struct mce *m)if (xec ==0x0 || xec ==0xc )pr_cont ("%s.\n" , mc5_mce_desc[xec]); -else if (xec <0xd ) +else if (xec <=0xd )pr_cont ("%s parity error.\n" , mc5_mce_desc[xec]);else goto wrong_mc5_mce;
Signature · 1 line
1.7.9.5
Borislav Petkov
maintainerQuoted 16 lines · Aravind Gopalakrishnan
There are some newer error signatures in Family 15h models 30h-3fh. Code has been added in the patch to support these new signatures.
Patch has been tested on Fam15h using
mce_amd_injfacility and has been verified to work correctly.Signed-off-by Aravind Gopalakrishnan <[email protected]>--- drivers/edac/mce_amd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/edac/mce_amd.c +0
-0
drivers/edac/mce_amd.c static const char * const mc5_mce_desc[] = { · line 138
Quoted 6 lines
drivers/edac/mce_amd.c +2
-1@@ -134,7 +134,8 @@ static const char * const mc5_mce_desc[] = {"Physical register file AG0 port" ,"Physical register file AG1 port" ,"Flag register file" , -"DE error occurred" +"DE error occurred" , +"Retire Status Queue Parity"
Since "parity error" is already in the printk below, I'm guessing this string should be "Retire status queue" only?
No need to resend the patch, btw - I'll fix it up when applying.
Quoted 12 lines
drivers/edac/mce_amd.c +1
-1};static bool f12h_mc0_mce (u16 ec,u8 xec)@@ -624,7 +625,7 @@ static void decode_mc5_mce(struct mce *m)if (xec ==0x0 || xec ==0xc )pr_cont ("%s.\n" , mc5_mce_desc[xec]); -else if (xec <0xd ) +else if (xec <=0xd )pr_cont ("%s parity error.\n" , mc5_mce_desc[xec]);else goto wrong_mc5_mce;
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Quoted 12 lines · Borislav Petkov
Quoted 11 lines · Aravind Gopalakrishnan
There are some newer error signatures in Family 15h models 30h-3fh. Code has been added in the patch to support these new signatures.
Patch has been tested on Fam15h using
mce_amd_injfacility and has been verified to work correctly.Signed-off-by Aravind Gopalakrishnan <[email protected]>--- drivers/edac/mce_amd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 13 lines
drivers/edac/mce_amd.c static const char * const mc5_mce_desc[] = { · line 138
Quoted 11 lines
drivers/edac/mce_amd.c +2
-1@@ -134,7 +134,8 @@ static const char * const mc5_mce_desc[] = {"Physical register file AG0 port" ,"Physical register file AG1 port" ,"Flag register file" , -"DE error occurred" +"DE error occurred" , +"Retire Status Queue Parity" Since "parity error" is already in the printk below, I'm guessing this string should be "Retire status queue" only?
Okay, that should convey the message too...
Quoted 1 line
No need to resend the patch, btw - I'll fix it up when applying.
Thanks!
Quoted 5 lines
Quoted 5 lines
drivers/edac/mce_amd.c +0
-0};static bool f12h_mc0_mce (u16 ec,u8 xec)@@ -624,7 +625,7 @@ static void decode_mc5_mce(struct mce *m)
Quoted 7 lines
drivers/edac/mce_amd.c static void decode_mc5_mce(struct mce *m) · line 631
Quoted 7 lines
drivers/edac/mce_amd.c +1
-1if (xec ==0x0 || xec ==0xc )pr_cont ("%s.\n" , mc5_mce_desc[xec]); -else if (xec <0xd ) +else if (xec <=0xd )pr_cont ("%s parity error.\n" , mc5_mce_desc[xec]);else goto wrong_mc5_mce;
- Aravind.
Quoted 4 lines · Aravind Gopalakrishnan
Quoted 2 lines
Since "parity error" is already in the printk below, I'm guessing this string should be "Retire status queue" only?
Okay, that should convey the message too...
Applied, thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--