uio: uio_pruss: Fix potential NULL pointer dereference

PATCH New Emil Goode 1 participant 1 message Jun 6, 2013

Subsystems (2)

Kernel janitors Userspace I/O (UIO)

lore

Share & tools

lore

Emil Goode

author

2013-06-06 13:55 UTC #0 lore raw

PATCH 1/1 uio: uio_pruss: Fix potential NULL pointer dereference

In function pruss_probe we free gdev and try to use it on the next line. I have moved the dereference to above the kfree of gdev.

Signed-off-by Emil Goode <[email protected]>

---
 drivers/uio/uio_pruss.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/uio/uio_pruss.c +1 -1

index 6e2ab00..21f7a72 100644
@@ -136,9 +136,9 @@ static int pruss_probe(struct platform_device *dev)
 	gdev->pruss_clk = clk_get(&dev->dev, "pruss");
 	if (IS_ERR(gdev->pruss_clk)) {
 		dev_err(&dev->dev, "Failed to get clock\n");
+		ret = PTR_ERR(gdev->pruss_clk);
 		kfree(gdev->info);
 		kfree(gdev);
-		ret = PTR_ERR(gdev->pruss_clk);
 		return ret;
 	} else {
 		clk_enable(gdev->pruss_clk);

Signature · 1 line

1.7.10.4