Skip to contentSkip to conversation

lspci: Add L1 PM Substate capability reporting

PATCH Superseded David E. Box 2 participants 4 messages Jun 6, 2013 – Jun 11, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 lspci: Add L1 PM Substate capability reporting

From: David Box <[email protected]>

The capabilities are several L1 substates that can enable lower power consumption when a PCIe Link is idle.

v2: fixed white space issues

---
 lib/header.h |    1 +
 ls-ecaps.c   |   53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)
lib/header.h +1 -0
index 69518fd..6608003 100644
@@ -226,6 +226,7 @@
 #define PCI_EXT_CAP_ID_SRIOV	0x10	/* Single Root I/O Virtualization */
 #define PCI_EXT_CAP_ID_TPH	0x17	/* Transaction processing hints */
 #define PCI_EXT_CAP_ID_LTR	0x18	/* Latency Tolerance Reporting */
+#define PCI_EXT_CAP_ID_L1PM	0x1e	/* L1 PM Substates */
 
 /*** Definitions of capabilities ***/
 
ls-ecaps.c +53 -0

65 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#1 lore raw

Hello!

Quoted 4 lines

From: David Box <[email protected]>

The capabilities are several L1 substates that can enable lower power consumption when a PCIe Link is idle.

Looks OK, but please reformat the code to follow coding style of the rest of the file.

Also, could you please send me a test case? Preferably, it should be the output of `lspci -vvxxxx' of some device which reports the capability.

Have a nice fortnight

Signature · 3 lines
Martin `MJ' Mares                          <[email protected]>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
There is no place like ~
#2 lore raw

PATCH v3 1/1 lspci: Add L1 PM Substate capability reporting

From: David Box <[email protected]>

Expose available L1 substate capabilities that can enable lower power consumption when a PCIe Link is idle.

---
v3: reformatted to match document coding style

Sample lspci -vvxxxx output showing first 8 bytes of extended config space for the L1 Substate Capability. Cannot show more since hardware is unreleased:

00:1c.0 PCI bridge:
Capabilities: [200 v1] L1 PM Substates
L1SubCap: PCI-PM_L1.2+, PCI-PM_L1.1+, ASPM_L1.2+, ASPM_L1.1+, L1_PM_Substates+
PortCommonModeRestoreTime=40us, PortTPowerOnTime=10us
200: 1e 00 01 00 1f 28 28 00

 lib/header.h |    1 +
 ls-ecaps.c   |   55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+)
lib/header.h +1 -0
index 69518fd..6608003 100644
@@ -226,6 +226,7 @@
 #define PCI_EXT_CAP_ID_SRIOV	0x10	/* Single Root I/O Virtualization */
 #define PCI_EXT_CAP_ID_TPH	0x17	/* Transaction processing hints */
 #define PCI_EXT_CAP_ID_LTR	0x18	/* Latency Tolerance Reporting */
+#define PCI_EXT_CAP_ID_L1PM	0x1e	/* L1 PM Substates */
 
 /*** Definitions of capabilities ***/
 
ls-ecaps.c +55 -0

67 lines not on this page · raw message

Signature · 1 line
1.7.10.4
Applied
#3 lore raw

Hello!

Quoted 4 lines

From: David Box <[email protected]>

Expose available L1 substate capabilities that can enable lower power consumption when a PCIe Link is idle.

Thanks, applied.

Martin