Skip to contentSkip to conversation

sensors-detect: Drop outdated comment about MAX1617 and LM84 detection

PATCH In review Guenter Roeck 2 participants 2 messages Jun 7, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sensors-detect: Drop outdated comment about MAX1617 and LM84 detection

Drop comment that additional checks for MAX1617 and LM84 are not done in adm1021 driver, as this is no longer correct.

---
 prog/detect/sensors-detect |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
prog/detect/sensors-detect +1 -2
index 19bfe1a..518e5d8 100755
@@ -5534,8 +5534,7 @@ sub adm1021_detect
 
 	# Extra checks for MAX1617 and LM84, since those are often misdetected.
 	# We verify several assertions (6 for the MAX1617, 4 for the LM84) and
-	# discard the chip if any fail. Note that these checks are not done
-	# by the adm1021 driver.
+	# discard the chip if any fail.
 	if ($chip = 2 || $chip = 5) {
 		my $lte = i2c_smbus_read_byte_data($file, 0x00);
 		my $rte = i2c_smbus_read_byte_data($file, 0x01);
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw
Quoted 13 lines · Guenter Roeck

Drop comment that additional checks for MAX1617 and LM84 are not done in adm1021 driver, as this is no longer correct.

---
 prog/detect/sensors-detect |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
prog/detect/sensors-detect +0 -0
index 19bfe1a..518e5d8 100755

prog/detect/sensors-detect sub adm1021_detect · line 5540

Quoted 9 lines
prog/detect/sensors-detect +1 -2
@@ -5534,8 +5534,7 @@ sub adm1021_detect
 
 	# Extra checks for MAX1617 and LM84, since those are often misdetected.
 	# We verify several assertions (6 for the MAX1617, 4 for the LM84) and
-	# discard the chip if any fail. Note that these checks are not done
-	# by the adm1021 driver.
+	# discard the chip if any fail.
 	if ($chip = 2 || $chip = 5) {
 		my $lte = i2c_smbus_read_byte_data($file, 0x00);
 		my $rte = i2c_smbus_read_byte_data($file, 0x01);

Yep, please just commit.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors