drm/i915: Initialize active_outputs to never read unitialized values
Subsystems (2)
PATCH 1/1 drm/i915: Initialize active_outputs to never read unitialized values
In case of intel_sdvo_get_active_outputs() failing, we end up reading a value from the stack.
Signed-off-by Damien Lespiau <[email protected]>
--- drivers/gpu/drm/i915/intel_sdvo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +2 -2
@@ -1277,7 +1277,7 @@ static bool intel_sdvo_connector_get_hw_state(struct intel_connector *connector)struct intel_sdvo_connector *intel_sdvo_connector =to_intel_sdvo_connector (&connector->base);struct intel_sdvo *intel_sdvo =intel_attached_sdvo (&connector->base); -u16 active_outputs; +u16 active_outputs =0 ;intel_sdvo_get_active_outputs (intel_sdvo, &active_outputs);
@@ -1293,7 +1293,7 @@ static bool intel_sdvo_get_hw_state(struct intel_encoder *encoder,struct drm_device *dev = encoder->base.dev;struct drm_i915_private *dev_priv = dev->dev_private;struct intel_sdvo *intel_sdvo =to_intel_sdvo (&encoder->base); -u16 active_outputs; +u16 active_outputs =0 ;u32 tmp; tmp =I915_READ (intel_sdvo->sdvo_reg);
Signature · 1 line
1.8.1.4
Daniel Vetter
AppliedQuoted 4 lines · Damien Lespiau
In case of
intel_sdvo_get_active_outputs()failing, we end up reading a value from the stack.Signed-off-by Damien Lespiau <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch