spi: armada100_spi: Remove unnecessary NULL test for dout and din
PATCH 1/1 spi: armada100_spi: Remove unnecessary NULL test for dout and din
--- drivers/spi/armada100_spi.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
drivers/spi/armada100_spi.c +2 -9
@@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, goto done; } -if (dout) - pss->tx = dout; -else - pss->tx =NULL ; - -if (din) - pss->rx = din; -else - pss->rx =NULL ; + pss->tx = dout; + pss->rx = din;if (flags &SPI_XFER_BEGIN ) {spi_cs_activate (slave);
Signature · 1 line
1.8.1.2
PATCH 1/1 spi: armada100_spi: Remove unnecessary NULL test for dout and din
Quoted 2 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>
Quoted 33 lines
--- drivers/spi/armada100_spi.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)drivers/spi/armada100_spi.c +2
-9@@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, goto done; } -if (dout) - pss->tx = dout; -else - pss->tx =NULL ; - -if (din) - pss->rx = din; -else - pss->rx =NULL ; + pss->tx = dout; + pss->rx = din;if (flags &SPI_XFER_BEGIN ) {spi_cs_activate(slave);--
1.8.1.2
PATCH 1/1 spi: armada100_spi: Remove unnecessary NULL test for dout and din
Dear Simon Glass,
Quoted 4 lines · Axel Lin
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>Reviewed-by Simon Glass <[email protected]>
Best regards,
Marek Vasut
PATCH 1/1 spi: armada100_spi: Remove unnecessary NULL test for dout and din
Quoted 10 lines · ----- "Marek Vasut
Dear Simon Glass,
Quoted 1 line
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin <[email protected]>
Quoted 3 lines · wrote:
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>Reviewed-by Simon Glass <[email protected]>Reviewed-by Marek Vasut <[email protected]>
Regards,
Ajay Bhargav
---------------------------------------------------------------------------------------------
Notice:
This message has been scanned by Trend Micro Mail Security scanner and is believed to be clean
---------------------------------------------------------------------------------------------
PATCH 1/1 spi: armada100_spi: Remove unnecessary NULL test for dout and din
Quoted 15 lines · Ajay Bhargav
Quoted 10 lines · ----- "Marek Vasut
Dear Simon Glass,
Quoted 1 line
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin <[email protected]>
Quoted 3 lines · wrote:
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>Reviewed-by Simon Glass <[email protected]>Reviewed-by Marek Vasut <[email protected]>Acked-by Ajay Bhargav <[email protected]>
Quoted 8 lines
Regards,
Ajay Bhargav---------------------------------------------------------------------------------------------
Notice:
This message has been scanned by Trend Micro Mail Security scanner and is believed to be clean
---------------------------------------------------------------------------------------------
--
Thanks,
Jagan.
Quoted 22 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>Reviewed-by Marek Vasut <[email protected]>Acked-by Ajay Bhargav <[email protected]>Reviewed-by Jagannadha Sutradharudu Teki <[email protected]>---
drivers/spi/armada100_spi.c| 11 ++---------1 file changed, 2 insertions(+), 9 deletions(-)drivers/spi/armada100_spi.c +0
-4@@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, goto done; } -if (dout) - pss->tx = dout; -else - pss->tx =NULL ;
drivers/spi/armada100_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, · line 189
Quoted 10 lines
drivers/spi/armada100_spi.c +2
-5- -if (din) - pss->rx = din; -else - pss->rx =NULL ; + pss->tx = dout; + pss->rx = din;if (flags &SPI_XFER_BEGIN ) {spi_cs_activate (slave);
Applied to u-boot-spi/master
--
Thanks,
Jagan.