drm/i915: Fix VLV PLL LPF coefficients for DAC
Subsystems (2)
PATCH 1/1 drm/i915: Fix VLV PLL LPF coefficients for DAC
From: Ville Syrjälä <[email protected]>
The current PLL settings produce a rather unstable picture when I hook up a VLV to my HP ZR24w display via a VGA cable.
According to some docs, we should use the the same LPF coefficients for DAC as we do for HDMI and RBR DP. And indeed that seems to cure the shivers.
---
With this the hybrid PLL mode patch can be dropped.
drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_display.c +1 -0
@@ -4405,6 +4405,7 @@ static void vlv_update_pll(struct intel_crtc *crtc)/* Set HBR and RBR LPF coefficients */ if (crtc->config.port_clock ==162000 || +intel_pipe_has_type (&crtc->base,INTEL_OUTPUT_ANALOG ) ||intel_pipe_has_type (&crtc->base,INTEL_OUTPUT_HDMI ))vlv_dpio_write (dev_priv,DPIO_LFP_COEFF (pipe),0x005f0021 );
Signature · 6 lines
1.8.1.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 21 lines · On Thu, 13 Jun 2013 18:37:35 +0300 [email protected] wrote:
From: Ville Syrjälä <[email protected]>
The current PLL settings produce a rather unstable picture when I hook up a VLV to my HP ZR24w display via a VGA cable.
According to some docs, we should use the the same LPF coefficients for DAC as we do for HDMI and RBR DP. And indeed that seems to cure the shivers.
Signed-off-by Ville Syrjälä <[email protected]>---
With this the hybrid PLL mode patch can be dropped.drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_display.c +0
-0
drivers/gpu/drm/i915/intel_display.c static void vlv_update_pll(struct intel_crtc *crtc) · line 4411
Quoted 7 lines
drivers/gpu/drm/i915/intel_display.c +1
-0@@ -4405,6 +4405,7 @@ static void vlv_update_pll(struct intel_crtc *crtc)/* Set HBR and RBR LPF coefficients */ if (crtc->config.port_clock ==162000 || +intel_pipe_has_type (&crtc->base,INTEL_OUTPUT_ANALOG ) ||intel_pipe_has_type (&crtc->base,INTEL_OUTPUT_HDMI ))vlv_dpio_write (dev_priv,DPIO_LFP_COEFF (pipe),0x005f0021 );
I think it's ok, but can you specify the doc title in the commit message? Should make things easier to find in the rat's nest of files later. :)
Signature · 5 lines
Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx