batman-adv: (style) fix for switched vid-ifiindex parameter order
PATCH v2 1/1 batman-adv: (style) fix for switched vid-ifiindex parameter order
batadv_tt_local_add() first takes the vid and then the interface index parameter. One of these calls had the order switched.
However in this case it is not a functional, but just a style fix because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.
Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042 ("batman-adv: add the VLAN ID attribute to the TT entry")
---
v2: Added "Introduced by..." to commit message
main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
main.c +1 -1
@@ -128,7 +128,7 @@ int batadv_mesh_init(struct net_device *soft_iface) goto err;batadv_tt_local_add (soft_iface, soft_iface->dev_addr, -BATADV_NULL_IFINDEX ,BATADV_NO_FLAGS ); +BATADV_NO_FLAGS ,BATADV_NULL_IFINDEX ); ret =batadv_bla_init (bat_priv);if (ret <0 )
Signature · 1 line
1.7.10.4
Marek Lindner
AppliedQuoted 9 lines · On Saturday, June 15, 2013 02:04:09 Linus Lüssing wrote:
batadv_tt_local_add()first takes the vid and then the interface index parameter. One of these calls had the order switched.However in this case it is not a functional, but just a style fix because at the moment
BATADV_NO_FLAGSis equal toBATADV_NULL_IFINDEX.Introduced by
580d7919f19e4f73ccd79e82a532af2bdc638042("batman-adv: add the VLAN ID attribute to the TT entry")
Quoted 7 lines
Signed-off-by Linus Lüssing <[email protected]>---
v2: Added "Introduced by..." to commit messagemain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision cc14598.
Thanks,
Marek