dma: mmp_tdma: disable irq when disabling dma channel
PATCH v2 1/1 dma: mmp_tdma: disable irq when disabling dma channel
V2 -> V1:
1, mask dma interrupt when disable DMA channel.
2, remove patch v1.
if the dma channel is disabled without interrupt masked, the interrupt status may still be set. next time when dma channel is enabled again, the old interrupt status may trigger the interrupt wrongly. we need to mask the interrupt when dma channel is disabled.
Qiao Zhou (1):
dma: mmp_tdma: disable irq when disabling dma channel
drivers/dma/mmp_tdma.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
PATCH v2 1/1 dma: mmp_tdma: disable irq when disabling dma channel
mask dma irq when disabling dma channel, so that interrupt status will not be set and interrupt won't come again.
--- drivers/dma/mmp_tdma.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/dma/mmp_tdma.c +4 -0
@@ -154,6 +154,10 @@ static void mmp_tdma_disable_chan(struct mmp_tdma_chan *tdmac) {writel (readl (tdmac->reg_base +TDCR ) & ~TDCR_CHANEN , tdmac->reg_base +TDCR ); + +/* disable irq */ +writel (0 , tdmac->reg_base +TDIMR ); + tdmac->status =DMA_SUCCESS ; }
Signature · 1 line
1.7.0.4
Quoted 4 lines · Qiao Zhou
mask dma irq when disabling dma channel, so that interrupt status will not be set and interrupt won't come again.
Signed-off-by Qiao Zhou <[email protected]>
Vinod Koul
AppliedQuoted 4 lines · Qiao Zhou
mask dma irq when disabling dma channel, so that interrupt status will not be set and interrupt won't come again.
Signed-off-by Qiao Zhou <[email protected]>
Applied, thanks
--
~Vinod
Quoted 22 lines
--- drivers/dma/mmp_tdma.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)drivers/dma/mmp_tdma.c +4
-0@@ -154,6 +154,10 @@ static void mmp_tdma_disable_chan(struct mmp_tdma_chan *tdmac) {writel (readl (tdmac->reg_base +TDCR ) & ~TDCR_CHANEN , tdmac->reg_base +TDCR ); + +/* disable irq */ +writel (0 , tdmac->reg_base +TDIMR ); + tdmac->status =DMA_SUCCESS ; }Signature · 1 line
1.7.0.4