Skip to contentSkip to conversation

gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code

PATCH New Axel Lin 2 participants 2 messages Jun 15, 2013 – Jun 25, 2013 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code

Call s5p_gpio_set_value() to avoid code duplication.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/s5p_gpio.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/gpio/s5p_gpio.c +1 -8
index 656bf4a..4efb768 100644
@@ -48,15 +48,8 @@ void s5p_gpio_cfg_pin(struct s5p_gpio_bank *bank, int gpio, int cfg)
 
 void s5p_gpio_direction_output(struct s5p_gpio_bank *bank, int gpio, int en)
 {
-	unsigned int value;
-
 	s5p_gpio_cfg_pin(bank, gpio, GPIO_OUTPUT);
-
-	value = readl(&bank->dat);
-	value &= ~DAT_MASK(gpio);
-	if (en)
-		value |= DAT_SET(gpio);
-	writel(value, &bank->dat);
+	s5p_gpio_set_value(bank, gpio, en);
 }
 
 void s5p_gpio_direction_input(struct s5p_gpio_bank *bank, int gpio)
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 gpio: s5p_gpio: Call s5p_gpio_set_value() instead of open-code

Quoted 19 lines · Axel Lin

Call s5p_gpio_set_value() to avoid code duplication.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/s5p_gpio.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/gpio/s5p_gpio.c +0 -2
index 656bf4a..4efb768 100644
@@ -48,15 +48,8 @@ void s5p_gpio_cfg_pin(struct s5p_gpio_bank *bank, int gpio, int cfg)
 
 void s5p_gpio_direction_output(struct s5p_gpio_bank *bank, int gpio, int en)
 {
-	unsigned int value;
-
 	s5p_gpio_cfg_pin(bank, gpio, GPIO_OUTPUT);

drivers/gpio/s5p_gpio.c void s5p_gpio_cfg_pin(struct s5p_gpio_bank *bank, int gpio, int cfg) · line 55

Quoted 10 lines
drivers/gpio/s5p_gpio.c +1 -6
-
-	value = readl(&bank->dat);
-	value &= ~DAT_MASK(gpio);
-	if (en)
-		value |= DAT_SET(gpio);
-	writel(value, &bank->dat);
+	s5p_gpio_set_value(bank, gpio, en);
 }
 
 void s5p_gpio_direction_input(struct s5p_gpio_bank *bank, int gpio)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.