Skip to contentSkip to conversation

do not hardcode color in gfxterm

PATCH In review Andrey Borzenkov 2 participants 2 messages Jun 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 do not hardcode color in gfxterm

gfxterm was using hardcoded color on intialization. So first colors were set in normal to white/black and then gfxterm was loaded and set colors to light-gray/black.

Make sure gfxterm is using current colors during initialization.

---
 ChangeLog                | 5 +++++
 grub-core/term/gfxterm.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
ChangeLog +5 -0
index e71a848..33de282 100644
@@ -1,3 +1,8 @@
+2013-06-16  Andrey Borzenkov <[email protected]>
+
+	* grub-core/term/gfxterm.c (grub_virtual_screen_setup): Use
+	grub_term_normal_color, do not hardcode GRUB_TERM_DEFAULT_NORMAL_COLOR.
+
 2013-06-16  Vladimir Serbinenko  <[email protected]>
 
 	Fix casts when compiling coreboot-specific code for 64-bit EFI.
grub-core/term/gfxterm.c +1 -1
index b1d0707..7e00678 100644
@@ -249,7 +249,7 @@ grub_virtual_screen_setup (unsigned int x, unsigned int y,
 
   virtual_screen.standard_color_setting = DEFAULT_STANDARD_COLOR;
 
-  virtual_screen.term_color = GRUB_TERM_DEFAULT_NORMAL_COLOR;
+  virtual_screen.term_color = grub_term_normal_color;
 
   set_term_color (virtual_screen.term_color);
 
Signature · 1 line
tg: (0ed37fc..) u/highlight_after_more (depends on: master)
#1 lore raw
Quoted 6 lines · Andrey Borzenkov

gfxterm was using hardcoded color on intialization. So first colors were set in normal to white/black and then gfxterm was loaded and set colors to light-gray/black.

Make sure gfxterm is using current colors during initialization.

Go ahead.

Quoted 34 lines
---
 ChangeLog                | 5 +++++
 grub-core/term/gfxterm.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
ChangeLog +5 -0
index e71a848..33de282 100644
@@ -1,3 +1,8 @@
+2013-06-16  Andrey Borzenkov <[email protected]>
+
+	* grub-core/term/gfxterm.c (grub_virtual_screen_setup): Use
+	grub_term_normal_color, do not hardcode GRUB_TERM_DEFAULT_NORMAL_COLOR.
+
 2013-06-16  Vladimir Serbinenko  <[email protected]>
 
 	Fix casts when compiling coreboot-specific code for 64-bit EFI.
grub-core/term/gfxterm.c +1 -1
index b1d0707..7e00678 100644
@@ -249,7 +249,7 @@ grub_virtual_screen_setup (unsigned int x, unsigned int y,
 
   virtual_screen.standard_color_setting = DEFAULT_STANDARD_COLOR;
 
-  virtual_screen.term_color = GRUB_TERM_DEFAULT_NORMAL_COLOR;
+  virtual_screen.term_color = grub_term_normal_color;
 
   set_term_color (virtual_screen.term_color);