Skip to contentSkip to conversation

utility-tasks: Add recideptask flag for fetchall/checkuriall

PATCH In review Richard Purdie 2 participants 3 messages Jun 19, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 utility-tasks: Add recideptask flag for fetchall/checkuriall

See the bitbake commit adding the recideptask flag for details of the problem but in summary, we weren't seeing the [depends] of tasks like do_rootfs being taking into account for fetchall. This was leading to not all sources being fetched and this is the OE-Core part of the fix for this problem.

BB_DEFAULT_TASK is the default task used since this is the one that most commands would end up targeting and is how users expect the command to behave.

[YOCTO #4597]

---

meta/classes/prexport.bbclass +1 -1
index 16c4bf2..5a1cb33 100644
@@ -55,4 +55,4 @@ python prexport_handler () {
 }
 
 addhandler prexport_handler
-prexport_handler bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
+prexport_handler[eventmask] = "bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
meta/classes/utility-tasks.bbclass +2 -0
index bb26eb7..507e0f1 100644
@@ -48,6 +48,7 @@ python do_checkuri() {
 
 addtask checkuriall after do_checkuri
 do_checkuriall[recrdeptask] = "do_checkuriall do_checkuri"
+do_checkuriall[recideptask] = "do_${BB_DEFAULT_TASK}"
 do_checkuriall[nostamp] = "1"
 do_checkuriall() {
 	:
@@ -55,6 +56,7 @@ do_checkuriall() {
 
 addtask fetchall after do_fetch
 do_fetchall[recrdeptask] = "do_fetchall do_fetch"
+do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}"
 do_fetchall() {
 	:
 }
#1 lore raw
Quoted 37 lines · Richard Purdie

See the bitbake commit adding the recideptask flag for details of the problem but in summary, we weren't seeing the [depends] of tasks like do_rootfs being taking into account for fetchall. This was leading to not all sources being fetched and this is the OE-Core part of the fix for this problem.

BB_DEFAULT_TASK is the default task used since this is the one that most commands would end up targeting and is how users expect the command to behave.

[YOCTO #4597]

---

meta/classes/prexport.bbclass +1 -1
index 16c4bf2..5a1cb33 100644
@@ -55,4 +55,4 @@ python prexport_handler () {
  }
 
  addhandler prexport_handler
-prexport_handler bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
+prexport_handler[eventmask] = "bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
meta/classes/utility-tasks.bbclass +1 -0
index bb26eb7..507e0f1 100644
@@ -48,6 +48,7 @@ python do_checkuri() {
 
  addtask checkuriall after do_checkuri
  do_checkuriall[recrdeptask] = "do_checkuriall do_checkuri"
+do_checkuriall[recideptask] = "do_${BB_DEFAULT_TASK}"
  do_checkuriall[nostamp] = "1"
  do_checkuriall() {
  	:

meta/classes/utility-tasks.bbclass do_checkuriall() { · line 59

Quoted 4 lines
meta/classes/utility-tasks.bbclass +1 -0
@@ -55,6 +56,7 @@ do_checkuriall() {
 
  addtask fetchall after do_fetch
  do_fetchall[recrdeptask] = "do_fetchall do_fetch"
+do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}"

Would this change be needed in some of the distrodata tasks also? Mostly they operate on world or universe and not images, but I could see someone trying to get that info for a given image.

Sau!

Quoted 11 lines
meta/classes/utility-tasks.bbclass +0 -0
  do_fetchall() {
  	:
  }

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 18 lines · Saul Wold
Quoted 17 lines · Richard Purdie

addhandler prexport_handler

meta/classes/prexport.bbclass +1 -1
-prexport_handler bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
+prexport_handler[eventmask] = "bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
meta/classes/utility-tasks.bbclass +1 -0
index bb26eb7..507e0f1 100644
@@ -48,6 +48,7 @@ python do_checkuri() {
 
  addtask checkuriall after do_checkuri
  do_checkuriall[recrdeptask] = "do_checkuriall do_checkuri"
+do_checkuriall[recideptask] = "do_${BB_DEFAULT_TASK}"
  do_checkuriall[nostamp] = "1"
  do_checkuriall() {
  	:
@@ -55,6 +56,7 @@ do_checkuriall() {
 
Quoted 7 lines

meta/classes/utility-tasks.bbclass do_checkuriall() { · line 59

Quoted 3 lines
meta/classes/utility-tasks.bbclass +1 -0
  addtask fetchall after do_fetch
  do_fetchall[recrdeptask] = "do_fetchall do_fetch"
+do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}"

Would this change be needed in some of the distrodata tasks also? Mostly they operate on world or universe and not images, but I could see someone trying to get that info for a given image.

Possibly, yes.

Cheers,

Richard