Skip to contentSkip to conversation

saa7134: Fix sparse warnings by adding __user annotation

PATCH New Emil Goode 1 participant 1 message Jun 22, 2013

Subsystems (3)
lore
Share & tools
lore

Emil Goode

author
#0 lore raw

PATCH 1/1 saa7134: Fix sparse warnings by adding __user annotation

Adding a __user annotation fixes the following sparse warnings.

drivers/media/pci/saa7134/saa7134-video.c:1578:45: warning:
incorrect type in initializer (different address spaces) drivers/media/pci/saa7134/saa7134-video.c:1578:45:
expected struct v4l2_clip *clips drivers/media/pci/saa7134/saa7134-video.c:1578:45:
got struct v4l2_clip [noderef] <asn:1>*clips

drivers/media/pci/saa7134/saa7134-video.c:1589:26: warning:
incorrect type in assignment (different address spaces) drivers/media/pci/saa7134/saa7134-video.c:1589:26:
expected struct v4l2_clip [noderef] <asn:1>*clips drivers/media/pci/saa7134/saa7134-video.c:1589:26:
got struct v4l2_clip *clips

---
 drivers/media/pci/saa7134/saa7134-video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/saa7134/saa7134-video.c +1 -1
index e3457ae..e12bbd8 100644
@@ -1575,7 +1575,7 @@ static int saa7134_g_fmt_vid_overlay(struct file *file, void *priv,
 {
 	struct saa7134_fh *fh = priv;
 	struct saa7134_dev *dev = fh->dev;
-	struct v4l2_clip *clips = f->fmt.win.clips;
+	struct v4l2_clip __user *clips = f->fmt.win.clips;
 	u32 clipcount = f->fmt.win.clipcount;
 	int err = 0;
 	int i;
Signature · 1 line
1.7.10.4